* [PATCH 03/14] dt-bindings: phy: rockchip-inno-dsidphy: Document rv1126
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
@ 2023-07-31 11:00 ` Jagan Teki
2023-07-31 20:49 ` Heiko Stübner
2023-08-11 17:52 ` Rob Herring
2023-07-31 11:00 ` [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop Jagan Teki
` (7 subsequent siblings)
8 siblings, 2 replies; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, linux-phy, devicetree, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Document a compatible string for the rv1126 dsi-dphy.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: linux-phy@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
.../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
index 5c35e5ceec0b..46e64fa293d5 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
@@ -19,6 +19,7 @@ properties:
- rockchip,rk3128-dsi-dphy
- rockchip,rk3368-dsi-dphy
- rockchip,rk3568-dsi-dphy
+ - rockchip,rv1126-dsi-dphy
reg:
maxItems: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 03/14] dt-bindings: phy: rockchip-inno-dsidphy: Document rv1126
2023-07-31 11:00 ` [PATCH 03/14] dt-bindings: phy: rockchip-inno-dsidphy: Document rv1126 Jagan Teki
@ 2023-07-31 20:49 ` Heiko Stübner
2023-08-11 17:52 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Heiko Stübner @ 2023-07-31 20:49 UTC (permalink / raw)
To: linux-arm-kernel, linux-rockchip, Jagan Teki
Cc: Jagan Teki, linux-phy, devicetree, Vinod Koul,
Kishon Vijay Abraham I, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Am Montag, 31. Juli 2023, 13:00:01 CEST schrieb Jagan Teki:
> Document a compatible string for the rv1126 dsi-dphy.
>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
Acked-by: Heiko Stuebner <heiko@sntech.de>
> ---
> Cc: linux-phy@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Kishon Vijay Abraham I <kishon@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
>
> .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> index 5c35e5ceec0b..46e64fa293d5 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> @@ -19,6 +19,7 @@ properties:
> - rockchip,rk3128-dsi-dphy
> - rockchip,rk3368-dsi-dphy
> - rockchip,rk3568-dsi-dphy
> + - rockchip,rv1126-dsi-dphy
>
> reg:
> maxItems: 1
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 03/14] dt-bindings: phy: rockchip-inno-dsidphy: Document rv1126
2023-07-31 11:00 ` [PATCH 03/14] dt-bindings: phy: rockchip-inno-dsidphy: Document rv1126 Jagan Teki
2023-07-31 20:49 ` Heiko Stübner
@ 2023-08-11 17:52 ` Rob Herring
1 sibling, 0 replies; 15+ messages in thread
From: Rob Herring @ 2023-08-11 17:52 UTC (permalink / raw)
To: Jagan Teki
Cc: Vinod Koul, Krzysztof Kozlowski, linux-phy, linux-arm-kernel,
Rob Herring, Conor Dooley, Kishon Vijay Abraham I, Heiko Stuebner,
linux-rockchip, devicetree
On Mon, 31 Jul 2023 16:30:01 +0530, Jagan Teki wrote:
> Document a compatible string for the rv1126 dsi-dphy.
>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> ---
> Cc: linux-phy@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Kishon Vijay Abraham I <kishon@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
>
> .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
2023-07-31 11:00 ` [PATCH 03/14] dt-bindings: phy: rockchip-inno-dsidphy: Document rv1126 Jagan Teki
@ 2023-07-31 11:00 ` Jagan Teki
2023-08-01 21:07 ` Conor Dooley
2023-07-31 11:00 ` [PATCH 07/14] dt-bindings: display: rockchip-dw-mipi-dsi: Document rv1126 DSI Jagan Teki
` (6 subsequent siblings)
8 siblings, 1 reply; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, dri-devel, devicetree, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Sandy Huang, David Airlie,
Daniel Vetter
Document the VOP for Rockchip RV1126.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
.../devicetree/bindings/display/rockchip/rockchip-vop.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
index df61cb5f5c54..b339b7e708c6 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
@@ -31,6 +31,7 @@ properties:
- rockchip,rk3368-vop
- rockchip,rk3399-vop-big
- rockchip,rk3399-vop-lit
+ - rockchip,rv1126-vop
reg:
minItems: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop
2023-07-31 11:00 ` [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop Jagan Teki
@ 2023-08-01 21:07 ` Conor Dooley
2023-08-02 14:37 ` Jagan Teki
0 siblings, 1 reply; 15+ messages in thread
From: Conor Dooley @ 2023-08-01 21:07 UTC (permalink / raw)
To: Jagan Teki
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip, dri-devel,
devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sandy Huang, David Airlie, Daniel Vetter
[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]
On Mon, Jul 31, 2023 at 04:30:03PM +0530, Jagan Teki wrote:
> Document the VOP for Rockchip RV1126.
>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
There's no commentary here about compatibility with other, existing,
devices nor did you CC me on the rest of the series. How am I supposed
to know if appending to enum is the right thing to do?
Ditto the other binding.
Thanks,
Conor.
> ---
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
>
> .../devicetree/bindings/display/rockchip/rockchip-vop.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
> index df61cb5f5c54..b339b7e708c6 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.yaml
> @@ -31,6 +31,7 @@ properties:
> - rockchip,rk3368-vop
> - rockchip,rk3399-vop-big
> - rockchip,rk3399-vop-lit
> + - rockchip,rv1126-vop
>
> reg:
> minItems: 1
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop
2023-08-01 21:07 ` Conor Dooley
@ 2023-08-02 14:37 ` Jagan Teki
2023-08-02 15:12 ` Conor Dooley
0 siblings, 1 reply; 15+ messages in thread
From: Jagan Teki @ 2023-08-02 14:37 UTC (permalink / raw)
To: Conor Dooley
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip, dri-devel,
devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sandy Huang, David Airlie, Daniel Vetter
On Wed, 2 Aug 2023 at 02:37, Conor Dooley <conor@kernel.org> wrote:
>
> On Mon, Jul 31, 2023 at 04:30:03PM +0530, Jagan Teki wrote:
> > Document the VOP for Rockchip RV1126.
> >
> > Signed-off-by: Jagan Teki <jagan@edgeble.ai>
>
> There's no commentary here about compatibility with other, existing,
> devices nor did you CC me on the rest of the series. How am I supposed
> to know if appending to enum is the right thing to do?
I had past comments not to add all people in the entire series and add
one relevant developer on respective patches. On that note, I tried to
CC the developers only involved in the respective areas. But, you are
CCed to the DT patch that affected this binding.
"[PATCH 10/14] ARM: dts: rockchip: rv1126: Add VOP_LITE support"
Please let me know if I missed anything.
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop
2023-08-02 14:37 ` Jagan Teki
@ 2023-08-02 15:12 ` Conor Dooley
0 siblings, 0 replies; 15+ messages in thread
From: Conor Dooley @ 2023-08-02 15:12 UTC (permalink / raw)
To: Jagan Teki
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip, dri-devel,
devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sandy Huang, David Airlie, Daniel Vetter
[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]
On Wed, Aug 02, 2023 at 08:07:55PM +0530, Jagan Teki wrote:
> On Wed, 2 Aug 2023 at 02:37, Conor Dooley <conor@kernel.org> wrote:
> >
> > On Mon, Jul 31, 2023 at 04:30:03PM +0530, Jagan Teki wrote:
> > > Document the VOP for Rockchip RV1126.
> > >
> > > Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> >
> > There's no commentary here about compatibility with other, existing,
> > devices nor did you CC me on the rest of the series. How am I supposed
> > to know if appending to enum is the right thing to do?
>
> I had past comments not to add all people in the entire series and add
> one relevant developer on respective patches. On that note, I tried to
> CC the developers only involved in the respective areas. But, you are
> CCed to the DT patch that affected this binding.
> "[PATCH 10/14] ARM: dts: rockchip: rv1126: Add VOP_LITE support"
> Please let me know if I missed anything.
I suppose you missed saying in the commit message that this is
incompatible with existing vop implementations? Don't need to CC me on
all patches (although it is useful), but please let the patches explain
themselves if you don't.
Anyway, I went on lore and had a look, so with an improved commit
message,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 07/14] dt-bindings: display: rockchip-dw-mipi-dsi: Document rv1126 DSI
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
2023-07-31 11:00 ` [PATCH 03/14] dt-bindings: phy: rockchip-inno-dsidphy: Document rv1126 Jagan Teki
2023-07-31 11:00 ` [PATCH 05/14] dt-bindings: display: rockchip-vop: Document rv1126 vop Jagan Teki
@ 2023-07-31 11:00 ` Jagan Teki
2023-08-01 21:05 ` Conor Dooley
2023-07-31 11:00 ` [PATCH 09/14] ARM: dts: rockchip: rv1126: Add PD_VO entry Jagan Teki
` (5 subsequent siblings)
8 siblings, 1 reply; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, dri-devel, devicetree, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Sandy Huang, David Airlie,
Daniel Vetter
Document the MIPI DSI for Rockchip RV1126.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: dri-devel@lists.freedesktop.org
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Sandy Huang <hjc@rock-chips.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
.../bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
index 8e8a40879140..ccf79e738fa1 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
@@ -18,6 +18,7 @@ properties:
- rockchip,rk3288-mipi-dsi
- rockchip,rk3399-mipi-dsi
- rockchip,rk3568-mipi-dsi
+ - rockchip,rv1126-mipi-dsi
- const: snps,dw-mipi-dsi
interrupts:
@@ -77,6 +78,7 @@ allOf:
enum:
- rockchip,px30-mipi-dsi
- rockchip,rk3568-mipi-dsi
+ - rockchip,rv1126-mipi-dsi
then:
properties:
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 07/14] dt-bindings: display: rockchip-dw-mipi-dsi: Document rv1126 DSI
2023-07-31 11:00 ` [PATCH 07/14] dt-bindings: display: rockchip-dw-mipi-dsi: Document rv1126 DSI Jagan Teki
@ 2023-08-01 21:05 ` Conor Dooley
0 siblings, 0 replies; 15+ messages in thread
From: Conor Dooley @ 2023-08-01 21:05 UTC (permalink / raw)
To: Jagan Teki
Cc: Heiko Stuebner, linux-arm-kernel, linux-rockchip, dri-devel,
devicetree, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sandy Huang, David Airlie, Daniel Vetter
[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]
On Mon, Jul 31, 2023 at 04:30:05PM +0530, Jagan Teki wrote:
> Document the MIPI DSI for Rockchip RV1126.
>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> Cc: dri-devel@lists.freedesktop.org
> Cc: devicetree@vger.kernel.org
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
>
> .../bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
> index 8e8a40879140..ccf79e738fa1 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml
> @@ -18,6 +18,7 @@ properties:
> - rockchip,rk3288-mipi-dsi
> - rockchip,rk3399-mipi-dsi
> - rockchip,rk3568-mipi-dsi
> + - rockchip,rv1126-mipi-dsi
> - const: snps,dw-mipi-dsi
>
> interrupts:
> @@ -77,6 +78,7 @@ allOf:
> enum:
> - rockchip,px30-mipi-dsi
> - rockchip,rk3568-mipi-dsi
> + - rockchip,rv1126-mipi-dsi
>
> then:
> properties:
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 09/14] ARM: dts: rockchip: rv1126: Add PD_VO entry
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
` (2 preceding siblings ...)
2023-07-31 11:00 ` [PATCH 07/14] dt-bindings: display: rockchip-dw-mipi-dsi: Document rv1126 DSI Jagan Teki
@ 2023-07-31 11:00 ` Jagan Teki
2023-07-31 11:00 ` [PATCH 10/14] ARM: dts: rockchip: rv1126: Add VOP_LITE support Jagan Teki
` (4 subsequent siblings)
8 siblings, 0 replies; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
PD_VO power-domain tree diagram in RV1126 is connected to
- BIU_VO
- VOP
- RGA
- IEP
- DSIHOST
Add PD_VO power-domain entry in RV1126.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
arch/arm/boot/dts/rockchip/rv1126.dtsi | 39 ++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
index afa5a68f766f..4d74d3d998ab 100644
--- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
@@ -125,6 +125,26 @@ qos_sdio: qos@fe86c000 {
reg = <0xfe86c000 0x20>;
};
+ qos_iep: qos@fe8a0000 {
+ compatible = "rockchip,rv1126-qos", "syscon";
+ reg = <0xfe8a0000 0x20>;
+ };
+
+ qos_rga_rd: qos@fe8a0080 {
+ compatible = "rockchip,rv1126-qos", "syscon";
+ reg = <0xfe8a0080 0x20>;
+ };
+
+ qos_rga_wr: qos@fe8a0100 {
+ compatible = "rockchip,rv1126-qos", "syscon";
+ reg = <0xfe8a0100 0x20>;
+ };
+
+ qos_vop: qos@fe8a0180 {
+ compatible = "rockchip,rv1126-qos", "syscon";
+ reg = <0xfe8a0180 0x20>;
+ };
+
gic: interrupt-controller@feff0000 {
compatible = "arm,gic-400";
interrupt-controller;
@@ -170,6 +190,25 @@ power-domain@RV1126_PD_SDIO {
pm_qos = <&qos_sdio>;
#power-domain-cells = <0>;
};
+
+ power-domain@RV1126_PD_VO {
+ reg = <RV1126_PD_VO>;
+ clocks = <&cru ACLK_RGA>,
+ <&cru HCLK_RGA>,
+ <&cru CLK_RGA_CORE>,
+ <&cru ACLK_VOP>,
+ <&cru HCLK_VOP>,
+ <&cru DCLK_VOP>,
+ <&cru PCLK_DSIHOST>,
+ <&cru ACLK_IEP>,
+ <&cru HCLK_IEP>,
+ <&cru CLK_IEP_CORE>;
+ pm_qos = <&qos_rga_rd>,
+ <&qos_rga_wr>,
+ <&qos_vop>,
+ <&qos_iep>;
+ #power-domain-cells = <0>;
+ };
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 10/14] ARM: dts: rockchip: rv1126: Add VOP_LITE support
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
` (3 preceding siblings ...)
2023-07-31 11:00 ` [PATCH 09/14] ARM: dts: rockchip: rv1126: Add PD_VO entry Jagan Teki
@ 2023-07-31 11:00 ` Jagan Teki
2023-07-31 11:00 ` [PATCH 11/14] ARM: dts: rockchip: rv1126: Add MIPI DSI pipeline Jagan Teki
` (3 subsequent siblings)
8 siblings, 0 replies; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
RV1126 VOP_LITE supports the video output processing ofMIPI DSI,
RGB display interfaces with max output resolution of 1920x1080.
Add support for vop in rv1126.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
arch/arm/boot/dts/rockchip/rv1126.dtsi | 42 ++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
index 4d74d3d998ab..9ccd1bad6229 100644
--- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
@@ -83,6 +83,11 @@ timer {
clock-frequency = <24000000>;
};
+ display_subsystem {
+ compatible = "rockchip,display-subsystem";
+ ports = <&vop_out>;
+ };
+
xin24m: oscillator {
compatible = "fixed-clock";
clock-frequency = <24000000>;
@@ -393,6 +398,43 @@ timer0: timer@ff660000 {
clock-names = "pclk", "timer";
};
+ vop: vop@ffb00000 {
+ compatible = "rockchip,rv1126-vop";
+ reg = <0xffb00000 0x200>, <0xffb00a00 0x400>;
+ interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
+ clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
+ clocks = <&cru ACLK_VOP>, <&cru DCLK_VOP>, <&cru HCLK_VOP>;
+ reset-names = "axi", "ahb", "dclk";
+ resets = <&cru SRST_VOP_A>, <&cru SRST_VOP_H>, <&cru SRST_VOP_D>;
+ iommus = <&vop_mmu>;
+ power-domains = <&power RV1126_PD_VO>;
+ status = "disabled";
+
+ vop_out: port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ vop_out_rgb: endpoint@0 {
+ reg = <0>;
+ };
+
+ vop_out_dsi: endpoint@1 {
+ reg = <1>;
+ };
+ };
+ };
+
+ vop_mmu: iommu@ffb00f00 {
+ compatible = "rockchip,iommu";
+ reg = <0xffb00f00 0x100>;
+ interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
+ clock-names = "aclk", "iface";
+ clocks = <&cru ACLK_VOP>, <&cru HCLK_VOP>;
+ #iommu-cells = <0>;
+ power-domains = <&power RV1126_PD_VO>;
+ status = "disabled";
+ };
+
gmac: ethernet@ffc40000 {
compatible = "rockchip,rv1126-gmac", "snps,dwmac-4.20a";
reg = <0xffc40000 0x4000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 11/14] ARM: dts: rockchip: rv1126: Add MIPI DSI pipeline
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
` (4 preceding siblings ...)
2023-07-31 11:00 ` [PATCH 10/14] ARM: dts: rockchip: rv1126: Add VOP_LITE support Jagan Teki
@ 2023-07-31 11:00 ` Jagan Teki
2023-07-31 11:00 ` [PATCH 12/14] ARM: dts: rockchip: rv1126: Add Edgeble Neu2 IO DSI overlay Jagan Teki
` (2 subsequent siblings)
8 siblings, 0 replies; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
MIPI DSI controller in RV1126 has integrated MIPI D-PHY V1.2
that supports up to 4 lanes with a 4Gbps transfer rate.
Add MIPI DSI pipeline for Rockchip RV1126.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
arch/arm/boot/dts/rockchip/rv1126.dtsi | 49 ++++++++++++++++++++++++++
1 file changed, 49 insertions(+)
diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
index 9ccd1bad6229..512cc18762b6 100644
--- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
@@ -276,6 +276,20 @@ cru: clock-controller@ff490000 {
#reset-cells = <1>;
};
+ dsi_dphy: mipi-dphy@ff4d0000 {
+ compatible = "rockchip,rv1126-dsi-dphy";
+ reg = <0xff4d0000 0x500>;
+ assigned-clocks = <&pmucru CLK_MIPIDSIPHY_REF>;
+ assigned-clock-rates = <24000000>;
+ clock-names = "ref", "pclk";
+ clocks = <&pmucru CLK_MIPIDSIPHY_REF>, <&cru PCLK_DSIPHY>;
+ #phy-cells = <0>;
+ power-domains = <&power RV1126_PD_VO>;
+ reset-names = "apb";
+ resets = <&cru SRST_DSIPHY_P>;
+ status = "disabled";
+ };
+
dmac: dma-controller@ff4e0000 {
compatible = "arm,pl330", "arm,primecell";
reg = <0xff4e0000 0x4000>;
@@ -420,6 +434,7 @@ vop_out_rgb: endpoint@0 {
vop_out_dsi: endpoint@1 {
reg = <1>;
+ remote-endpoint = <&dsi_in_vop>;
};
};
};
@@ -435,6 +450,40 @@ vop_mmu: iommu@ffb00f00 {
status = "disabled";
};
+ dsi: dsi@ffb30000 {
+ compatible = "rockchip,rv1126-mipi-dsi", "snps,dw-mipi-dsi";
+ reg = <0xffb30000 0x500>;
+ interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
+ clock-names = "pclk";
+ clocks = <&cru PCLK_DSIHOST>;
+ phy-names = "dphy";
+ phys = <&dsi_dphy>;
+ power-domains = <&power RV1126_PD_VO>;
+ reset-names = "apb";
+ resets = <&cru SRST_DSIHOST_P>;
+ rockchip,grf = <&grf>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ dsi_in_vop: endpoint {
+ remote-endpoint = <&vop_out_dsi>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ };
+ };
+ };
+
gmac: ethernet@ffc40000 {
compatible = "rockchip,rv1126-gmac", "snps,dwmac-4.20a";
reg = <0xffc40000 0x4000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 12/14] ARM: dts: rockchip: rv1126: Add Edgeble Neu2 IO DSI overlay
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
` (5 preceding siblings ...)
2023-07-31 11:00 ` [PATCH 11/14] ARM: dts: rockchip: rv1126: Add MIPI DSI pipeline Jagan Teki
@ 2023-07-31 11:00 ` Jagan Teki
2023-07-31 11:00 ` [PATCH 13/14] ARM: dts: rockchip: Add Radxa Display 10HD overlay Jagan Teki
2023-07-31 11:00 ` [PATCH 14/14] ARM: dts: rockchip: Add Radxa Display 8HD overlay Jagan Teki
8 siblings, 0 replies; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Add DSI pipeline for Edgeble Neu2 IO board via DT-overlay
The DSI connector in Edgeble Neu2 IO board support different
resolution panels and those compatible is added in another
DT-overlay.
Add Edgeble Neu2 IO DSI connector DT-overlay.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
arch/arm/boot/dts/rockchip/Makefile | 1 +
.../rockchip/rv1126-edgeble-neu2-io-dsi.dtso | 112 ++++++++++++++++++
2 files changed, 113 insertions(+)
create mode 100644 arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io-dsi.dtso
diff --git a/arch/arm/boot/dts/rockchip/Makefile b/arch/arm/boot/dts/rockchip/Makefile
index 0f46e18fe275..c8c8e1292650 100644
--- a/arch/arm/boot/dts/rockchip/Makefile
+++ b/arch/arm/boot/dts/rockchip/Makefile
@@ -3,6 +3,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
rv1108-elgin-r1.dtb \
rv1108-evb.dtb \
rv1126-edgeble-neu2-io.dtb \
+ rv1126-edgeble-neu2-io-dsi.dtbo \
rk3036-evb.dtb \
rk3036-kylin.dtb \
rk3066a-bqcurie2.dtb \
diff --git a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io-dsi.dtso b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io-dsi.dtso
new file mode 100644
index 000000000000..88431e1e30f8
--- /dev/null
+++ b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io-dsi.dtso
@@ -0,0 +1,112 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2023 Edgeble AI Technologies Pvt. Ltd.
+ *
+ * DT-overlay for Edgeble Neu2 IO DSI Connector.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+
+&{/} {
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm2 0 25000 0>;
+ enable-gpios = <&gpio2 RK_PD6 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&backlight_en>;
+ };
+
+ vcc_lcd_mipi_2: vcc-lcd-mipi-2-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_lcd_mipi_2";
+ enable-active-high;
+ gpio = <&gpio3 RK_PB0 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vcc_lcd_mipi_2_en>;
+ regulator-boot-on;
+ vin-supply = <&v3v3_sys>;
+ };
+
+ vcc_1v8_2: vcc-1v8-2-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_1v8_2";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+};
+
+&dsi_dphy {
+ status = "okay";
+};
+
+&dsi {
+ clock-master;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@1 {
+ reg = <1>;
+
+ mipi_out_panel: endpoint {
+ remote-endpoint = <&mipi_in_panel>;
+ };
+ };
+ };
+
+ panel: panel@0 {
+ /* different resolution panels are used, compatibles are in DTO */
+ reg = <0>;
+ vdd-supply = <&vcc_lcd_mipi_2>;
+ vccio-supply = <&vcc_1v8_2>;
+ reset-gpios = <&gpio3 RK_PB3 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&lcd_reset>;
+ backlight = <&backlight>;
+
+ port {
+ mipi_in_panel: endpoint {
+ remote-endpoint = <&mipi_out_panel>;
+ };
+ };
+ };
+};
+
+&pinctrl {
+ lcd {
+ backlight_en: backlight-en {
+ rockchip,pins = <2 RK_PD6 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+
+ lcd_reset: lcd-reset {
+ rockchip,pins = <3 RK_PB3 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+
+ vcc_lcd_mipi_2_en: vcc-lcd-mipi-2-en {
+ rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+};
+
+&pwm2 {
+ status = "okay";
+};
+
+&vop {
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 13/14] ARM: dts: rockchip: Add Radxa Display 10HD overlay
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
` (6 preceding siblings ...)
2023-07-31 11:00 ` [PATCH 12/14] ARM: dts: rockchip: rv1126: Add Edgeble Neu2 IO DSI overlay Jagan Teki
@ 2023-07-31 11:00 ` Jagan Teki
2023-07-31 11:00 ` [PATCH 14/14] ARM: dts: rockchip: Add Radxa Display 8HD overlay Jagan Teki
8 siblings, 0 replies; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Add compatible string of Radxa Display 10HD via DT-overlay.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
arch/arm/boot/dts/rockchip/Makefile | 1 +
arch/arm/boot/dts/rockchip/radxa-display-10hd.dtso | 14 ++++++++++++++
2 files changed, 15 insertions(+)
create mode 100644 arch/arm/boot/dts/rockchip/radxa-display-10hd.dtso
diff --git a/arch/arm/boot/dts/rockchip/Makefile b/arch/arm/boot/dts/rockchip/Makefile
index c8c8e1292650..0a275549b213 100644
--- a/arch/arm/boot/dts/rockchip/Makefile
+++ b/arch/arm/boot/dts/rockchip/Makefile
@@ -1,5 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
dtb-$(CONFIG_ARCH_ROCKCHIP) += \
+ radxa-display-10hd.dtbo \
rv1108-elgin-r1.dtb \
rv1108-evb.dtb \
rv1126-edgeble-neu2-io.dtb \
diff --git a/arch/arm/boot/dts/rockchip/radxa-display-10hd.dtso b/arch/arm/boot/dts/rockchip/radxa-display-10hd.dtso
new file mode 100644
index 000000000000..7393b9417647
--- /dev/null
+++ b/arch/arm/boot/dts/rockchip/radxa-display-10hd.dtso
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2023 Radxa Computer Co., Ltd.
+ * Copyright (c) 2023 Edgeble AI Technologies Pvt. Ltd.
+ *
+ * DT-overlay for Radxa Display 10HD compatible.
+ */
+
+/dts-v1/;
+/plugin/;
+
+&panel {
+ compatible = "radxa,display-10hd-ad001", "jadard,jd9365da-h3";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 14/14] ARM: dts: rockchip: Add Radxa Display 8HD overlay
[not found] <20230731110012.2913742-1-jagan@edgeble.ai>
` (7 preceding siblings ...)
2023-07-31 11:00 ` [PATCH 13/14] ARM: dts: rockchip: Add Radxa Display 10HD overlay Jagan Teki
@ 2023-07-31 11:00 ` Jagan Teki
8 siblings, 0 replies; 15+ messages in thread
From: Jagan Teki @ 2023-07-31 11:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-arm-kernel, linux-rockchip
Cc: Jagan Teki, devicetree, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Add compatible string of Radxa Display 8HD via DT-overlay.
Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Conor Dooley <conor+dt@kernel.org>
arch/arm/boot/dts/rockchip/Makefile | 1 +
arch/arm/boot/dts/rockchip/radxa-display-8hd.dtso | 14 ++++++++++++++
2 files changed, 15 insertions(+)
create mode 100644 arch/arm/boot/dts/rockchip/radxa-display-8hd.dtso
diff --git a/arch/arm/boot/dts/rockchip/Makefile b/arch/arm/boot/dts/rockchip/Makefile
index 0a275549b213..053d24978f82 100644
--- a/arch/arm/boot/dts/rockchip/Makefile
+++ b/arch/arm/boot/dts/rockchip/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
dtb-$(CONFIG_ARCH_ROCKCHIP) += \
radxa-display-10hd.dtbo \
+ radxa-display-8hd.dtbo \
rv1108-elgin-r1.dtb \
rv1108-evb.dtb \
rv1126-edgeble-neu2-io.dtb \
diff --git a/arch/arm/boot/dts/rockchip/radxa-display-8hd.dtso b/arch/arm/boot/dts/rockchip/radxa-display-8hd.dtso
new file mode 100644
index 000000000000..d42499f8d6b2
--- /dev/null
+++ b/arch/arm/boot/dts/rockchip/radxa-display-8hd.dtso
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2023 Radxa Computer Co., Ltd.
+ * Copyright (c) 2023 Edgeble AI Technologies Pvt. Ltd.
+ *
+ * DT-overlay for Radxa Display 8HD compatible.
+ */
+
+/dts-v1/;
+/plugin/;
+
+&panel {
+ compatible = "radxa,display-8hd-ad002", "jadard,jd9365da-h3";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 15+ messages in thread