From: Svyatoslav Ryhel <clamor95@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Svyatoslav Ryhel <clamor95@gmail.com>,
Samu Onkalo <samu.p.onkalo@nokia.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 2/2] misc: adps990x: convert to OF
Date: Mon, 31 Jul 2023 14:02:39 +0300 [thread overview]
Message-ID: <20230731110239.107086-3-clamor95@gmail.com> (raw)
In-Reply-To: <20230731110239.107086-1-clamor95@gmail.com>
Add ability to use device tree bindings keeping existing setup.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/misc/apds990x.c | 55 +++++++++++++++++++++++++++++++++++------
1 file changed, 48 insertions(+), 7 deletions(-)
diff --git a/drivers/misc/apds990x.c b/drivers/misc/apds990x.c
index 0024503ea6db..cf56d68c938a 100644
--- a/drivers/misc/apds990x.c
+++ b/drivers/misc/apds990x.c
@@ -1051,6 +1051,37 @@ static const struct attribute_group apds990x_attribute_group[] = {
{.attrs = sysfs_attrs_ctrl },
};
+static int apds990x_fw_probe(struct i2c_client *client,
+ struct apds990x_chip *chip)
+{
+ struct apds990x_platform_data *pdata;
+ u32 ret, val;
+
+ pdata = devm_kzalloc(&client->dev, sizeof(*pdata), GFP_KERNEL);
+ if (!pdata)
+ return -ENOMEM;
+
+ ret = device_property_read_u32(&client->dev, "avago,pdrive", &val);
+ if (ret)
+ return dev_err_probe(&client->dev, ret,
+ "pdrive property is missing\n");
+ pdata->pdrive = val;
+
+ ret = device_property_read_u32(&client->dev, "avago,ppcount", &val);
+ if (ret)
+ return dev_err_probe(&client->dev, ret,
+ "ppcount property is missing\n");
+ pdata->ppcount = val;
+
+ chip->pdata = pdata;
+
+ /* set regulator names which fit device tree entries */
+ chip->regs[0].supply = "vdd";
+ chip->regs[1].supply = "vled";
+
+ return 0;
+}
+
static int apds990x_probe(struct i2c_client *client)
{
struct apds990x_chip *chip;
@@ -1065,12 +1096,12 @@ static int apds990x_probe(struct i2c_client *client)
init_waitqueue_head(&chip->wait);
mutex_init(&chip->mutex);
- chip->pdata = client->dev.platform_data;
- if (chip->pdata == NULL) {
- dev_err(&client->dev, "platform data is mandatory\n");
- err = -EINVAL;
- goto fail1;
+ chip->pdata = client->dev.platform_data;
+ if (!chip->pdata) {
+ err = apds990x_fw_probe(client, chip);
+ if (err)
+ return err;
}
if (chip->pdata->cf.ga == 0) {
@@ -1111,8 +1142,11 @@ static int apds990x_probe(struct i2c_client *client)
chip->prox_persistence = APDS_DEFAULT_PROX_PERS;
chip->prox_continuous_mode = false;
- chip->regs[0].supply = reg_vcc;
- chip->regs[1].supply = reg_vled;
+ if (!chip->regs[0].supply)
+ chip->regs[0].supply = reg_vcc;
+
+ if (!chip->regs[1].supply)
+ chip->regs[1].supply = reg_vled;
err = regulator_bulk_get(&client->dev,
ARRAY_SIZE(chip->regs), chip->regs);
@@ -1252,6 +1286,12 @@ static int apds990x_runtime_resume(struct device *dev)
#endif
+static const struct of_device_id apds990x_match_table[] = {
+ { .compatible = "avago,apds990x" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, apds990x_match_table);
+
static const struct i2c_device_id apds990x_id[] = {
{"apds990x", 0 },
{}
@@ -1270,6 +1310,7 @@ static struct i2c_driver apds990x_driver = {
.driver = {
.name = "apds990x",
.pm = &apds990x_pm_ops,
+ .of_match_table = apds990x_match_table,
},
.probe_new = apds990x_probe,
.remove = apds990x_remove,
--
2.39.2
next prev parent reply other threads:[~2023-07-31 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 11:02 [PATCH v1 0/2] Update APDS990x ALS to support device trees Svyatoslav Ryhel
2023-07-31 11:02 ` [PATCH v1 1/2] dt-bindings: iio: light: add apds990x binding Svyatoslav Ryhel
2023-07-31 13:23 ` Arnd Bergmann
2023-07-31 11:02 ` Svyatoslav Ryhel [this message]
2023-07-31 13:18 ` [PATCH v1 2/2] misc: adps990x: convert to OF Arnd Bergmann
2023-07-31 14:58 ` Svyatoslav Ryhel
2023-07-31 15:38 ` Arnd Bergmann
2023-08-01 18:10 ` Jonathan Cameron
2023-08-01 18:13 ` Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731110239.107086-3-clamor95@gmail.com \
--to=clamor95@gmail.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samu.p.onkalo@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox