From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Judy Hsiao <judyhsiao@chromium.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Conor Dooley <conor+dt@kernel.org>, Takashi Iwai <tiwai@suse.com>,
linux-mediatek@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
alsa-devel@alsa-project.org, NXP Linux Team <linux-imx@nxp.com>,
Rao Mandadapu <srivasam@codeaurora.org>,
Trevor Wu <trevor.wu@mediatek.com>,
Jonathan Bakker <xc-racer2@live.ca>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Cheng-Yi Chiang <cychiang@chromium.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
devicetree@vger.kernel.org,
Rohit kumar <quic_rohkumar@quicinc.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
Shawn Guo <shawnguo@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/12] ASoC: dt-bindings: mediatek,mt8188-mt6359: use common sound card
Date: Mon, 31 Jul 2023 08:38:59 -0600 [thread overview]
Message-ID: <20230731143859.GA2928327-robh@kernel.org> (raw)
In-Reply-To: <169080070077.2404962.11506468692056687115.robh@kernel.org>
On Mon, Jul 31, 2023 at 04:51:46AM -0600, Rob Herring wrote:
>
> On Mon, 31 Jul 2023 11:42:54 +0200, Krzysztof Kozlowski wrote:
> > The mediatek,mt8188-mt6359 Linux sound machine driver requires the
> > "model" property, so binding was incomplete. Reference the common sound
> > card properties to fix that which also allows to remove duplicated
> > property definitions. Leave the relevant parts of "audio-routing"
> > description.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > .../bindings/sound/mediatek,mt8188-mt6359.yaml | 17 +++++++----------
> > 1 file changed, 7 insertions(+), 10 deletions(-)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.yaml:
> Error in referenced schema matching $id: http://devicetree.org/schemas/sound/sound-card-common.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.example.dtb: sound: False schema does not allow {'compatible': ['mediatek,mt8188-mt6359-evb'], 'model': ['MT6359-EVB'], 'mediatek,platform': [[4294967295]], 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'audio-routing': ['Headphone', 'Headphone L', 'Headphone', 'Headphone R', 'AIN1', 'Headset Mic'], 'dai-link-0': {'link-name': ['ETDM3_OUT_BE'], 'dai-format': ['i2s'], 'mediatek,clk-provider': ['cpu'], 'codec': {'sound-dai': [[4294967295]]}}, '$nodename': ['sound']}
> from schema $id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml#
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/mediatek,mt8188-mt6359.example.dtb: sound: Unevaluated properties are not allowed ('model' was unexpected)
> from schema $id: http://devicetree.org/schemas/sound/mediatek,mt8188-mt6359.yaml#
Looks like patch 2 could not be applied causing this.
Rob
next prev parent reply other threads:[~2023-07-31 14:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 9:42 [PATCH 00/12] ASoC: dt-bindings: Add sound-card-common.yaml Krzysztof Kozlowski
2023-07-31 9:42 ` [PATCH 01/12] ASoC: dt-bindings: amlogic,gx-sound-card: correct maxItems constraints Krzysztof Kozlowski
2023-07-31 9:52 ` Jerome Brunet
2023-07-31 14:46 ` Mark Brown
2023-08-10 6:29 ` Krzysztof Kozlowski
2023-07-31 9:42 ` [PATCH 02/12] ASoC: dt-bindings: Add common sound card properties Krzysztof Kozlowski
2023-07-31 10:43 ` AngeloGioacchino Del Regno
2023-07-31 9:42 ` [PATCH 03/12] ASoC: dt-bindings: mediatek,mt8188-mt6359: use common sound card Krzysztof Kozlowski
2023-07-31 10:43 ` AngeloGioacchino Del Regno
[not found] ` <169080070077.2404962.11506468692056687115.robh@kernel.org>
2023-07-31 14:38 ` Rob Herring [this message]
2023-07-31 9:42 ` [PATCH 04/12] ASoC: dt-bindings: samsung,aries-wm8994: " Krzysztof Kozlowski
2023-07-31 14:41 ` Rob Herring
2023-07-31 9:42 ` [PATCH 05/12] ASoC: dt-bindings: samsung,midas-audio: " Krzysztof Kozlowski
2023-07-31 14:41 ` Rob Herring
2023-07-31 9:42 ` [PATCH 06/12] ASoC: dt-bindings: samsung,odroid: " Krzysztof Kozlowski
2023-07-31 10:51 ` Rob Herring
2023-07-31 9:42 ` [PATCH 07/12] ASoC: dt-bindings: samsung,tm2: " Krzysztof Kozlowski
2023-07-31 14:43 ` Rob Herring
2023-07-31 9:42 ` [PATCH 08/12] ASoC: samsung: odroid: use of_property_present to check for property Krzysztof Kozlowski
2023-07-31 9:43 ` [PATCH 09/12] ASoC: samsung: aries_wm8994: parse audio-routing Krzysztof Kozlowski
2023-07-31 9:43 ` [PATCH 10/12] ASoC: samsung: midas_wm1811: " Krzysztof Kozlowski
2023-07-31 9:43 ` [PATCH 11/12] ASoC: samsung: odroid: " Krzysztof Kozlowski
2023-07-31 9:43 ` [PATCH 12/12] ASoC: samsung: tm2_wm5110: " Krzysztof Kozlowski
2023-08-17 22:36 ` (subset) [PATCH 00/12] ASoC: dt-bindings: Add sound-card-common.yaml Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731143859.GA2928327-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=judyhsiao@chromium.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=quic_rohkumar@quicinc.com \
--cc=s.hauer@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=srivasam@codeaurora.org \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).