From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7372C001E0 for ; Tue, 1 Aug 2023 14:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234418AbjHAODu (ORCPT ); Tue, 1 Aug 2023 10:03:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234188AbjHAODj (ORCPT ); Tue, 1 Aug 2023 10:03:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B97F7213D; Tue, 1 Aug 2023 07:03:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 572046158F; Tue, 1 Aug 2023 14:03:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D135C433C8; Tue, 1 Aug 2023 14:03:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690898615; bh=J1Kv0/7tNUUdsgbJSV348cn2wjwWWI28VoiCD919J1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cRKTjP5gMBMuoyifvof5VTmSNc6vDWI9l5DkvIxTqN4QHv+XXe7n40Rbnar0jyB4E rhzGXQd0Q8thtuaf289xIFb0DvaVXzgJVlzdMSSBd/iKa+Qsk6cZ4BASCYKiYFl7Lv 4LeI9+5CILuHfqT6mu+1xMMp4xTeO/aq+4C5lV+nn+MyUx9K2nZm5fqbFE0jMorNaY F4Y0KAz2vf1Y5mAyR0sUaDzx6kSNKGJcFwA2RFubIphJqnavP/xqSqNA6BPYP0PgPL xsAaz/2mMR9o2fYVFrN8Ywj0stbVbxxK9a6VfXgdK5h9RXbPUX4BczmD/9tT+6NkRX 7BnuQyIex18Pw== Date: Tue, 1 Aug 2023 15:03:27 +0100 From: Conor Dooley To: Keith Zhao Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , Sumit Semwal , christian.koenig@amd.com, Bjorn Andersson , Heiko Stuebner , Shawn Guo , Jagan Teki , Chris Morgan , Jack Zhu , Shengyang Chen , Changhuang Liang Subject: Re: [PATCH v1 v1 2/7] dt-bindings: display: Add yamls for JH7110 display system Message-ID: <20230801-cash-squad-8a2e9154af8b@spud> References: <20230801101030.2040-1-keith.zhao@starfivetech.com> <20230801101030.2040-3-keith.zhao@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e6NUZOkjskRZqTKd" Content-Disposition: inline In-Reply-To: <20230801101030.2040-3-keith.zhao@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --e6NUZOkjskRZqTKd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 01, 2023 at 06:10:25PM +0800, Keith Zhao wrote: > StarFive SoCs JH7110 display system: > lcd-controller bases verisilicon dc8200 IP, > and hdmi bases Innosilicon IP. > Add bindings for them. Please, you can use more than 46 characters in a line! Also, "v1 v1" does not a v2 make. >=20 > Signed-off-by: Keith Zhao > --- > .../starfive/starfive,display-subsystem.yaml | 41 +++++++ > .../starfive/starfive,jh7110-dc8200.yaml | 107 ++++++++++++++++++ > .../starfive/starfive,jh7110-inno-hdmi.yaml | 92 +++++++++++++++ > 3 files changed, 240 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/starfive/st= arfive,display-subsystem.yaml > create mode 100644 Documentation/devicetree/bindings/display/starfive/st= arfive,jh7110-dc8200.yaml > create mode 100644 Documentation/devicetree/bindings/display/starfive/st= arfive,jh7110-inno-hdmi.yaml >=20 > diff --git a/Documentation/devicetree/bindings/display/starfive/starfive,= display-subsystem.yaml b/Documentation/devicetree/bindings/display/starfive= /starfive,display-subsystem.yaml > new file mode 100644 > index 000000000..86018a8e6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/starfive/starfive,display= -subsystem.yaml > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/starfive/starfive,display-sub= system.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive DRM master device > + > +maintainers: > + - Keith Zhao > + - ShengYang Chen > + > +description: > + The Starfive DRM master device is a virtual device needed to list all > + display controller or other display interface nodes that comprise the > + graphics subsystem. > + > +properties: > + compatible: > + const: starfive,display-subsystem > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | A | is not needed when you do not have formatting to preserve. > + Should contain a list of phandles pointing to display interface po= rts > + of display controller devices. Display controller definitions as d= efined > + in Documentation/devicetree/bindings/display/starfive/ > + starfive,jh7110-dc8200.yaml > + > +required: > + - compatible > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + display-subsystem { > + compatible =3D "starfive,display-subsystem"; > + ports =3D <&dc_out>; > + }; Given Rob's bot complains, it looks like you never tested this. > diff --git a/Documentation/devicetree/bindings/display/starfive/starfive,= jh7110-dc8200.yaml b/Documentation/devicetree/bindings/display/starfive/sta= rfive,jh7110-dc8200.yaml > new file mode 100644 > index 000000000..bebe2050c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/starfive/starfive,jh7110-= dc8200.yaml > @@ -0,0 +1,107 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/starfive/starfive,jh7110-dc82= 00.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive display controller > + > +description: > + The StarFive SoC uses the display controller based on Verisilicon IP > + to transfer the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Keith Zhao > + > +properties: > + compatible: > + const: starfive,jh7110-dc8200 > + > + reg: > + maxItems: 3 What do each of these represent? > + > + interrupts: > + items: > + - description: The interrupt will be generated when DC finish one = frame > + > + clocks: > + items: > + - description: Clock for display system noc bus. > + - description: Pixel clock for display channel 0. > + - description: Pixel clock for display channel 1. > + - description: Clock for axi interface of display controller. > + - description: Core clock for display controller. > + - description: Clock for ahb interface of display controller. > + - description: External HDMI pixel clock. > + - description: Parent clock for pixel clock > + > + clock-names: > + items: > + - const: vout_noc_disp > + - const: vout_pix0 > + - const: vout_pix1 > + - const: vout_axi > + - const: vout_core > + - const: vout_vout_ahb > + - const: hdmitx0_pixel > + - const: vout_dc8200 > + > + resets: > + items: > + - description: Reset for axi interface of display controller. > + - description: Reset for ahb interface of display controller. > + - description: Core reset of display controller. > + > + reset-names: > + items: > + - const: vout_axi > + - const: vout_ahb > + - const: vout_core Please trim all the vouts from here & the clocks - especially the one named "vout_vout_ahb". > + > + port: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + A port node with endpoint definitions as defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt. This file is empty, it has been converted to yaml. > diff --git a/Documentation/devicetree/bindings/display/starfive/starfive,= jh7110-inno-hdmi.yaml b/Documentation/devicetree/bindings/display/starfive/= starfive,jh7110-inno-hdmi.yaml > new file mode 100644 > index 000000000..f6927acf6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/starfive/starfive,jh7110-= inno-hdmi.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/starfive/starfive,jh7110-inno= -hdmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Starfive JH7110 HDMI controller > + > +description: > + The StarFive JH7110 SoC uses the HDMI signal transmiter based on innos= ilicon IP > + to generate HDMI signal from its input and transmit the signal to the = screen. > + > +maintainers: > + - Keith Zhao > + > +properties: > + compatible: > + const: "starfive,jh7110-inno-hdmi" > + > + reg: > + minItems: 1 > + > + interrupts: > + items: > + - description: The HDMI hot plug detection interrupt. > + > + clocks: > + items: > + - description: System clock of HDMI module. > + - description: Mclk clock of HDMI audio. > + - description: Bclk clock of HDMI audio. > + - description: Pixel clock generated by HDMI module. > + > + clock-names: > + items: > + - const: sysclk > + - const: mclk > + - const: bclk > + - const: pclk > + > + resets: > + items: > + - description: Reset for HDMI module. For this & resets, you don't have a list & don't need items: Cheers, Conor. --e6NUZOkjskRZqTKd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZMkQrwAKCRB4tDGHoIJi 0hF/AQC/1GTXuwyc+w2g9RKifKromVQFlvBvFI0JlmYNLu6I9gEAqVJE6rLiklf3 jktEbPFxEUmQR4+8/IvlY0DbYWbksgw= =bnBb -----END PGP SIGNATURE----- --e6NUZOkjskRZqTKd--