From: Conor Dooley <conor@kernel.org>
To: Mihai Sain <mihai.sain@microchip.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
andre.przywara@arm.com, andrei.simion@microchip.com,
jerry.ray@microchip.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, cristian.birsan@microchip.com
Subject: Re: [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity
Date: Tue, 1 Aug 2023 16:35:15 +0100 [thread overview]
Message-ID: <20230801-unbalance-baguette-cd0d4e7e0107@spud> (raw)
In-Reply-To: <20230801111151.6546-1-mihai.sain@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 1360 bytes --]
Hey,
On Tue, Aug 01, 2023 at 02:11:50PM +0300, Mihai Sain wrote:
> From: Andrei Simion <andrei.simion@microchip.com>
>
> Document device tree binding of SAMA5D29 Curiosity, from Microchip.
>
> Reviewed-by: Mihai Sain <mihai.sain@microchip.com>
> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
Your SoB is missing from here.
> ---
> Documentation/devicetree/bindings/arm/atmel-at91.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index dfb8fd089197..89d75fbb1de4 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -79,6 +79,13 @@ properties:
> - const: atmel,sama5d2
> - const: atmel,sama5
>
> + - description: Microchip SAMA5D29 Curiosity
> + items:
> + - const: microchip,sama5d29-curiosity
> + - const: atmel,sama5d29
> + - const: atmel,sama5d2
> + - const: atmel,sama5
What is the benefit of adding the two familial compatibles? Is there
software that actually uses these?
Thanks,
Conor.
> +
> - items:
> - const: atmel,sama5d27
> - const: atmel,sama5d2
> --
> 2.41.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-01 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 11:11 [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity Mihai Sain
2023-08-01 11:11 ` [PATCH 2/2] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board Mihai Sain
2023-08-02 4:40 ` claudiu beznea
2023-08-02 12:19 ` Mihai.Sain
2023-08-03 9:09 ` claudiu beznea
2023-09-11 16:01 ` Nicolas Ferre
2023-09-12 11:01 ` claudiu beznea
2023-08-02 5:02 ` claudiu beznea
2023-08-02 11:59 ` Mihai.Sain
2023-08-01 15:35 ` Conor Dooley [this message]
2023-08-02 12:42 ` [PATCH 1/2] dt-bindings: ARM: at91: Document Microchip SAMA5D29 Curiosity Mihai.Sain
2023-08-02 15:39 ` Conor Dooley
2023-09-11 15:03 ` Nicolas Ferre
2023-09-11 15:57 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801-unbalance-baguette-cd0d4e7e0107@spud \
--to=conor@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=andrei.simion@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jerry.ray@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.sain@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).