From: Conor Dooley <conor@kernel.org>
To: Yinbo Zhu <zhuyinbo@loongson.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v2 1/2] gpio: dt-bindings: add parsing of loongson gpio offset
Date: Tue, 1 Aug 2023 08:23:23 +0100 [thread overview]
Message-ID: <20230801-whenever-imitation-b2759b212f6b@spud> (raw)
In-Reply-To: <041bf8a6-8d91-c2ce-6752-aa7255f946c7@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 906 bytes --]
On Tue, Aug 01, 2023 at 02:39:49PM +0800, Yinbo Zhu wrote:
>
>
> 在 2023/7/31 下午11:55, Conor Dooley 写道:
> > On Mon, Jul 31, 2023 at 05:10:58PM +0800, Yinbo Zhu wrote:
> > > Add parsing GPIO configure, input, output, interrupt register offset
> > > address and GPIO control mode support.
> >
> > This reeks of insufficient use of SoC specific compatibles. Do GPIO
> > controllers on the same SoC have different register offsets?
>
>
> Yes,
>
> > Where are the users for this?
>
>
> For example, ls2k500 contains multiple GPIO chips with different
> (configure, input, output, interrupt) offset addresses, but all others
> are the same.
Right. That's admittedly not what I expected to hear! Can you firstly
explain this in the commit message, and secondly add a soc-specific
compatible for the ls2k500 and only allow these properties on that SoC?
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-01 7:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 9:10 [PATCH v2 0/2] gpio: loongson: add firmware offset parse support Yinbo Zhu
2023-07-31 9:10 ` [PATCH v2 1/2] gpio: dt-bindings: add parsing of loongson gpio offset Yinbo Zhu
2023-07-31 15:55 ` Conor Dooley
2023-08-01 6:39 ` Yinbo Zhu
2023-08-01 7:23 ` Conor Dooley [this message]
2023-08-01 8:34 ` Yinbo Zhu
2023-08-01 15:54 ` Conor Dooley
2023-08-02 1:38 ` Yinbo Zhu
2023-08-02 7:22 ` Conor Dooley
2023-08-02 7:44 ` Yinbo Zhu
2023-08-02 7:50 ` Conor Dooley
2023-08-02 8:37 ` Yinbo Zhu
2023-08-02 15:36 ` Conor Dooley
2023-08-03 1:56 ` Yinbo Zhu
2023-08-03 6:30 ` Conor Dooley
2023-08-03 6:41 ` Krzysztof Kozlowski
2023-08-03 9:42 ` Yinbo Zhu
2023-07-31 9:10 ` [PATCH v2 2/2] gpio: loongson: add firmware offset parse support Yinbo Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801-whenever-imitation-b2759b212f6b@spud \
--to=conor@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).