From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D189FC04E69 for ; Tue, 1 Aug 2023 17:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233201AbjHARaH (ORCPT ); Tue, 1 Aug 2023 13:30:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230219AbjHARaG (ORCPT ); Tue, 1 Aug 2023 13:30:06 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A5D6E0; Tue, 1 Aug 2023 10:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZvTRdKUSUCAlBq6z3PWYIniKn+jbmGKNY+UDBwFRuzM=; b=ey1Wayli86L3djfdin+4kg0By7 gwK/elO18xN215cRvoeGvEGlsbZiuwTOJuBPPFPVmIgE0bgCn74jhYQ43AQGwsoy5qAI5Ok3PKHY1 8DK+zombrHVYE7qV/JzrIeplCgOXFw8dfQFSLNVO7yY9eXHTJyikXL/hJ47+Qy/EchxY=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:53184 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qQtC3-00015J-Vy; Tue, 01 Aug 2023 13:30:00 -0400 Date: Tue, 1 Aug 2023 13:29:59 -0400 From: Hugo Villeneuve To: Greg KH Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, isaac.true@canonical.com, jesse.sung@canonical.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Hugo Villeneuve , Lech Perczak , Andy Shevchenko Message-Id: <20230801132959.7c02e86f4c863f997226965a@hugovil.com> In-Reply-To: <2023073135-puppy-reflected-700d@gregkh> References: <20230725142343.1724130-1-hugo@hugovil.com> <20230725142343.1724130-4-hugo@hugovil.com> <2023073135-puppy-reflected-700d@gregkh> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com Subject: Re: [PATCH v9 03/10] serial: sc16is7xx: remove obsolete out_thread label X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 31 Jul 2023 17:53:10 +0200 Greg KH wrote: > On Tue, Jul 25, 2023 at 10:23:35AM -0400, Hugo Villeneuve wrote: > > From: Hugo Villeneuve > > > > Commit c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later > > in probe") moved GPIO setup code later in probe function. Doing so > > also required to move ports cleanup code (out_ports label) after the > > GPIO cleanup code. > > > > After these moves, the out_thread label becomes misplaced and makes > > part of the cleanup code illogical. > > > > This patch remove the now obsolete out_thread label and make GPIO > > setup code jump to out_ports label if it fails. > > > > Fixes: c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later in probe") > > Signed-off-by: Hugo Villeneuve > > Reviewed-by: Lech Perczak > > Tested-by: Lech Perczak > > Reviewed-by: Andy Shevchenko > > Why is this not ok for stable kernels yet it has a Fixes: tag? > > Please fix. > > thanks, > > greg k-h Hi, this is a somewhat particular case. It is a change that "fixes" some previously unseen consequence in original commit, but that does not result in any binary change in the end. That is why I decided not to put in a "stable" tag. If you want, maybe it would be simpler to remove the "Fixes" tag? I originally put this tag to have a reference to the original commit, but since it is already mentioned in the commit log message body, it can be removed. Hugo.