From: Nishanth Menon <nm@ti.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Hiago De Franco <hiago.franco@toradex.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH v1 2/2] arm64: dts: ti: k3-am625-verdin: enable CAN_2
Date: Tue, 1 Aug 2023 22:43:25 -0500 [thread overview]
Message-ID: <20230802034325.puqhry4xocaceldl@clothes> (raw)
In-Reply-To: <20230724133612.37366-3-francesco@dolcini.it>
On 15:36-20230724, Francesco Dolcini wrote:
[...]
> + /* Verdin CAN_2 */
> + pinctrl_mcu_mcan0: mcu-mcan0-default-pins {
> + pinctrl-single,pins = <
> + AM62X_MCU_IOPAD(0x0038, PIN_INPUT, 0) /* (B3) MCU_MCAN0_RX */ /* SODIMM 26 */
> + AM62X_MCU_IOPAD(0x0034, PIN_OUTPUT, 0) /* (D6) MCU_MCAN0_TX */ /* SODIMM 24 */
This is minor - I realize we already accepted this, but:
/* (B3) MCU_MCAN0_RX */ /* SODIMM 26 */
Vs
/* (B3) MCU_MCAN0_RX - SODIMM 26 */
I wonder if you'd like the second style.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2023-08-02 3:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 13:36 [PATCH v1 0/2] arm64: dts: ti: k3-am62: Add MCU MCAN Francesco Dolcini
2023-07-24 13:36 ` [PATCH v1 1/2] arm64: dts: ti: k3-am62: Add MCU MCAN nodes Francesco Dolcini
2023-07-24 16:06 ` Judith Mendez
2023-07-24 16:22 ` Francesco Dolcini
2023-07-24 16:25 ` Judith Mendez
2023-08-02 3:41 ` Nishanth Menon
2023-07-24 13:36 ` [PATCH v1 2/2] arm64: dts: ti: k3-am625-verdin: enable CAN_2 Francesco Dolcini
2023-08-02 3:43 ` Nishanth Menon [this message]
2023-08-02 7:42 ` Francesco Dolcini
2023-08-02 13:19 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802034325.puqhry4xocaceldl@clothes \
--to=nm@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=francesco@dolcini.it \
--cc=hiago.franco@toradex.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox