From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jejb@linux.ibm.com, martin.petersen@oracle.com,
alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
quic_asutoshd@quicinc.com, quic_cang@quicinc.com,
quic_nitirawa@quicinc.com, quic_narepall@quicinc.com,
quic_bhaskarv@quicinc.com, quic_richardp@quicinc.com,
quic_nguyenb@quicinc.com, quic_ziqichen@quicinc.com,
bmasney@redhat.com, krzysztof.kozlowski@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/6] scsi: ufs: host: Add support for parsing OPP
Date: Wed, 2 Aug 2023 11:06:13 +0530 [thread overview]
Message-ID: <20230802053613.GF2370@thinkpad> (raw)
In-Reply-To: <20230801090333.pqqugj4tcarwdl2o@vireshk-i7>
On Tue, Aug 01, 2023 at 02:33:33PM +0530, Viresh Kumar wrote:
> On 31-07-23, 22:03, Manivannan Sadhasivam wrote:
> > +int ufshcd_opp_config_clks(struct device *dev, struct opp_table *opp_table,
> > + struct dev_pm_opp *opp, void *data,
> > + bool scaling_down)
> > +{
> > + struct ufs_hba *hba = dev_get_drvdata(dev);
> > + struct list_head *head = &hba->clk_list_head;
> > + struct ufs_clk_info *clki;
> > + unsigned long freq;
> > + u8 idx = 0;
> > + int ret;
> > +
> > + list_for_each_entry(clki, head, list) {
> > + if (!IS_ERR_OR_NULL(clki->clk)) {
>
> NULL is considered as a valid clock AFAIR, so you must only be doing
> IS_ERR() here I guess.
Agree that clk_ APIs accept NULL clk, but we already have IS_ERR_OR_NULL() check
everywhere in the driver for clk handling. So I used the same for consistency.
- Mani
>
> --
> viresh
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-08-02 5:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 16:33 [PATCH v3 0/6] UFS: Add OPP support Manivannan Sadhasivam
2023-07-31 16:33 ` [PATCH v3 1/6] dt-bindings: ufs: common: add OPP table Manivannan Sadhasivam
2023-07-31 16:33 ` [PATCH v3 2/6] PM / devfreq: Switch to dev_pm_opp_find_freq_{ceil/floor}_indexed() APIs Manivannan Sadhasivam
2023-07-31 16:33 ` [PATCH v3 3/6] scsi: ufs: core: Add OPP support for scaling clocks and regulators Manivannan Sadhasivam
2023-07-31 16:33 ` [PATCH v3 4/6] scsi: ufs: host: Add support for parsing OPP Manivannan Sadhasivam
2023-08-01 9:03 ` Viresh Kumar
2023-08-02 5:36 ` Manivannan Sadhasivam [this message]
2023-07-31 16:33 ` [PATCH v3 5/6] arm64: dts: qcom: sdm845: Add OPP table support to UFSHC Manivannan Sadhasivam
2023-09-11 13:15 ` Dmitry Baryshkov
2023-09-12 6:59 ` Manivannan Sadhasivam
2023-09-27 11:15 ` Viresh Kumar
2023-09-27 12:39 ` Manivannan Sadhasivam
2023-07-31 16:33 ` [PATCH v3 6/6] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802053613.GF2370@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bmasney@redhat.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).