From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBBF4C41513 for ; Wed, 2 Aug 2023 07:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbjHBHed (ORCPT ); Wed, 2 Aug 2023 03:34:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231322AbjHBHed (ORCPT ); Wed, 2 Aug 2023 03:34:33 -0400 Received: from mx1.sberdevices.ru (mx1.sberdevices.ru [37.18.73.165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FECEEA; Wed, 2 Aug 2023 00:34:29 -0700 (PDT) Received: from p-infra-ksmg-sc-msk01 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 23D05100020; Wed, 2 Aug 2023 10:34:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 23D05100020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1690961666; bh=WEU63Mnt7xTNDDQGjM0C7uIxpJ9fktvAmk1Do9eEtOY=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=RPPs93NQIPNcaOI+7A6n755i37dFmijxDygr3TMHsVr5s5JVd+FMEOQ6IisJR+vf8 LM2VYm8c4ozNhSacvvhTV/D/A3yUQbHEB8gHWfseVM7tR3r/nh60AgaFXei+GAlKzI 7+S4sOnn3TmIHpFj5I1U23/VmA51zeWjw1coj6QNEzmwLFCFtJHLz9XmFPpUULfRlm KKEfKXPDgaLZ7qdRMbSDuLcS9D+HhasNwxRqPmPk1mFNCszgvtDUCkL1A9obrk6L0t UMcTexsG0OE/xG8nhkYV4CP62XRWGO8TqcGyPzV6RyNWirYvl1HfAceVAN90hSSKZa iCQ/NMK4UIzLA== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 2 Aug 2023 10:34:26 +0300 (MSK) Received: from localhost (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 2 Aug 2023 10:34:25 +0300 Date: Wed, 2 Aug 2023 10:34:25 +0300 From: Dmitry Rokosov To: Huqiang Qin CC: , , , , , , , , , , , , , Subject: Re: [PATCH 2/4] watchdog: Add a new struct for Amlogic-GXBB driver Message-ID: <20230802073425.urdu3xtoxm6ob3aa@CAB-WSD-L081021> References: <20230726112146.1127145-1-huqiang.qin@amlogic.com> <20230726112146.1127145-3-huqiang.qin@amlogic.com> <20230728071558.xoa3sdku3zkuhtug@CAB-WSD-L081021> <01357346-59f3-5c5a-d456-8e64381fe611@amlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <01357346-59f3-5c5a-d456-8e64381fe611@amlogic.com> User-Agent: NeoMutt/20220415 X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 178796 [Jul 22 2023] X-KSMG-AntiSpam-Version: 5.9.59.0 X-KSMG-AntiSpam-Envelope-From: DDRokosov@sberdevices.ru X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 525 525 723604743bfbdb7e16728748c3fa45e9eba05f7d, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/07/23 08:49:00 #21663637 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Aug 01, 2023 at 08:51:30PM +0800, Huqiang Qin wrote: > Hi Dmitry, > > On 2023/7/28 15:15, Dmitry Rokosov wrote: > > [ EXTERNAL EMAIL ] > > > > Hello Huqiang, > > > > Thank you for the patch series! > > > > Please include a cover letter in future patch submissions if possible. > > It will help to better understand the theme of the patch series and > > group all patch sets together in one email thread. > > Thank you for your suggestion. In fact, this patch series contains > a cover letter. It may be due to network reasons that it was not > sent to your mailbox correctly :) > Ah, sorry, you are right... Now I see your cover letter on the lore.kernel.org... My mail server makes a magic... > ... > >> static int meson_gxbb_wdt_start(struct watchdog_device *wdt_dev) > >> { > >> struct meson_gxbb_wdt *data = watchdog_get_drvdata(wdt_dev); > >> @@ -140,8 +143,12 @@ static const struct dev_pm_ops meson_gxbb_wdt_pm_ops = { > >> SET_SYSTEM_SLEEP_PM_OPS(meson_gxbb_wdt_suspend, meson_gxbb_wdt_resume) > >> }; > >> > >> +static const struct wdt_params gxbb_params = { > >> + .rst_shift = 21, > > > > Maybe it's better to declare rst with the BIT() macro already applied, > > and use it in wdt_probe() as is. And name 'rst' without 'shift' is > > looking more brief. > > Okay, I will change it in the next version. > > > Thanks > > Best Regards, > Huqiang Qin -- Thank you, Dmitry