From: "Carsten Spieß" <mail@carsten-spiess.de>
To: Conor Dooley <conor@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: hwmon: add renesas,isl28022
Date: Wed, 2 Aug 2023 09:30:23 +0200 [thread overview]
Message-ID: <20230802093023.1a926c9f.mail@carsten-spiess.de> (raw)
In-Reply-To: <20230801-implicate-mullets-bd160bbda4b2@spud>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On 8/1/23 22:52, Conor Dooley wrote:
> On Tue, Aug 01, 2023 at 06:35:46PM +0200, Carsten Spieß wrote:
> > Add dt-bindings for Renesas ISL28022 power monitor.
> > +properties:
> > + compatible:
> > + enum:
> > + - renesas,isl28022
>
> You've only got one compatible, why the enum? Will there be more similar
> devices that have an incompatible programming model?
Yes, there are isl28023 and isl28025 with different register addresses,
might be supported in future releases.
> > + renesas,shunt-range-microvolt:
> > + description: |
>
> You don't need these |s if you have no formatting to preserve in the
> text.
Will fix in v4.
> Otherwise, this does look good to me.
Thanks, regards
Carsten
[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-02 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230801163546.3170-1-mail@carsten-spiess.de>
2023-08-01 16:35 ` [PATCH v3 2/2] dt-bindings: hwmon: add renesas,isl28022 Carsten Spieß
2023-08-01 20:52 ` Conor Dooley
2023-08-02 7:30 ` Carsten Spieß [this message]
2023-08-02 7:43 ` Conor Dooley
2023-08-02 15:07 ` Guenter Roeck
2023-08-02 15:05 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802093023.1a926c9f.mail@carsten-spiess.de \
--to=mail@carsten-spiess.de \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).