From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCB6EB64DD for ; Thu, 3 Aug 2023 12:34:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234382AbjHCMez (ORCPT ); Thu, 3 Aug 2023 08:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbjHCMey (ORCPT ); Thu, 3 Aug 2023 08:34:54 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A05D0126; Thu, 3 Aug 2023 05:34:53 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6146E113E; Thu, 3 Aug 2023 05:35:36 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 600BB3F6C4; Thu, 3 Aug 2023 05:34:50 -0700 (PDT) Date: Thu, 3 Aug 2023 13:34:47 +0100 From: Andre Przywara To: Martin Botka Cc: Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Martin Botka , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Icenowy Zheng , Ludwig Kormann , Andrew Lunn , Heiko Stuebner , Shawn Guo , Bjorn Andersson , Chris Morgan , Jagan Teki , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/6] dt-bindings: arm: sunxi: Add BigTreeTech CB1 Message-ID: <20230803133447.29eb9157@donnerap.manchester.arm.com> In-Reply-To: <54C66F97A81FBC29+20230802220309.163804-3-martin@biqu3d.com> References: <20230802220309.163804-1-martin@biqu3d.com> <54C66F97A81FBC29+20230802220309.163804-3-martin@biqu3d.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 3 Aug 2023 00:02:35 +0200 Martin Botka wrote: Hi, > From: Martin Botka > > Add a name & compatible for BigTreeTech CB1 SoM > > Signed-off-by: Martin Botka > --- > Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > index ee8fdd2da869..5ae1b81af6fc 100644 > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > @@ -151,6 +151,11 @@ properties: > - const: roofull,beelink-x2 > - const: allwinner,sun8i-h3 > > + - description: BigTreeTech CB1 SoM > + items: > + - const: bigtreetech,cb1 > + - const: allwinner,sun50i-h616 > + If I get this correctly, the CB1 is the SoM, which cannot be used on its own, right? In this case there is no need for an entry in this file, since this combination will never appear in a board .dts file alone. So just drop this patch then. Cheers, Andre > - description: Chuwi V7 CW0825 > items: > - const: chuwi,v7-cw0825