From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 249F0EB64DD for ; Thu, 3 Aug 2023 12:39:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231143AbjHCMjV (ORCPT ); Thu, 3 Aug 2023 08:39:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbjHCMjU (ORCPT ); Thu, 3 Aug 2023 08:39:20 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DAD543586; Thu, 3 Aug 2023 05:39:18 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 92CB7113E; Thu, 3 Aug 2023 05:40:01 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6CB4E3F6C4; Thu, 3 Aug 2023 05:39:15 -0700 (PDT) Date: Thu, 3 Aug 2023 13:39:13 +0100 From: Andre Przywara To: Martin Botka Cc: Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Martin Botka , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andrew Lunn , Icenowy Zheng , Ludwig Kormann , Heiko Stuebner , Shawn Guo , Bjorn Andersson , Chris Morgan , Jagan Teki , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 6/6] arm64: dts: allwinner: h616: Add BigTreeTech Pi support Message-ID: <20230803133913.368d055d@donnerap.manchester.arm.com> In-Reply-To: References: <20230802220309.163804-1-martin@biqu3d.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 3 Aug 2023 00:02:39 +0200 Martin Botka wrote: Hi, > The BigTreeTech Pi is an H616 based board based on CB1. > Just in Rpi format board. > > It features the same internals as BTT CB1 but adds: > - Fan port > - IR receiver You would then need to enable the "ir" node, check the X96 Mate .dts. And I think this "ADXL345 SPI" connector justifies enabling the respective SPI node. > - 24V DC power supply via terminal plugs > - USB to CAN module connector (The actual USB to CAN happens on the external module) Still confused how this works. So you would need to connect an USB->CAN adapter to one of the USB ports, but how do you feed the CAN signal back to the board? Or if this is done via this port, where does it go then? To the GPIO header? > List of currently working things is the same as BTT CB1. > > Signed-off-by: Martin Botka > --- > .../allwinner/sun50i-h616-bigtreetech-pi.dts | 44 +++++++++++++++++++ Please wire this up in the Makefile as well, otherwise we will miss out on the build testing and DTB checking. > 1 file changed, 44 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > new file mode 100644 > index 000000000000..05f39b3606ba > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-bigtreetech-pi.dts > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > +/* > + * Copyright (C) 2023 Martin Botka . > + */ > + > +/dts-v1/; > + > +#include "sun50i-h616-bigtreetech-cb1.dtsi" > + > +/ { > + compatible = "bigtreetech,pi", "allwinner,sun50i-h616"; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&ohci0 { > + status = "okay"; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&ohci1 { > + status = "okay"; > +}; > + > +&ehci2 { > + status = "okay"; > +}; > + > +&ohci2 { > + status = "okay"; > +}; > + > +&ehci3 { > + status = "okay"; > +}; > + > +&ohci3 { > + status = "okay"; > +}; Oh wow, it really connects all four USB ports directly to the SoC? Nice. Do you have access to the schematic to check what the power supply situation is? Are all ports hardwired to a fixed 5V source? And you would of course need to adjust this file according to the changes requested in the previous patch, so that you have the UART, stdout-path and other moved nodes in here. Cheers, Andre