devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: marius.cristea@microchip.com
Cc: jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Adding support for Microchip MCP3564 ADC family
Date: Fri, 4 Aug 2023 16:28:28 +0100	[thread overview]
Message-ID: <20230804-doze-confining-edf4f50d736d@spud> (raw)
In-Reply-To: <20230804142820.89593-1-marius.cristea@microchip.com>

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

On Fri, Aug 04, 2023 at 05:28:18PM +0300, marius.cristea@microchip.com wrote:
> From: Marius Cristea <marius.cristea@microchip.com>
> 
> Adding support for Microchip family of 153.6 ksps, Low-Noise 16/24-Bit
> Delta-Sigma ADCs with an SPI interface. This driver covers the following part
> numbers:
>  - MCP3561, MCP3562, MCP3564, MCP3561R, MCP3562R, MCP3564R,
>  - MCP3461, MCP3462, MCP3464, MCP3461R, MCP3462R and MCP3464R.
> 
> Differences related to previous patch:
> v3:
> - fix review comments:
>   - fix and update the device tree bindings
>   - enable "auto_zeroing_ref_enable" attribute only
>     when internal reference is used
>   - remove unused headers
>   - fix comments (kernel-docs)
>   - remove scan_type
>   - replace "extend_name" with read_label
>   - print label for each channel (label could be added into the dt)
>   - add comment to explain the maximum channels numbers
>   - add protection around critical region

>   - fallback compatible in device tree to deal with some newer part number

The compatibles are all still in an enum in the binding with no
fallbacks. Did you forget to commit this?

Thanks,
Conor.

>   
> - Open questions:
>   - whether or not to add a spi-mux type of thing to deal with the part number
>     address in case there are multiple devices connected to the same chip
>     select.
>   - discussion related to the "custom property". Last time around a consensus
>     wasn't reached. 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2023-08-04 15:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 14:28 [PATCH v3 0/2] Adding support for Microchip MCP3564 ADC family marius.cristea
2023-08-04 14:28 ` [PATCH v3 1/2] dt-bindings: iio: adc: adding MCP3564 ADC marius.cristea
2023-08-05 17:39   ` Jonathan Cameron
2023-08-04 14:28 ` [PATCH v3 2/2] iio: adc: adding support for " marius.cristea
2023-08-05 17:59   ` Jonathan Cameron
2023-08-18 16:29     ` Marius.Cristea
2023-08-28 13:48       ` Jonathan Cameron
2023-08-04 15:28 ` Conor Dooley [this message]
2023-08-05 17:08 ` [PATCH v3 0/2] Adding support for Microchip MCP3564 ADC family Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230804-doze-confining-edf4f50d736d@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marius.cristea@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).