From: Conor Dooley <conor@kernel.org>
To: Mihai Sain <mihai.sain@microchip.com>
Cc: claudiu.beznea@tuxon.dev, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
nicolas.ferre@microchip.com, cristian.birsan@microchip.com,
alexandre.belloni@bootlin.com, andre.przywara@arm.com,
jerry.ray@microchip.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, andrei.simion@microchip.com
Subject: Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board
Date: Fri, 4 Aug 2023 17:28:39 +0100 [thread overview]
Message-ID: <20230804-starlet-facebook-051f59b7eac8@spud> (raw)
In-Reply-To: <20230804101043.4063-1-mihai.sain@microchip.com>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
Hey,
Firstly, $subject is missing a "v2" inside the []s.
On Fri, Aug 04, 2023 at 01:10:43PM +0300, Mihai Sain wrote:
> Add initial device tree file for sama5d29_curiosity board.
>
> Changes in v2:
> * drop dt-bindings patch
> * remove vdd_1v8 regulator
> * fix flx4 node to use 1 spi node and pinctrl
> * add i2s0 node and pinctrl
> * remove macb0 node and pinctrl
> * remove unused pinctrl
> * sort in alphabetical order all nodes and pinctrl
> * replace "_" with "-" in node names
This needs to go under the --- line, not in the commit message.
Perhaps Claudiu would be willing to fix it, but certainly for future
versions this needs fixing.
Thanks,
Conor.
>
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-04 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 10:10 [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board Mihai Sain
2023-08-04 16:28 ` Conor Dooley [this message]
2023-08-09 4:56 ` claudiu beznea
2023-08-10 6:47 ` Mihai.Sain
2023-08-15 5:19 ` claudiu beznea
2023-08-16 9:05 ` Mihai.Sain
2023-08-16 14:38 ` Conor Dooley
2023-08-17 5:31 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804-starlet-facebook-051f59b7eac8@spud \
--to=conor@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andre.przywara@arm.com \
--cc=andrei.simion@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=jerry.ray@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.sain@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).