From: Rob Herring <robh@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Icenowy Zheng <uwu@icenowy.me>, Shengyu Qu <wiagn233@outlook.com>,
Martin Botka <martin.botka@somainline.org>,
Martin Botka <martin@biqu3d.com>, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] dt-bindings: mfd: x-powers,axp152: make interrupt optional for more chips
Date: Fri, 4 Aug 2023 09:34:32 -0600 [thread overview]
Message-ID: <20230804153432.GA1388331-robh@kernel.org> (raw)
In-Reply-To: <20230802141829.522595-1-andre.przywara@arm.com>
On Wed, Aug 02, 2023 at 03:18:29PM +0100, Andre Przywara wrote:
> All X-Powers PMICs described by this binding have an IRQ pin, and so
> far (almost) all boards connected this to some NMI pin or GPIO on the SoC
> they are connected to.
> However we start to see boards that omit this connection, and technically
> the IRQ pin is not essential to the basic PMIC operation.
> The existing Linux driver allows skipping an IRQ pin setup for some
> chips already, so update the binding to also make the DT property
> optional for these chips, so that we can actually have DTs describing
> boards with the PMIC interrupt not wired up.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Hi,
>
> arguably the IRQ functionality is optional for many more PMICs,
> especially if a board doesn't use GPIOs or a power key.
> So I wonder if the interrupts property should become optional for all?
> After all it's more a board designer's decision to wire up the IRQ pin
> or not, and nothing that's really related to a particular PMIC.
I would say yes. Particularly if it gets rid of a conditional schema.
Rob
next prev parent reply other threads:[~2023-08-04 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 14:18 [PATCH] dt-bindings: mfd: x-powers,axp152: make interrupt optional for more chips Andre Przywara
2023-08-02 19:07 ` Martin Botka
2023-08-03 15:55 ` Conor Dooley
2023-08-04 15:34 ` Rob Herring [this message]
2023-08-07 13:42 ` Andre Przywara
2023-08-07 16:34 ` Chen-Yu Tsai
2023-08-05 15:43 ` Shengyu Qu
2023-08-05 22:50 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804153432.GA1388331-robh@kernel.org \
--to=robh@kernel.org \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=martin@biqu3d.com \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).