* [PATCH 1/1] arm64: dts: imx93: Fix anatop node size
@ 2023-07-28 8:34 Alexander Stein
2023-08-01 1:23 ` Peng Fan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alexander Stein @ 2023-07-28 8:34 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Fabio Estevam, Peng Fan
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
devicetree, linux-arm-kernel
Although the memory map of i.MX93 reference manual rev. 2 claims that
analog top has start address of 0x44480000 and end address of 0x4448ffff,
this overlaps with TMU memory area starting at 0x44482000, as stated in
section 73.6.1.
As PLL configuration registers start at addresses up to 0x44481400, as used
by clk-imx93, reduce the anatop size to 0x2000, so exclude the TMU area
but keep all PLL registers inside.
Fixes: ec8b5b5058ea ("arm64: dts: freescale: Add i.MX93 dtsi support")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Unfortunately TMU isn't listed in memory map, so it was a bit of guess work.
This fixes the probe failure of qoriq_thermal:
qoriq_thermal 44482000.tmu: can't request region for resource [mem 0x44482000-0x44482fff]
qoriq_thermal 44482000.tmu: Failed to get memory region
qoriq_thermal: probe of 44482000.tmu failed with error -16
/proc/iomem also shows it's claimed by anatop:
> 44480000-4448ffff : 44450000.clock-controller anatop@44480000
arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 4ec9df78f2050..6f85a05ee7e1a 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -379,7 +379,7 @@ mediamix: power-domain@44462400 {
anatop: anatop@44480000 {
compatible = "fsl,imx93-anatop", "syscon";
- reg = <0x44480000 0x10000>;
+ reg = <0x44480000 0x2000>;
};
tmu: tmu@44482000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] arm64: dts: imx93: Fix anatop node size
2023-07-28 8:34 [PATCH 1/1] arm64: dts: imx93: Fix anatop node size Alexander Stein
@ 2023-08-01 1:23 ` Peng Fan
2023-08-01 2:02 ` Jacky Bai
2023-08-06 3:50 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2023-08-01 1:23 UTC (permalink / raw)
To: Alexander Stein, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Fabio Estevam, Peng Fan
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
linux-arm-kernel
On 7/28/2023 4:34 PM, Alexander Stein wrote:
>
>
> Although the memory map of i.MX93 reference manual rev. 2 claims that
> analog top has start address of 0x44480000 and end address of 0x4448ffff,
> this overlaps with TMU memory area starting at 0x44482000, as stated in
> section 73.6.1.
> As PLL configuration registers start at addresses up to 0x44481400, as used
> by clk-imx93, reduce the anatop size to 0x2000, so exclude the TMU area
> but keep all PLL registers inside.
>
> Fixes: ec8b5b5058ea ("arm64: dts: freescale: Add i.MX93 dtsi support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> Unfortunately TMU isn't listed in memory map, so it was a bit of guess work.
>
> This fixes the probe failure of qoriq_thermal:
> qoriq_thermal 44482000.tmu: can't request region for resource [mem 0x44482000-0x44482fff]
> qoriq_thermal 44482000.tmu: Failed to get memory region
> qoriq_thermal: probe of 44482000.tmu failed with error -16
>
> /proc/iomem also shows it's claimed by anatop:
>> 44480000-4448ffff : 44450000.clock-controller anatop@44480000
>
> arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 4ec9df78f2050..6f85a05ee7e1a 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -379,7 +379,7 @@ mediamix: power-domain@44462400 {
>
> anatop: anatop@44480000 {
> compatible = "fsl,imx93-anatop", "syscon";
> - reg = <0x44480000 0x10000>;
> + reg = <0x44480000 0x2000>;
> };
>
> tmu: tmu@44482000 {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH 1/1] arm64: dts: imx93: Fix anatop node size
2023-07-28 8:34 [PATCH 1/1] arm64: dts: imx93: Fix anatop node size Alexander Stein
2023-08-01 1:23 ` Peng Fan
@ 2023-08-01 2:02 ` Jacky Bai
2023-08-06 3:50 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Jacky Bai @ 2023-08-01 2:02 UTC (permalink / raw)
To: Alexander Stein, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Fabio Estevam, Peng Fan
Cc: Pengutronix Kernel Team, dl-linux-imx, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 1/1] arm64: dts: imx93: Fix anatop node size
>
> Although the memory map of i.MX93 reference manual rev. 2 claims that
> analog top has start address of 0x44480000 and end address of 0x4448ffff,
> this overlaps with TMU memory area starting at 0x44482000, as stated in
> section 73.6.1.
> As PLL configuration registers start at addresses up to 0x44481400, as used by
> clk-imx93, reduce the anatop size to 0x2000, so exclude the TMU area but
> keep all PLL registers inside.
>
> Fixes: ec8b5b5058ea ("arm64: dts: freescale: Add i.MX93 dtsi support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Yes, the anatop size should be changed. Found the same issue after rebase our downstream kernel to 6.5.0-rc1.
Reviewed-by: Jacky Bai <ping.bai@nxp.com>
BR
> ---
> Unfortunately TMU isn't listed in memory map, so it was a bit of guess work.
>
> This fixes the probe failure of qoriq_thermal:
> qoriq_thermal 44482000.tmu: can't request region for resource [mem
> 0x44482000-0x44482fff] qoriq_thermal 44482000.tmu: Failed to get memory
> region
> qoriq_thermal: probe of 44482000.tmu failed with error -16
>
> /proc/iomem also shows it's claimed by anatop:
> > 44480000-4448ffff : 44450000.clock-controller anatop@44480000
>
> arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 4ec9df78f2050..6f85a05ee7e1a 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -379,7 +379,7 @@ mediamix: power-domain@44462400 {
>
> anatop: anatop@44480000 {
> compatible = "fsl,imx93-anatop", "syscon";
> - reg = <0x44480000 0x10000>;
> + reg = <0x44480000 0x2000>;
> };
>
> tmu: tmu@44482000 {
> --
> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] arm64: dts: imx93: Fix anatop node size
2023-07-28 8:34 [PATCH 1/1] arm64: dts: imx93: Fix anatop node size Alexander Stein
2023-08-01 1:23 ` Peng Fan
2023-08-01 2:02 ` Jacky Bai
@ 2023-08-06 3:50 ` Shawn Guo
2 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2023-08-06 3:50 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Fabio Estevam, Peng Fan, Pengutronix Kernel Team, NXP Linux Team,
devicetree, linux-arm-kernel
On Fri, Jul 28, 2023 at 10:34:35AM +0200, Alexander Stein wrote:
> Although the memory map of i.MX93 reference manual rev. 2 claims that
> analog top has start address of 0x44480000 and end address of 0x4448ffff,
> this overlaps with TMU memory area starting at 0x44482000, as stated in
> section 73.6.1.
> As PLL configuration registers start at addresses up to 0x44481400, as used
> by clk-imx93, reduce the anatop size to 0x2000, so exclude the TMU area
> but keep all PLL registers inside.
>
> Fixes: ec8b5b5058ea ("arm64: dts: freescale: Add i.MX93 dtsi support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-06 3:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 8:34 [PATCH 1/1] arm64: dts: imx93: Fix anatop node size Alexander Stein
2023-08-01 1:23 ` Peng Fan
2023-08-01 2:02 ` Jacky Bai
2023-08-06 3:50 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).