From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>
Cc: John Watts <contact@jookia.org>,
Maksim Kiselev <bigunclemax@gmail.com>,
aou@eecs.berkeley.edu, conor+dt@kernel.org, davem@davemloft.net,
devicetree@vger.kernel.org, edumazet@google.com,
krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-sunxi@lists.linux.dev, netdev@vger.kernel.org,
pabeni@redhat.com, palmer@dabbelt.com, paul.walmsley@sifive.com,
robh+dt@kernel.org, samuel@sholland.org, wens@csie.org,
wg@grandegger.com
Subject: Re: [PATCH v2 2/4] riscv: dts: allwinner: d1: Add CAN controller nodes
Date: Mon, 7 Aug 2023 09:30:40 +0200 [thread overview]
Message-ID: <20230807-thorn-sponge-bd59b35feebe-mkl@pengutronix.de> (raw)
In-Reply-To: <20230807-denatured-gangrene-e6f37ba5f9ef-mkl@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]
On 07.08.2023 09:16:41, Marc Kleine-Budde wrote:
> On 06.08.2023 13:42:28, Jernej Škrabec wrote:
> > Dne nedelja, 06. avgust 2023 ob 08:33:45 CEST je John Watts napisal(a):
> > > On Sat, Aug 05, 2023 at 07:49:51PM +0200, Jernej Škrabec wrote:
> > > > Dne sobota, 05. avgust 2023 ob 18:51:53 CEST je John Watts napisal(a):
> > > > > On Sat, Aug 05, 2023 at 07:40:52PM +0300, Maksim Kiselev wrote:
> > > > > > Hi John, Jernej
> > > > > > Should we also keep a pinctrl nodes itself in alphabetical order?
> > > > > > I mean placing a CAN nodes before `clk_pg11_pin` node?
> > > > > > Looks like the other nodes sorted in this way...
> > > > >
> > > > > Good catch. Now that you mention it, the device tree nodes are sorted
> > > > > by memory order too! These should be after i2c3.
> > > > >
> > > > > It looks like I might need to do a patch to re-order those too.
> > > >
> > > > It would be better if DT patches are dropped from netdev tree and then
> > > > post
> > > > new versions.
> > > >
> > > > Best regards,
> > > > Jernej
> > >
> > > Agreed. Is there a way to request that? Or will the maintainer just read
> > > this?
> >
> > Hopefully it will.
>
> I'm just catching up on last week's post (I had a long off-line
> weekend).
>
> I'll revert the DT changes and send a PR to net-next.
Here's the revert:
| https://lore.kernel.org/all/20230807-riscv-allwinner-d1-revert-can-controller-nodes-v1-1-eb3f70b435d9@pengutronix.de/
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-08-07 7:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 22:15 [PATCH v2 0/4] Add support for Allwinner D1 CAN controllers John Watts
2023-07-21 22:15 ` [PATCH v2 1/4] dt-bindings: net: can: Add support for Allwinner D1 CAN controller John Watts
2023-07-22 9:29 ` Krzysztof Kozlowski
2023-07-21 22:15 ` [PATCH v2 2/4] riscv: dts: allwinner: d1: Add CAN controller nodes John Watts
2023-07-23 9:18 ` John Watts
2023-07-30 22:03 ` Jernej Škrabec
2023-07-31 2:38 ` John Watts
2023-08-05 16:40 ` Maksim Kiselev
2023-08-05 16:51 ` John Watts
2023-08-05 17:49 ` Jernej Škrabec
2023-08-06 6:33 ` John Watts
2023-08-06 11:42 ` Jernej Škrabec
2023-08-07 7:16 ` Marc Kleine-Budde
2023-08-07 7:30 ` Marc Kleine-Budde [this message]
2023-07-21 22:15 ` [PATCH v2 3/4] can: sun4i_can: Add acceptance register quirk John Watts
2023-07-21 22:15 ` [PATCH v2 4/4] can: sun4i_can: Add support for the Allwinner D1 John Watts
2023-08-22 12:30 ` Geert Uytterhoeven
2023-08-23 3:16 ` John Watts
2023-07-24 8:27 ` [PATCH v2 0/4] Add support for Allwinner D1 CAN controllers Marc Kleine-Budde
2023-09-01 16:25 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807-thorn-sponge-bd59b35feebe-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=aou@eecs.berkeley.edu \
--cc=bigunclemax@gmail.com \
--cc=conor+dt@kernel.org \
--cc=contact@jookia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).