From: Andi Shyti <andi.shyti@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Svyatoslav Ryhel <clamor95@gmail.com>,
Iskren Chernev <me@iskren.info>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Matheus Castello <matheus@castello.eng.br>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Alim Akhtar <alim.akhtar@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Stefan Hansson <newbie13xd@gmail.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v3 4/4] ARM: configs: s5pv210_defconfig: enable IIO required by MAX17040
Date: Mon, 7 Aug 2023 10:55:43 +0200 [thread overview]
Message-ID: <20230807085543.3tfzpsa2joolay3r@intel.intel> (raw)
In-Reply-To: <16047849-1001-4d6f-4995-0fdfc065cded@linaro.org>
Hi,
On Sun, Aug 06, 2023 at 10:29:04AM +0200, Krzysztof Kozlowski wrote:
> On 06/08/2023 00:42, Andi Shyti wrote:
> > Hi Svyatoslav,
> >
> > On Mon, Jul 31, 2023 at 10:36:13AM +0300, Svyatoslav Ryhel wrote:
> >> After adding support for passing temperature data from thermal sensor
> >> to MAX17040 it got dependency on CONFIG_IIO. From all defconfigs
> >> using MAX17040 only s5pv210_defconfig did not have IIO already enabled
> >> so let's enable it to avoid regression.
> >>
> >> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> >> ---
> >> arch/arm/configs/s5pv210_defconfig | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/configs/s5pv210_defconfig b/arch/arm/configs/s5pv210_defconfig
> >> index 4c1e480b5bbd..24070ee3d43e 100644
> >> --- a/arch/arm/configs/s5pv210_defconfig
> >> +++ b/arch/arm/configs/s5pv210_defconfig
> >> @@ -97,6 +97,7 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
> >> CONFIG_RTC_CLASS=y
> >> CONFIG_RTC_DRV_MAX8998=m
> >> CONFIG_DMADEVICES=y
> >> +CONFIG_IIO=y
> >> CONFIG_PWM=y
> >> CONFIG_PWM_SAMSUNG=y
> >> CONFIG_PHY_SAMSUNG_USB2=m
> >
> > Should this patch be squashed to the previous patch? I think you
> > break bisectability for this board if you enable iio only here.
>
> The defconfig change matters less - distros don't use them - so this
> points to the fact that patchset affected the users. All existing users
> of max17040 drivers, who do not enable IIO, will have their setups broken.
That's why I'm suggesting to squash this patch with the previous.
Anyway, up to you... except of this note everything looks fine in
the series.
Andi
next prev parent reply other threads:[~2023-08-07 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 7:36 [PATCH v3 0/4] Add optional properties to MAX17040 Svyatoslav Ryhel
2023-07-31 7:36 ` [PATCH v3 1/4] dt-bindings: power: supply: maxim,max17040: update properties Svyatoslav Ryhel
2023-07-31 7:36 ` [PATCH v3 2/4] power: max17040: pass status property from supplier Svyatoslav Ryhel
2023-07-31 7:36 ` [PATCH v3 3/4] power: max17040: get thermal data from adc if available Svyatoslav Ryhel
2023-07-31 7:36 ` [PATCH v3 4/4] ARM: configs: s5pv210_defconfig: enable IIO required by MAX17040 Svyatoslav Ryhel
2023-08-05 22:42 ` Andi Shyti
2023-08-06 8:29 ` Krzysztof Kozlowski
2023-08-07 8:55 ` Andi Shyti [this message]
2023-08-07 13:51 ` Krzysztof Kozlowski
2023-09-11 11:39 ` (subset) " Krzysztof Kozlowski
2023-07-31 15:49 ` [PATCH v3 0/4] Add optional properties to MAX17040 Iskren Chernev
2023-09-14 15:42 ` (subset) " Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807085543.3tfzpsa2joolay3r@intel.intel \
--to=andi.shyti@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=clamor95@gmail.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=matheus@castello.eng.br \
--cc=me@iskren.info \
--cc=newbie13xd@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).