* [PATCH v2 0/4] arm64: dts: ti: k3-j784s4: Add bootph-pre-ram property for SPL nodes
@ 2023-08-07 18:56 Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: " Apurva Nandan
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Apurva Nandan @ 2023-08-07 18:56 UTC (permalink / raw)
To: Apurva Nandan, Nishanth Menon, Vignesh Raghavendra, Tero Kristo,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Udit Kumar, Hari Nagalla,
Dasnavis Sabiya
Add bootph-pre-ram property for all the nodes used in SPL stage,
for syncing it later to u-boot j784s4 dts.
This series will be ported to the u-boot k3-j784s4 support patch series,
and was requested in its review process:
https://lore.kernel.org/u-boot/20230321155227.GV8135@bill-the-cat/
Changelog:
1) Added k3-am69-sk.dts bootph-pre-ram patch
2) Added bootph-pre-ram for wkup_pmx0 and ospi0
3) Added bootph-pre-ram for mcu_timer1
Link to v1: https://lore.kernel.org/linux-arm-kernel/20230806164838.18088-1-a-nandan@ti.com/
Apurva Nandan (4):
arm64: dts: ti: k3-j784s4-main: Add bootph-pre-ram property for SPL
nodes
arm64: dts: ti: k3-j784s4-mcu-wakeup: Add bootph-pre-ram property for
SPL nodes
arm64: dts: ti: k3-j784s4-evm: Add bootph-pre-ram property for SPL
nodes
arm64: dts: ti: k3-am69-sk: Add bootph-pre-ram property for SPL nodes
arch/arm64/boot/dts/ti/k3-am69-sk.dts | 13 ++++++++++
arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 25 +++++++++++++++++++
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++
.../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 10 ++++++++
4 files changed, 51 insertions(+)
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: Add bootph-pre-ram property for SPL nodes
2023-08-07 18:56 [PATCH v2 0/4] arm64: dts: ti: k3-j784s4: Add bootph-pre-ram property for SPL nodes Apurva Nandan
@ 2023-08-07 18:56 ` Apurva Nandan
2023-08-07 19:07 ` Nishanth Menon
2023-08-07 18:56 ` [PATCH v2 2/4] arm64: dts: ti: k3-j784s4-mcu-wakeup: " Apurva Nandan
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Apurva Nandan @ 2023-08-07 18:56 UTC (permalink / raw)
To: Apurva Nandan, Nishanth Menon, Vignesh Raghavendra, Tero Kristo,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Udit Kumar, Hari Nagalla,
Dasnavis Sabiya
Add bootph-pre-ram property for all the nodes used in SPL stage,
for syncing it later to u-boot j784s4 dts.
Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
index 2ea0adae6832..aaec569fe91a 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
@@ -6,6 +6,7 @@
*/
&cbass_main {
+ bootph-pre-ram;
msmc_ram: sram@70000000 {
compatible = "mmio-sram";
reg = <0x00 0x70000000 0x00 0x800000>;
@@ -670,6 +671,7 @@ main_sdhci1: mmc@4fb0000 {
};
main_navss: bus@30000000 {
+ bootph-pre-ram;
compatible = "simple-bus";
#address-cells = <2>;
#size-cells = <2>;
@@ -705,6 +707,7 @@ main_udmass_inta: msi-controller@33d00000 {
};
secure_proxy_main: mailbox@32c00000 {
+ bootph-pre-ram;
compatible = "ti,am654-secure-proxy";
#mbox-cells = <1>;
reg-names = "target_data", "rt", "scfg";
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/4] arm64: dts: ti: k3-j784s4-mcu-wakeup: Add bootph-pre-ram property for SPL nodes
2023-08-07 18:56 [PATCH v2 0/4] arm64: dts: ti: k3-j784s4: Add bootph-pre-ram property for SPL nodes Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: " Apurva Nandan
@ 2023-08-07 18:56 ` Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 3/4] arm64: dts: ti: k3-j784s4-evm: " Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 4/4] arm64: dts: ti: k3-am69-sk: " Apurva Nandan
3 siblings, 0 replies; 7+ messages in thread
From: Apurva Nandan @ 2023-08-07 18:56 UTC (permalink / raw)
To: Apurva Nandan, Nishanth Menon, Vignesh Raghavendra, Tero Kristo,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Udit Kumar, Hari Nagalla,
Dasnavis Sabiya
Add bootph-pre-ram property for all the nodes used in SPL stage,
for syncing it later to u-boot j784s4 dts.
Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
index 657fb1d72512..521d3cfd10c4 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
@@ -6,7 +6,9 @@
*/
&cbass_mcu_wakeup {
+ bootph-pre-ram;
sms: system-controller@44083000 {
+ bootph-pre-ram;
compatible = "ti,k2g-sci";
ti,host-id = <12>;
@@ -19,22 +21,26 @@ sms: system-controller@44083000 {
reg = <0x00 0x44083000 0x00 0x1000>;
k3_pds: power-controller {
+ bootph-pre-ram;
compatible = "ti,sci-pm-domain";
#power-domain-cells = <2>;
};
k3_clks: clock-controller {
+ bootph-pre-ram;
compatible = "ti,k2g-sci-clk";
#clock-cells = <2>;
};
k3_reset: reset-controller {
+ bootph-pre-ram;
compatible = "ti,sci-reset";
#reset-cells = <2>;
};
};
chipid@43000014 {
+ bootph-pre-ram;
compatible = "ti,am654-chipid";
reg = <0x00 0x43000014 0x00 0x4>;
};
@@ -161,6 +167,7 @@ mcu_timer0: timer@40400000 {
};
mcu_timer1: timer@40410000 {
+ bootph-pre-ram;
compatible = "ti,am654-timer";
reg = <0x00 0x40410000 0x00 0x400>;
interrupts = <GIC_SPI 817 IRQ_TYPE_LEVEL_HIGH>;
@@ -442,6 +449,7 @@ mcu_spi2: spi@40320000 {
};
mcu_navss: bus@28380000{
+ bootph-pre-ram;
compatible = "simple-bus";
#address-cells = <2>;
#size-cells = <2>;
@@ -451,6 +459,7 @@ mcu_navss: bus@28380000{
dma-ranges;
mcu_ringacc: ringacc@2b800000 {
+ bootph-pre-ram;
compatible = "ti,am654-navss-ringacc";
reg = <0x00 0x2b800000 0x00 0x400000>,
<0x00 0x2b000000 0x00 0x400000>,
@@ -465,6 +474,7 @@ mcu_ringacc: ringacc@2b800000 {
};
mcu_udmap: dma-controller@285c0000 {
+ bootph-pre-ram;
compatible = "ti,j721e-navss-mcu-udmap";
reg = <0x00 0x285c0000 0x00 0x100>,
<0x00 0x2a800000 0x00 0x40000>,
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 3/4] arm64: dts: ti: k3-j784s4-evm: Add bootph-pre-ram property for SPL nodes
2023-08-07 18:56 [PATCH v2 0/4] arm64: dts: ti: k3-j784s4: Add bootph-pre-ram property for SPL nodes Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: " Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 2/4] arm64: dts: ti: k3-j784s4-mcu-wakeup: " Apurva Nandan
@ 2023-08-07 18:56 ` Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 4/4] arm64: dts: ti: k3-am69-sk: " Apurva Nandan
3 siblings, 0 replies; 7+ messages in thread
From: Apurva Nandan @ 2023-08-07 18:56 UTC (permalink / raw)
To: Apurva Nandan, Nishanth Menon, Vignesh Raghavendra, Tero Kristo,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Udit Kumar, Hari Nagalla,
Dasnavis Sabiya
Add bootph-pre-ram property for all the nodes used in SPL stage,
for syncing it later to u-boot j784s4 dts.
Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 25 ++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index cb852031c802..35933551e6be 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -252,7 +252,9 @@ vdd_sd_dv: regulator-TLV71033 {
};
&main_pmx0 {
+ bootph-pre-ram;
main_uart8_pins_default: main-uart8-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_IOPAD(0x040, PIN_INPUT, 14) /* (AF37) MCASP0_AXR0.UART8_CTSn */
J784S4_IOPAD(0x044, PIN_OUTPUT, 14) /* (AG37) MCASP0_AXR1.UART8_RTSn */
@@ -269,6 +271,7 @@ J784S4_IOPAD(0x0e4, PIN_INPUT_PULLUP, 0) /* (AP37) I2C0_SDA */
};
main_mmc1_pins_default: main-mmc1-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_IOPAD(0x104, PIN_INPUT, 0) /* (AB38) MMC1_CLK */
J784S4_IOPAD(0x108, PIN_INPUT, 0) /* (AB36) MMC1_CMD */
@@ -289,7 +292,9 @@ J784S4_IOPAD(0x020, PIN_INPUT, 7) /* (AJ35) MCAN15_RX.GPIO0_8 */
};
&wkup_pmx2 {
+ bootph-pre-ram;
wkup_uart0_pins_default: wkup-uart0-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J721S2_WKUP_IOPAD(0x070, PIN_INPUT, 0) /* (L37) WKUP_GPIO0_6.WKUP_UART0_CTSn */
J721S2_WKUP_IOPAD(0x074, PIN_INPUT, 0) /* (L36) WKUP_GPIO0_7.WKUP_UART0_RTSn */
@@ -299,6 +304,7 @@ J721S2_WKUP_IOPAD(0x04c, PIN_INPUT, 0) /* (K34) WKUP_UART0_TXD */
};
wkup_i2c0_pins_default: wkup-i2c0-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J721S2_WKUP_IOPAD(0x98, PIN_INPUT, 0) /* (N33) WKUP_I2C0_SCL */
J721S2_WKUP_IOPAD(0x9c, PIN_INPUT, 0) /* (N35) WKUP_I2C0_SDA */
@@ -306,6 +312,7 @@ J721S2_WKUP_IOPAD(0x9c, PIN_INPUT, 0) /* (N35) WKUP_I2C0_SDA */
};
mcu_uart0_pins_default: mcu-uart0-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_WKUP_IOPAD(0x090, PIN_INPUT, 0) /* (H37) WKUP_GPIO0_14.MCU_UART0_CTSn */
J784S4_WKUP_IOPAD(0x094, PIN_OUTPUT, 0) /* (K37) WKUP_GPIO0_15.MCU_UART0_RTSn */
@@ -366,7 +373,9 @@ J784S4_WKUP_IOPAD(0x170, PIN_INPUT, 0) /* (Y36) MCU_ADC1_AIN7 */
};
&wkup_pmx0 {
+ bootph-pre-ram;
mcu_fss0_ospi0_pins_default: mcu-fss0-ospi0-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_WKUP_IOPAD(0x000, PIN_OUTPUT, 0) /* (E32) MCU_OSPI0_CLK */
J784S4_WKUP_IOPAD(0x02c, PIN_OUTPUT, 0) /* (A32) MCU_OSPI0_CSn0 */
@@ -384,7 +393,9 @@ J784S4_WKUP_IOPAD(0x008, PIN_INPUT, 0) /* (C34) MCU_OSPI0_DQS */
};
&wkup_pmx1 {
+ bootph-pre-ram;
mcu_fss0_ospi0_1_pins_default: mcu-fss0-ospi0-1-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_WKUP_IOPAD(0x004, PIN_OUTPUT, 6) /* (C32) MCU_OSPI0_ECC_FAIL */
J784S4_WKUP_IOPAD(0x000, PIN_OUTPUT, 6) /* (B34) MCU_OSPI0_RESET_OUT0 */
@@ -392,6 +403,7 @@ J784S4_WKUP_IOPAD(0x000, PIN_OUTPUT, 6) /* (B34) MCU_OSPI0_RESET_OUT0 */
};
mcu_fss0_ospi1_pins_default: mcu-fss0-ospi1-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_WKUP_IOPAD(0x008, PIN_OUTPUT, 0) /* (F32) MCU_OSPI1_CLK */
J784S4_WKUP_IOPAD(0x024, PIN_OUTPUT, 0) /* (G32) MCU_OSPI1_CSn0 */
@@ -406,6 +418,7 @@ J784S4_WKUP_IOPAD(0x00C, PIN_INPUT, 0) /* (C31) MCU_OSPI1_LBCLKO */
};
&wkup_uart0 {
+ bootph-pre-ram;
/* Firmware usage */
status = "reserved";
pinctrl-names = "default";
@@ -413,6 +426,7 @@ &wkup_uart0 {
};
&wkup_i2c0 {
+ bootph-pre-ram;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&wkup_i2c0_pins_default>;
@@ -426,27 +440,32 @@ eeprom@50 {
};
&mcu_uart0 {
+ bootph-pre-ram;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&mcu_uart0_pins_default>;
};
&main_uart8 {
+ bootph-pre-ram;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_uart8_pins_default>;
};
&fss {
+ bootph-pre-ram;
status = "okay";
};
&ospi0 {
+ bootph-pre-ram;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&mcu_fss0_ospi0_pins_default>, <&mcu_fss0_ospi0_1_pins_default>;
flash@0 {
+ bootph-pre-ram;
compatible = "jedec,spi-nor";
reg = <0x0>;
spi-tx-bus-width = <8>;
@@ -494,6 +513,7 @@ partition@800000 {
};
partition@3fc0000 {
+ bootph-pre-ram;
label = "ospi.phypattern";
reg = <0x3fc0000 0x40000>;
};
@@ -502,11 +522,13 @@ partition@3fc0000 {
};
&ospi1 {
+ bootph-pre-ram;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&mcu_fss0_ospi1_pins_default>;
flash@0{
+ bootph-pre-ram;
compatible = "jedec,spi-nor";
reg = <0x0>;
spi-tx-bus-width = <1>;
@@ -554,6 +576,7 @@ partition@800000 {
};
partition@3fc0000 {
+ bootph-pre-ram;
label = "qspi.phypattern";
reg = <0x3fc0000 0x40000>;
};
@@ -598,6 +621,7 @@ exp2: gpio@22 {
};
&main_sdhci0 {
+ bootph-pre-ram;
/* eMMC */
status = "okay";
non-removable;
@@ -606,6 +630,7 @@ &main_sdhci0 {
};
&main_sdhci1 {
+ bootph-pre-ram;
/* SD card */
status = "okay";
pinctrl-0 = <&main_mmc1_pins_default>;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 4/4] arm64: dts: ti: k3-am69-sk: Add bootph-pre-ram property for SPL nodes
2023-08-07 18:56 [PATCH v2 0/4] arm64: dts: ti: k3-j784s4: Add bootph-pre-ram property for SPL nodes Apurva Nandan
` (2 preceding siblings ...)
2023-08-07 18:56 ` [PATCH v2 3/4] arm64: dts: ti: k3-j784s4-evm: " Apurva Nandan
@ 2023-08-07 18:56 ` Apurva Nandan
3 siblings, 0 replies; 7+ messages in thread
From: Apurva Nandan @ 2023-08-07 18:56 UTC (permalink / raw)
To: Apurva Nandan, Nishanth Menon, Vignesh Raghavendra, Tero Kristo,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Udit Kumar, Hari Nagalla,
Dasnavis Sabiya
Add bootph-pre-ram property for all the nodes used in SPL stage,
for syncing it later to u-boot k3-am69 dts.
Signed-off-by: Apurva Nandan <a-nandan@ti.com>
---
arch/arm64/boot/dts/ti/k3-am69-sk.dts | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
index d282c2c633c1..cbe88a26b283 100644
--- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
@@ -110,7 +110,9 @@ vdd_sd_dv: regulator-tlv71033 {
};
&main_pmx0 {
+ bootph-pre-ram;
main_uart8_pins_default: main-uart8-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_IOPAD(0x0d0, PIN_INPUT, 11) /* (AP38) SPI0_CS1.UART8_RXD */
J784S4_IOPAD(0x0d4, PIN_OUTPUT, 11) /* (AN38) SPI0_CLK.UART8_TXD */
@@ -125,6 +127,7 @@ J784S4_IOPAD(0x0e4, PIN_INPUT_PULLUP, 0) /* (AP37) I2C0_SDA */
};
main_mmc1_pins_default: main-mmc1-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_IOPAD(0x104, PIN_INPUT, 0) /* (AB38) MMC1_CLK */
J784S4_IOPAD(0x108, PIN_INPUT, 0) /* (AB36) MMC1_CMD */
@@ -164,7 +167,9 @@ J784S4_IOPAD(0x004, PIN_INPUT, 7) /* (AG36) MCAN12_TX.GPIO0_1 */
};
&wkup_pmx2 {
+ bootph-pre-ram;
wkup_uart0_pins_default: wkup-uart0-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J721S2_WKUP_IOPAD(0x070, PIN_INPUT, 0) /* (L37) WKUP_GPIO0_6.WKUP_UART0_CTSn */
J721S2_WKUP_IOPAD(0x074, PIN_INPUT, 0) /* (L36) WKUP_GPIO0_7.WKUP_UART0_RTSn */
@@ -174,6 +179,7 @@ J721S2_WKUP_IOPAD(0x04c, PIN_INPUT, 0) /* (K34) WKUP_UART0_TXD */
};
wkup_i2c0_pins_default: wkup-i2c0-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J721S2_WKUP_IOPAD(0x98, PIN_INPUT, 0) /* (N33) WKUP_I2C0_SCL */
J721S2_WKUP_IOPAD(0x9c, PIN_INPUT, 0) /* (N35) WKUP_I2C0_SDA */
@@ -181,6 +187,7 @@ J721S2_WKUP_IOPAD(0x9c, PIN_INPUT, 0) /* (N35) WKUP_I2C0_SDA */
};
mcu_uart0_pins_default: mcu-uart0-default-pins {
+ bootph-pre-ram;
pinctrl-single,pins = <
J784S4_WKUP_IOPAD(0x08c, PIN_INPUT, 0) /* (K38) WKUP_GPIO0_13.MCU_UART0_RXD */
J784S4_WKUP_IOPAD(0x088, PIN_OUTPUT, 0) /* (J37) WKUP_GPIO0_12.MCU_UART0_TXD */
@@ -242,6 +249,7 @@ J784S4_WKUP_IOPAD(0x0, PIN_INPUT, 7) /* (M33) WKUP_GPIO0_49 */
};
&wkup_uart0 {
+ bootph-pre-ram;
/* Firmware usage */
status = "reserved";
pinctrl-names = "default";
@@ -249,6 +257,7 @@ &wkup_uart0 {
};
&wkup_i2c0 {
+ bootph-pre-ram;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&wkup_i2c0_pins_default>;
@@ -268,6 +277,7 @@ &wkup_gpio0 {
};
&mcu_uart0 {
+ bootph-pre-ram;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&mcu_uart0_pins_default>;
@@ -281,6 +291,7 @@ &mcu_i2c0 {
};
&main_uart8 {
+ bootph-pre-ram;
status = "okay";
pinctrl-names = "default";
pinctrl-0 = <&main_uart8_pins_default>;
@@ -307,6 +318,7 @@ exp1: gpio@21 {
};
&main_sdhci0 {
+ bootph-pre-ram;
/* eMMC */
status = "okay";
non-removable;
@@ -315,6 +327,7 @@ &main_sdhci0 {
};
&main_sdhci1 {
+ bootph-pre-ram;
/* SD card */
status = "okay";
pinctrl-0 = <&main_mmc1_pins_default>;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: Add bootph-pre-ram property for SPL nodes
2023-08-07 18:56 ` [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: " Apurva Nandan
@ 2023-08-07 19:07 ` Nishanth Menon
2023-08-08 18:32 ` Apurva Nandan
0 siblings, 1 reply; 7+ messages in thread
From: Nishanth Menon @ 2023-08-07 19:07 UTC (permalink / raw)
To: Apurva Nandan
Cc: Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
linux-kernel, Udit Kumar, Hari Nagalla, Dasnavis Sabiya, Tom Rini
On 00:26-20230808, Apurva Nandan wrote:
> Add bootph-pre-ram property for all the nodes used in SPL stage,
> for syncing it later to u-boot j784s4 dts.
>
> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
> ---
We need to rework this a little more:
The approach taken in this series is enable pre-ram for everything. I am
not sure that is the right direction.
https://github.com/devicetree-org/dt-schema/blob/e87ba2f515392c2a4694642063efb43023331ff6/dtschema/schemas/bootph.yaml#L70
patch #1: board generic changes: patch #1
patch #2-: board specific change (per board)
Make sure you use the correct property and document why this is needed
in the section added as well - esp for board generic changes introduced
into SoC.dtsi files.
> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index 2ea0adae6832..aaec569fe91a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -6,6 +6,7 @@
> */
>
> &cbass_main {
> + bootph-pre-ram;
Is this better done where the node is defined?
> msmc_ram: sram@70000000 {
> compatible = "mmio-sram";
> reg = <0x00 0x70000000 0x00 0x800000>;
> @@ -670,6 +671,7 @@ main_sdhci1: mmc@4fb0000 {
> };
>
> main_navss: bus@30000000 {
> + bootph-pre-ram;
> compatible = "simple-bus";
> #address-cells = <2>;
> #size-cells = <2>;
> @@ -705,6 +707,7 @@ main_udmass_inta: msi-controller@33d00000 {
> };
>
> secure_proxy_main: mailbox@32c00000 {
> + bootph-pre-ram;
> compatible = "ti,am654-secure-proxy";
> #mbox-cells = <1>;
> reg-names = "target_data", "rt", "scfg";
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: Add bootph-pre-ram property for SPL nodes
2023-08-07 19:07 ` Nishanth Menon
@ 2023-08-08 18:32 ` Apurva Nandan
0 siblings, 0 replies; 7+ messages in thread
From: Apurva Nandan @ 2023-08-08 18:32 UTC (permalink / raw)
To: Nishanth Menon
Cc: Vignesh Raghavendra, Tero Kristo, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel, devicetree,
linux-kernel, Udit Kumar, Hari Nagalla, Dasnavis Sabiya, Tom Rini
Hi Nishanth,
On 08/08/23 00:37, Nishanth Menon wrote:
> On 00:26-20230808, Apurva Nandan wrote:
>> Add bootph-pre-ram property for all the nodes used in SPL stage,
>> for syncing it later to u-boot j784s4 dts.
>>
>> Signed-off-by: Apurva Nandan <a-nandan@ti.com>
>> ---
> We need to rework this a little more:
>
> The approach taken in this series is enable pre-ram for everything. I am
> not sure that is the right direction.
These patches only enable bootph-pre-ram for the nodes, that already had
bootph-pre-ram property in u-boot dts
patches for j784s4. And these are selected after removing unnecessary
nodes that had this property, so not added for
everything. Are there a nodes which seem to have unnecessary
bootph-pre-ram property according to you, need to remove?
> https://github.com/devicetree-org/dt-schema/blob/e87ba2f515392c2a4694642063efb43023331ff6/dtschema/schemas/bootph.yaml#L70
>
> patch #1: board generic changes: patch #1
> patch #2-: board specific change (per board)
>
> Make sure you use the correct property and document why this is needed
> in the section added as well - esp for board generic changes introduced
> into SoC.dtsi files.
>
I am little unclear about what nodes you refer with board generic vs
board specific bootph-pre-ram.
I have currently added bootph-pre-ram in board EVM dts files if the node
is disabled in SoC dtsi and enabled
in EVM dts (no point adding bootph-pre-ram in disabled node), or for
pinmuxes, etc. What is the segregation
you want in the patch, do you want some bootph-pre-ram to be moved from
where they are?
>> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> index 2ea0adae6832..aaec569fe91a 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
>> @@ -6,6 +6,7 @@
>> */
>>
>> &cbass_main {
>> + bootph-pre-ram;
> Is this better done where the node is defined?
Okay, this I will fix.
>
>> msmc_ram: sram@70000000 {
>> compatible = "mmio-sram";
>> reg = <0x00 0x70000000 0x00 0x800000>;
>> @@ -670,6 +671,7 @@ main_sdhci1: mmc@4fb0000 {
>> };
>>
>> main_navss: bus@30000000 {
>> + bootph-pre-ram;
>> compatible = "simple-bus";
>> #address-cells = <2>;
>> #size-cells = <2>;
>> @@ -705,6 +707,7 @@ main_udmass_inta: msi-controller@33d00000 {
>> };
>>
>> secure_proxy_main: mailbox@32c00000 {
>> + bootph-pre-ram;
>> compatible = "ti,am654-secure-proxy";
>> #mbox-cells = <1>;
>> reg-names = "target_data", "rt", "scfg";
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-08 20:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07 18:56 [PATCH v2 0/4] arm64: dts: ti: k3-j784s4: Add bootph-pre-ram property for SPL nodes Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 1/4] arm64: dts: ti: k3-j784s4-main: " Apurva Nandan
2023-08-07 19:07 ` Nishanth Menon
2023-08-08 18:32 ` Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 2/4] arm64: dts: ti: k3-j784s4-mcu-wakeup: " Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 3/4] arm64: dts: ti: k3-j784s4-evm: " Apurva Nandan
2023-08-07 18:56 ` [PATCH v2 4/4] arm64: dts: ti: k3-am69-sk: " Apurva Nandan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).