From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6542C04A94 for ; Tue, 8 Aug 2023 17:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233409AbjHHR51 (ORCPT ); Tue, 8 Aug 2023 13:57:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235203AbjHHR5C (ORCPT ); Tue, 8 Aug 2023 13:57:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8102CAD1A; Tue, 8 Aug 2023 09:25:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E4F1623EB; Tue, 8 Aug 2023 04:36:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03487C433C7; Tue, 8 Aug 2023 04:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1691469369; bh=IMgWwZ4rdhaoLfJ9wmfKo2+cng5qpJxVkmNuR2ToNbo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kUgys+Xtx3ItPxfY68wwjolIAgO72NEQe5mB342f1M7WPec873Dz3SkSCdrTMW5Hb MPBPYP7vT0yTHLn0VvtFPOts++DefKyFeZboOtwQG/pP4VK3t95O7NvRHYowDE7TmT 8mBE4GJFdU36umK//qMGo3+liGHlEEk86BIneeEo= Date: Tue, 8 Aug 2023 06:36:06 +0200 From: Greg Kroah-Hartman To: Nishanth Menon Cc: Andrew Davis , Peter Rosin , Rob Herring , Krzysztof Kozlowski , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mux: mmio: use reg property when parent device is not a syscon Message-ID: <2023080854-crummy-armored-420c@gregkh> References: <20230605154153.24025-1-afd@ti.com> <20230807182645.ct2uvkb3s2tuplon@improve> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230807182645.ct2uvkb3s2tuplon@improve> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 07, 2023 at 01:26:45PM -0500, Nishanth Menon wrote: > On 15:12-20230713, Andrew Davis wrote: > > On 6/5/23 10:41 AM, Andrew Davis wrote: > > > The DT binding for the reg-mux compatible states it can be used when the > > > "parent device of mux controller is not syscon device". It also allows > > > for a reg property. When the reg property is provided, use that to > > > identify the address space for this mux. If not provided fallback to > > > using the parent device as a regmap provider. > > > > > > Signed-off-by: Andrew Davis > > > --- > > > > Ping, still needed and applies cleanly on v6.5-rc1. > > > > Andrew > > > > > > > > Changes from v1: > > > - Flip logic as suggested in v1[0] > > > > > > [0] https://lore.kernel.org/lkml/1c27d9d4-b1cc-c158-90f7-f7e47e02c424@ti.com/T/ > > > > > > drivers/mux/mmio.c | 9 ++++++--- > > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > Reviewed-by: Nishanth Menon > > Greg: looks like you were missed in CC > > Peter/Greg: Any chance of Looking at this? This is a basic corner stone > for us to clean up much of the mess we have created up in the device > tree syscon nodes and trying to transition those into simple-bus. > > > > > > > diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c > > > index 44a7a0e885b8d..2c9e4df9d6f2c 100644 > > > --- a/drivers/mux/mmio.c > > > +++ b/drivers/mux/mmio.c > > > @@ -44,10 +44,13 @@ static int mux_mmio_probe(struct platform_device *pdev) > > > int ret; > > > int i; > > > - if (of_device_is_compatible(np, "mmio-mux")) > > > + if (of_device_is_compatible(np, "mmio-mux")) { > > > regmap = syscon_node_to_regmap(np->parent); > > > - else > > > - regmap = dev_get_regmap(dev->parent, NULL) ?: ERR_PTR(-ENODEV); > > > + } else { > > > + regmap = device_node_to_regmap(np); > > > + if (IS_ERR(regmap)) > > > + regmap = dev_get_regmap(dev->parent, NULL) ?: ERR_PTR(-ENODEV); > > > + } > > > if (IS_ERR(regmap)) { > > > ret = PTR_ERR(regmap); > > > dev_err(dev, "failed to get regmap: %d\n", ret); I'm not the maintainer here, it's up to Peter.