From: Conor Dooley <conor@kernel.org>
To: Hari Nagalla <hnagalla@ti.com>
Cc: nm@ti.com, vigneshr@ti.com, kristo@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs
Date: Thu, 10 Aug 2023 17:05:40 +0100 [thread overview]
Message-ID: <20230810-pastor-unneeded-c79bd4b5875e@spud> (raw)
In-Reply-To: <20230810005850.21998-2-hnagalla@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2004 bytes --]
On Wed, Aug 09, 2023 at 07:58:46PM -0500, Hari Nagalla wrote:
> The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
> does not have an addressable l1dram . So, remove this optional sram
> property from the bindings to fix device tree build warnings.
>
> Also set the 'memory-regions' property as optional. This is because
> the remote processors can function without carveout regions.
That seems like an unrelated change that deserves its own commit..
>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> Changes since v1:
> - Corrected dsp node binding doc file to fix yamllint warnings for am62a.
>
> .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index f16e90380df1..8dd22c57e22d 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -111,7 +111,6 @@ else:
> properties:
> compatible:
> enum:
> - - ti,am62a-c7xv-dsp
> - ti,j721e-c71-dsp
> - ti,j721s2-c71-dsp
> then:
> @@ -124,6 +123,20 @@ else:
> items:
> - const: l2sram
> - const: l1dram
> + else:
> + if:
> + properties:
> + compatible:
> + enum:
> + - ti,am62a-c7xv-dsp
> + then:
> + properties:
> + reg:
> + items:
> + - description: Address and Size of the L2 SRAM internal memory region
> + reg-names:
> + items:
> + - const: l2sram
>
> required:
> - compatible
> @@ -135,7 +148,6 @@ required:
> - resets
> - firmware-name
> - mboxes
> - - memory-region
>
> unevaluatedProperties: false
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-10 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 0:58 [PATCH v2 0/5] Add R5F and C7x DSP nodes for AM62a SoC Hari Nagalla
2023-08-10 0:58 ` [PATCH v2 1/5] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs Hari Nagalla
2023-08-10 1:19 ` Rob Herring
2023-08-10 16:05 ` Conor Dooley [this message]
2023-08-10 0:58 ` [PATCH v2 2/5] arm64: dts: k3-am62a-main: Add C7xv device node Hari Nagalla
2023-08-10 0:58 ` [PATCH v2 3/5] arm64: dts: k3-am62a-mcu: Add R5F remote proc node Hari Nagalla
2023-08-10 0:58 ` [PATCH v2 4/5] arm64: dts: k3-am62a-wakeup: Add R5F device node Hari Nagalla
2023-08-10 0:58 ` [PATCH v2 5/5] arm64: dts: ti: k3-am62a7-sk: Enable ipc with remote proc nodes Hari Nagalla
2023-08-10 1:12 ` [PATCH v2 0/5] Add R5F and C7x DSP nodes for AM62a SoC Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810-pastor-unneeded-c79bd4b5875e@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).