[PATCH 0/6] imx6q related DT binding fixes

[PATCH 0/6] imx6q related DT binding fixes

[Alexander Stein]

Hi everyone,

while working on i.MX6Q based board (arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dts)
I noticed several warnings on dtbs_check. The first 5 patches should be pretty
much straight forward.
I'm not 100% sure on the sixth patch, as it might be affected by incorrect
compatible lists. Please refer to the note in that patch.
I'm also no sure whether thse patches warrent a Fixes tag, so I only added that
for patch 3. All of these patches are independent and can be picked up
individually.

Best regards,
Alexander

Alexander Stein (6):
  dt-bindings: trivial-devices: Remove national,lm75
  dt-bindings: imx-thermal: Add #thermal-sensor-cells property
  dt-bindings: display: imx: hdmi: Allow 'reg' and 'interrupts'
  dt-bindings: net: microchip: Allow nvmem-cell usage
  dt-bindings: timer: add imx7d compatible
  dt-bindings: timer: fsl,imxgpt: Add optional osc_per clock

 .../bindings/display/imx/fsl,imx6-hdmi.yaml   |  3 ++
 .../bindings/net/microchip,lan95xx.yaml       |  2 ++
 .../bindings/thermal/imx-thermal.yaml         |  6 ++++
 .../devicetree/bindings/timer/fsl,imxgpt.yaml | 31 ++++++++++++++++++-
 .../devicetree/bindings/trivial-devices.yaml  |  2 --
 5 files changed, 41 insertions(+), 3 deletions(-)

-- 
2.34.1

[PATCH 1/6] dt-bindings: trivial-devices: Remove national,lm75

[Alexander Stein]

Starting with commit 3e37c9d48f7a ("dt-bindings: hwmon: Convert lm75
bindings to yaml") 'national,lm75' has it's own dedicated (YAML) binding.
If kept in this file device specific properties as 'vs-supply' are
considered excessive. Remove compatible here so it can be checked with
more specific binding.
arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: sensor@48: 'vs-supply' does not
match any of the regexes: 'pinctrl-[0-9]+'
  From schema: Documentation/devicetree/bindings/trivial-devices.yaml

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 40bc475ee7e1..e30335d4e504 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -295,8 +295,6 @@ properties:
           - miramems,da311
             # Temperature sensor with integrated fan control
           - national,lm63
-            # I2C TEMP SENSOR
-          - national,lm75
             # Serial Interface ACPI-Compatible Microprocessor System Hardware Monitor
           - national,lm80
             # Serial Interface ACPI-Compatible Microprocessor System Hardware Monitor
-- 
2.34.1

Re: [PATCH 1/6] dt-bindings: trivial-devices: Remove national,lm75

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

On Thu, Aug 10, 2023 at 04:44:46PM +0200, Alexander Stein wrote:
> Starting with commit 3e37c9d48f7a ("dt-bindings: hwmon: Convert lm75
> bindings to yaml") 'national,lm75' has it's own dedicated (YAML) binding.
> If kept in this file device specific properties as 'vs-supply' are
> considered excessive. Remove compatible here so it can be checked with
> more specific binding.
> arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: sensor@48: 'vs-supply' does not
> match any of the regexes: 'pinctrl-[0-9]+'
>   From schema: Documentation/devicetree/bindings/trivial-devices.yaml
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 40bc475ee7e1..e30335d4e504 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -295,8 +295,6 @@ properties:
>            - miramems,da311
>              # Temperature sensor with integrated fan control
>            - national,lm63
> -            # I2C TEMP SENSOR
> -          - national,lm75
>              # Serial Interface ACPI-Compatible Microprocessor System Hardware Monitor
>            - national,lm80
>              # Serial Interface ACPI-Compatible Microprocessor System Hardware Monitor
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/6] dt-bindings: trivial-devices: Remove national,lm75

[Rob Herring]

On Thu, 10 Aug 2023 16:44:46 +0200, Alexander Stein wrote:
> Starting with commit 3e37c9d48f7a ("dt-bindings: hwmon: Convert lm75
> bindings to yaml") 'national,lm75' has it's own dedicated (YAML) binding.
> If kept in this file device specific properties as 'vs-supply' are
> considered excessive. Remove compatible here so it can be checked with
> more specific binding.
> arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: sensor@48: 'vs-supply' does not
> match any of the regexes: 'pinctrl-[0-9]+'
>   From schema: Documentation/devicetree/bindings/trivial-devices.yaml
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 

Applied, thanks!

[PATCH 2/6] dt-bindings: imx-thermal: Add #thermal-sensor-cells property

[Alexander Stein]

This property is defined in thermal-sensor.yaml. Reference this file and
constraint '#thermal-sensor-cells' to 0 for imx-thermal.
Fixes the warning:
arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: tempmon:
 '#thermal-sensor-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
 From schema: Documentation/devicetree/bindings/thermal/imx-thermal.yaml

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/thermal/imx-thermal.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/imx-thermal.yaml b/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
index 3aecea77869f..a746f6a6395a 100644
--- a/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/imx-thermal.yaml
@@ -60,6 +60,9 @@ properties:
   clocks:
     maxItems: 1
 
+  "#thermal-sensor-cells":
+    const: 0
+
 required:
   - compatible
   - interrupts
@@ -67,6 +70,9 @@ required:
   - nvmem-cells
   - nvmem-cell-names
 
+allOf:
+  - $ref: thermal-sensor.yaml#
+
 additionalProperties: false
 
 examples:
-- 
2.34.1

Re: [PATCH 2/6] dt-bindings: imx-thermal: Add #thermal-sensor-cells property

[Rob Herring]

On Thu, 10 Aug 2023 16:44:47 +0200, Alexander Stein wrote:
> This property is defined in thermal-sensor.yaml. Reference this file and
> constraint '#thermal-sensor-cells' to 0 for imx-thermal.
> Fixes the warning:
> arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: tempmon:
>  '#thermal-sensor-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
>  From schema: Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/thermal/imx-thermal.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/imx-thermal.example.dtb: tempmon: '#thermal-sensor-cells' is a required property
	from schema $id: http://devicetree.org/schemas/thermal/imx-thermal.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810144451.1459985-3-alexander.stein@ew.tq-group.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

[PATCH 3/6] dt-bindings: display: imx: hdmi: Allow 'reg' and 'interrupts'

[Alexander Stein]

Although defined in synopsys,dw-hdmi.yaml, they need to explicitly allowed
in fsl,imx6-hdmi.yaml. Fixes the warning:
arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: hdmi@120000: 'interrupts',
 'reg' do not match any of the regexes: 'pinctrl-[0-9]+'
 From schema: Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml

Fixes: b935c3a2e07b ("dt-bindings: display: imx: hdmi: Convert binding to YAML")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml         | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
index af7fe9c4d196..d6af28e86ab4 100644
--- a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
+++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
@@ -22,6 +22,9 @@ properties:
       - fsl,imx6dl-hdmi
       - fsl,imx6q-hdmi
 
+  reg: true
+  interrupts: true
+
   reg-io-width:
     const: 1
 
-- 
2.34.1

Re: [PATCH 3/6] dt-bindings: display: imx: hdmi: Allow 'reg' and 'interrupts'

[Rob Herring]

On Thu, Aug 10, 2023 at 04:44:48PM +0200, Alexander Stein wrote:
> Although defined in synopsys,dw-hdmi.yaml, they need to explicitly allowed
> in fsl,imx6-hdmi.yaml. Fixes the warning:
> arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: hdmi@120000: 'interrupts',
>  'reg' do not match any of the regexes: 'pinctrl-[0-9]+'
>  From schema: Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> 
> Fixes: b935c3a2e07b ("dt-bindings: display: imx: hdmi: Convert binding to YAML")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml         | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> index af7fe9c4d196..d6af28e86ab4 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> @@ -22,6 +22,9 @@ properties:
>        - fsl,imx6dl-hdmi
>        - fsl,imx6q-hdmi
>  
> +  reg: true
> +  interrupts: true
> +

You should change additionalProperties to unevaluatedProperties instead.

Rob

[PATCH 4/6] dt-bindings: net: microchip: Allow nvmem-cell usage

[Alexander Stein]

MAC address can be provided by a nvmem-cell, thus allow referencing a
source for the address. Fixes the warning:
arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names',
 'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
 From schema: Documentation/devicetree/bindings/net/microchip,lan95xx.yaml

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
index 0b97e14d947f..247e7707181c 100644
--- a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
+++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
@@ -44,6 +44,8 @@ properties:
 
   local-mac-address: true
   mac-address: true
+  nvmem-cells: true
+  nvmem-cell-names: true
 
 required:
   - compatible
-- 
2.34.1

Re: [PATCH 4/6] dt-bindings: net: microchip: Allow nvmem-cell usage

[Rob Herring]

On Thu, 10 Aug 2023 16:44:49 +0200, Alexander Stein wrote:
> MAC address can be provided by a nvmem-cell, thus allow referencing a
> source for the address. Fixes the warning:
> arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names',
>  'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
>  From schema: Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 4/6] dt-bindings: net: microchip: Allow nvmem-cell usage

[Alexander Stein]

Am Montag, 21. August 2023, 19:14:39 CEST schrieb Rob Herring:
> On Thu, 10 Aug 2023 16:44:49 +0200, Alexander Stein wrote:
> > MAC address can be provided by a nvmem-cell, thus allow referencing a
> > source for the address. Fixes the warning:
> > arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: ethernet@1: 'nvmem-cell-names',
> > 
> >  'nvmem-cells' do not match any of the regexes: 'pinctrl-[0-9]+'
> >  From schema: Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > 
> >  Documentation/devicetree/bindings/net/microchip,lan95xx.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks. But while reading your comment on patch 3, I'm wondering if 
additionalProperties should be changed to unevaluatedProperties here as well.
This way local-mac-address and mac-address canbe removed as well, they are 
defined in ethernet-controller.yaml already.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

[PATCH 5/6] dt-bindings: timer: add imx7d compatible

[Alexander Stein]

Currently the dtbs_check for imx6ul generates warnings like this:

['fsl,imx7d-gpt', 'fsl,imx6sx-gpt'] is too long

The driver has no special handling for fsl,imx7d-gpt, so fsl,imx6sx-gpt is
used. Therefore make imx7d GPT compatible to the imx6sx one to fix the
warning.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
index dbe1267af06a..c5d3be8c1d68 100644
--- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
+++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
@@ -36,7 +36,9 @@ properties:
               - fsl,imxrt1170-gpt
           - const: fsl,imx6dl-gpt
       - items:
-          - const: fsl,imx6ul-gpt
+          - enum:
+              - fsl,imx6ul-gpt
+              - fsl,imx7d-gpt
           - const: fsl,imx6sx-gpt
 
   reg:
-- 
2.34.1

Re: [PATCH 5/6] dt-bindings: timer: add imx7d compatible

[Rob Herring]

On Thu, 10 Aug 2023 16:44:50 +0200, Alexander Stein wrote:
> Currently the dtbs_check for imx6ul generates warnings like this:
> 
> ['fsl,imx7d-gpt', 'fsl,imx6sx-gpt'] is too long
> 
> The driver has no special handling for fsl,imx7d-gpt, so fsl,imx6sx-gpt is
> used. Therefore make imx7d GPT compatible to the imx6sx one to fix the
> warning.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

[PATCH 6/6] dt-bindings: timer: fsl,imxgpt: Add optional osc_per clock

[Alexander Stein]

Since commit bad3db104f89 ("ARM: imx: source gpt per clk from OSC for
system timer") osc_per can be used for clocking the GPT which is not
scaled when entering low bus mode.
This clock source is available only on i.MX6Q (incl. i.MX6QP) and i.MX6DL.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---

Notes:
    osc_per is only used in arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi, so I assume
    this is the only platform supporting this source.
    
    I had to use minItem:2 and maxItems:3 in the constraints as fsl,imx6sx-gpt
    and fsl,imx6sl-gpt are also compatible to fsl,imx6dl-gpt, but only provide
    two clocks. Maybe this the compatible list needs some cleanup, but I do
    not know which hardware is compatible to what. The driver
    drivers/clocksource/timer-imx-gpt.c also gives no clues because it's totally
    mixed.

 .../devicetree/bindings/timer/fsl,imxgpt.yaml | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
index c5d3be8c1d68..e2607377cbae 100644
--- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
+++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
@@ -48,14 +48,18 @@ properties:
     maxItems: 1
 
   clocks:
+    minItems: 2
     items:
       - description: SoC GPT ipg clock
       - description: SoC GPT per clock
+      - description: SoC GPT osc per clock
 
   clock-names:
+    minItems: 2
     items:
       - const: ipg
       - const: per
+      - const: osc_per
 
 required:
   - compatible
@@ -64,6 +68,29 @@ required:
   - clocks
   - clock-names
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx6dl-gpt
+              - fsl,imx6q-gpt
+    then:
+      properties:
+        clocks:
+          minItems: 2
+          maxItems: 3
+        clock-names:
+          minItems: 2
+          maxItems: 3
+    else:
+      properties:
+        clocks:
+          maxItems: 2
+        clock-names:
+          maxItems: 2
+
 additionalProperties: false
 
 examples:
-- 
2.34.1

Re: [PATCH 0/6] imx6q related DT binding fixes

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

On Thu, Aug 10, 2023 at 04:44:45PM +0200, Alexander Stein wrote:
> Hi everyone,
> 
> while working on i.MX6Q based board (arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dts)
> I noticed several warnings on dtbs_check. The first 5 patches should be pretty
> much straight forward.
> I'm not 100% sure on the sixth patch, as it might be affected by incorrect
> compatible lists. Please refer to the note in that patch.
> I'm also no sure whether thse patches warrent a Fixes tag, so I only added that
> for patch 3. All of these patches are independent and can be picked up
> individually.

These all seem fine to me, with the last one being really a question for
those with knowledge of the hardware.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 0/6] imx6q related DT binding fixes

[Rob Herring]

On Thu, Aug 10, 2023 at 04:44:45PM +0200, Alexander Stein wrote:
> Hi everyone,
> 
> while working on i.MX6Q based board (arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dts)
> I noticed several warnings on dtbs_check. The first 5 patches should be pretty
> much straight forward.
> I'm not 100% sure on the sixth patch, as it might be affected by incorrect
> compatible lists. Please refer to the note in that patch.
> I'm also no sure whether thse patches warrent a Fixes tag, so I only added that
> for patch 3. All of these patches are independent and can be picked up
> individually.
> 
> Best regards,
> Alexander
> 
> Alexander Stein (6):
>   dt-bindings: trivial-devices: Remove national,lm75
>   dt-bindings: imx-thermal: Add #thermal-sensor-cells property
>   dt-bindings: display: imx: hdmi: Allow 'reg' and 'interrupts'
>   dt-bindings: net: microchip: Allow nvmem-cell usage
>   dt-bindings: timer: add imx7d compatible
>   dt-bindings: timer: fsl,imxgpt: Add optional osc_per clock

I noticed this is the top warning for 32-bit i.MX[1] and found this. 
Looks like 5 and 6 never got applied, so I've applied them.

Rob

[1] https://gitlab.com/robherring/linux-dt/-/jobs/5361483372/artifacts/external_file/platform-warnings.log