From: Nishanth Menon <nm@ti.com>
To: Apurva Nandan <a-nandan@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Udit Kumar <u-kumar1@ti.com>, Hari Nagalla <hnagalla@ti.com>,
Dasnavis Sabiya <sabiya.d@mistralsolutions.com>
Subject: Re: [PATCH v3 0/3] arm64: dts: ti: k3-j784s4: Add bootph-all property
Date: Thu, 10 Aug 2023 13:52:59 -0500 [thread overview]
Message-ID: <20230810185259.fglq6co2wrnbl663@unworldly> (raw)
In-Reply-To: <20230810184302.3097829-1-a-nandan@ti.com>
On 00:12-20230811, Apurva Nandan wrote:
> bootph-all phase tag was added to dt-schema (dtschema/schemas/bootph.yaml)
> to overcome u-boot dts challenges.
>
> Add bootph-all property for all the nodes that are used in the SPL stage
> along with later boot stages.
>
> This series will be ported to the u-boot k3-j784s4 support patch series
> for syncing, and was requested in its review process:
> https://lore.kernel.org/u-boot/20230321155227.GV8135@bill-the-cat/
>
> v3: Changelog:
> 1) Changed all the bootph-pre-ram to bootph-all, as only
> secure_proxy_mcu and secure_proxy_sa3 are exclusively used by R5 SPL.
> Rest of the nodes are also used by later boot stages.
> 2) Merged SoC dtsi changes in single patch.
> 3) Moved cbass_main and cbass_mcu_wkup bootph-all to k3-j784s4.dtsi
[...]
> Apurva Nandan (3):
> arm64: dts: ti: k3-j784s4: Add bootph-all property
> arm64: dts: ti: k3-j784s4-evm: Add bootph-all property
> arm64: dts: ti: k3-am69-sk: Add bootph-all property
Follow https://lore.kernel.org/all/48b554aef75d11e6ad2ef7d21f22accb35432112.1683034376.git.michal.simek@amd.com/
for example of proper commit message and subject line.
The patch content actually is easy to read since it is adding
bootph-all property - but we do have a few exceptions. Commit message
should explain the rational of the choices made. For example, you
probably need to use secure_proxy_sa3 to talk with tifs in-order to
boot and that is a pre-ram property and so on..
So, nice refresh in the right direction, but a bit more work to do.
Thanks for handling am69-sk :)..
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2023-08-10 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 18:42 [PATCH v3 0/3] arm64: dts: ti: k3-j784s4: Add bootph-all property Apurva Nandan
2023-08-10 18:43 ` [PATCH v3 1/3] " Apurva Nandan
2023-08-10 18:43 ` [PATCH v3 2/3] arm64: dts: ti: k3-j784s4-evm: " Apurva Nandan
2023-08-10 18:43 ` [PATCH v3 3/3] arm64: dts: ti: k3-am69-sk: " Apurva Nandan
2023-08-10 18:52 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810185259.fglq6co2wrnbl663@unworldly \
--to=nm@ti.com \
--cc=a-nandan@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hnagalla@ti.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sabiya.d@mistralsolutions.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).