From: Rob Herring <robh@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: krzysztof.kozlowski+dt@linaro.org, peng.fan@nxp.com,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, vkoul@kernel.org,
rafal@milecki.pl, quic_srichara@quicinc.com,
konrad.dybcio@linaro.org, devicetree@vger.kernel.org,
andersson@kernel.org, p.zabel@pengutronix.de,
linux-arm-msm@vger.kernel.org, kishon@kernel.org,
agross@kernel.org, conor+dt@kernel.org, will@kernel.org,
catalin.marinas@arm.com, arnd@arndb.de,
linux-kernel@vger.kernel.org, nfraprado@collabora.com,
geert+renesas@glider.be
Subject: Re: [PATCH v7 1/5] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
Date: Thu, 10 Aug 2023 14:51:32 -0600 [thread overview]
Message-ID: <20230810205132.GA1154887-robh@kernel.org> (raw)
In-Reply-To: <169166288301.4166332.13436758125497162213.robh@kernel.org>
On Thu, Aug 10, 2023 at 04:21:23AM -0600, Rob Herring wrote:
>
> On Thu, 10 Aug 2023 15:26:04 +0530, Varadarajan Narayanan wrote:
> > Document the M31 USB2 phy present in IPQ5332.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
> > v7:
> > Move 'compatible' to be the first entry
> > In the example have 'usb-phy' instead of 'usb2-phy'
> > Add 'Reviewed-by: Krzysztof Kozlowski'
> > 'make dt_binding_check DT_SCHEMA_FILES=qcom,ipq5332-usb-hsphy.yaml' passed
> > 'make CHECK_DTBS=y DT_SCHEMA_FILES=qcom,ipq5332-usb-hsphy.yaml dtbs_check' passed
> > v6:
> > Add 'Co-developed-by: Sricharan'
> > Add 'const' to compatible, vdd-supply
> > Remove label and use usb2-phy for nodename in the example
> > v5:
> > Add '#phy-cells', to be able to use generic phy
> > Remove 'Reviewed-by: Krzysztof Kozlowski' due to above change
> > v4:
> > Move M31 URL to description
> > Remove maxItems and relevant content from clock-names
> > Change node name to generic name
> > 'make dt_binding_check DT_SCHEMA_FILES=qcom' passed
> > v3:
> > Incorporate review comments. Will bring in ipq5018 compatible
> > string while posting ipq5018 usb patchset.
> >
> > v1:
> > Rename qcom,m31.yaml -> qcom,ipq5332-usb-hsphy.yaml
> > Drop default binding "m31,usb-hsphy"
> > Add clock
> > Remove 'oneOf' from compatible
> > Remove 'qscratch' region from register space as it is not needed
> > Remove reset-names
> > Fix the example definition
> > ---
> > .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 59 ++++++++++++++++++++++
> > 1 file changed, 59 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/0d42f556ab28123b2b508521a0c79c7597b8b0fd.1691660905.git.quic_varada@quicinc.com
The bot was having an issue. This can be ignored.
Rob
next prev parent reply other threads:[~2023-08-10 20:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 9:56 [PATCH v7 0/5] Enable IPQ5332 USB2 Varadarajan Narayanan
2023-08-10 9:56 ` [PATCH v7 1/5] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy Varadarajan Narayanan
2023-08-10 10:21 ` Rob Herring
2023-08-10 20:51 ` Rob Herring [this message]
2023-08-10 9:56 ` [PATCH v7 2/5] phy: qcom-m31: Introduce qcom,m31 USB phy driver Varadarajan Narayanan
2023-08-10 13:00 ` Konrad Dybcio
2023-08-10 15:19 ` Bjorn Andersson
2023-08-11 8:30 ` Vinod Koul
2023-08-14 8:35 ` Varadarajan Narayanan
2023-08-14 10:04 ` Krzysztof Kozlowski
2023-08-10 9:56 ` [PATCH v7 3/5] arm64: dts: qcom: ipq5332: Add USB related nodes Varadarajan Narayanan
2023-08-14 10:01 ` Krzysztof Kozlowski
2023-08-10 9:56 ` [PATCH v7 4/5] arm64: dts: qcom: ipq5332: Enable USB Varadarajan Narayanan
2023-08-14 10:01 ` Krzysztof Kozlowski
2023-08-10 9:56 ` [PATCH v7 5/5] arm64: defconfig: Enable M31 USB phy driver Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810205132.GA1154887-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafal@milecki.pl \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).