[PATCH] arm64: tegra: Enable IOMMU for host1x on Tegra132

[PATCH] arm64: tegra: Enable IOMMU for host1x on Tegra132

[Rayyan Ansari]

Add the iommu property to the host1x node to register it with its
swgroup.

Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
---
 arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/nvidia/tegra132.dtsi b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
index 8b78be8f4f9d..7e24a212c7e4 100644
--- a/arch/arm64/boot/dts/nvidia/tegra132.dtsi
+++ b/arch/arm64/boot/dts/nvidia/tegra132.dtsi
@@ -93,6 +93,8 @@ host1x@50000000 {
 		resets = <&tegra_car 28>;
 		reset-names = "host1x";
 
+		iommus = <&mc TEGRA_SWGROUP_HC>;
+
 		#address-cells = <2>;
 		#size-cells = <2>;
 
-- 
2.41.0

Re: [PATCH] arm64: tegra: Enable IOMMU for host1x on Tegra132

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

On Thu, Aug 10, 2023 at 10:45:41PM +0100, Rayyan Ansari wrote:
> Add the iommu property to the host1x node to register it with its
> swgroup.
> 
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
> ---
>  arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 ++
>  1 file changed, 2 insertions(+)

Do you happen to have a Tegra132 device that you can test upstream Linux
on? Just asking out of curiosity because these devices are becoming very
rare these days and it'd be good to know if people are still using these
and that recent Linux kernels are still running on them.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] arm64: tegra: Enable IOMMU for host1x on Tegra132

[Thierry Reding]

From: Thierry Reding <treding@nvidia.com>


On Thu, 10 Aug 2023 22:45:41 +0100, Rayyan Ansari wrote:
> Add the iommu property to the host1x node to register it with its
> swgroup.
> 
> 

Applied, thanks!

[1/1] arm64: tegra: Enable IOMMU for host1x on Tegra132
      commit: ffca3ccbe50e12a83facfc7e9beabd1851345fa0

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

Re: [PATCH] arm64: tegra: Enable IOMMU for host1x on Tegra132

[Rayyan Ansari]

On 16/08/2023 17:24, Thierry Reding wrote:
> On Thu, Aug 10, 2023 at 10:45:41PM +0100, Rayyan Ansari wrote:
>> Add the iommu property to the host1x node to register it with its
>> swgroup.
>>
>> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
>> ---
>>   arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 ++
>>   1 file changed, 2 insertions(+)
> 
> Do you happen to have a Tegra132 device that you can test upstream Linux
> on? Just asking out of curiosity because these devices are becoming very
> rare these days and it'd be good to know if people are still using these
> and that recent Linux kernels are still running on them.

I do - I have the Nexus 9. At some point I was trying to mainline it, 
but I stopped as I couldn't manage to get USB working - I only got 
simplefb working. If it would be useful I could see if my old patches 
work now and submit them.

> 
> Thierry

-- 
Rayyan Ansari
https://ansari.sh

Re: [PATCH] arm64: tegra: Enable IOMMU for host1x on Tegra132

[Rayyan Ansari]

On 16/08/2023 20:56, Rayyan Ansari wrote:
> On 16/08/2023 17:24, Thierry Reding wrote:
>> On Thu, Aug 10, 2023 at 10:45:41PM +0100, Rayyan Ansari wrote:
>>> Add the iommu property to the host1x node to register it with its
>>> swgroup.
>>>
>>> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>
>>> ---
>>>   arch/arm64/boot/dts/nvidia/tegra132.dtsi | 2 ++
>>>   1 file changed, 2 insertions(+)
>>
>> Do you happen to have a Tegra132 device that you can test upstream Linux
>> on? Just asking out of curiosity because these devices are becoming very
>> rare these days and it'd be good to know if people are still using these
>> and that recent Linux kernels are still running on them.
> 
> I do - I have the Nexus 9. At some point I was trying to mainline it, 
> but I stopped as I couldn't manage to get USB working - I only got 
> simplefb working. If it would be useful I could see if my old patches 
> work now and submit them.

I looked through my old notes and I was able to get USB host mode (ie 
USB OTG) working but not USB device mode.

> 
>>
>> Thierry
> 

-- 
Rayyan Ansari
https://ansari.sh