From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BC1C0015E for ; Fri, 11 Aug 2023 11:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236191AbjHKLSD (ORCPT ); Fri, 11 Aug 2023 07:18:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236193AbjHKLSC (ORCPT ); Fri, 11 Aug 2023 07:18:02 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DA2CEE7E; Fri, 11 Aug 2023 04:18:00 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9839CD75; Fri, 11 Aug 2023 04:18:42 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35F4E3F6C4; Fri, 11 Aug 2023 04:17:58 -0700 (PDT) Date: Fri, 11 Aug 2023 12:17:54 +0100 From: Andre Przywara To: Martin Botka Cc: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Alan Ma , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio Subject: Re: [PATCH 2/3] nvmem: sunxi_sid: Add support for H616 SID Message-ID: <20230811121754.3a4dc270@donnerap.manchester.arm.com> In-Reply-To: <20230811-sid-h616-v1-2-d1dfc9f47b19@somainline.org> References: <20230811-sid-h616-v1-0-d1dfc9f47b19@somainline.org> <20230811-sid-h616-v1-2-d1dfc9f47b19@somainline.org> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 11 Aug 2023 13:02:35 +0200 Martin Botka wrote: Hi Martin, > Add support for the H616 SID controller. thanks for upstreaming this! > > The config can be reused from A64. > > Signed-off-by: Martin Botka > --- > drivers/nvmem/sunxi_sid.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c > index a970f1741cc6..df6fb5e0b724 100644 > --- a/drivers/nvmem/sunxi_sid.c > +++ b/drivers/nvmem/sunxi_sid.c > @@ -216,6 +216,7 @@ static const struct of_device_id sunxi_sid_of_match[] = { > { .compatible = "allwinner,sun50i-a64-sid", .data = &sun50i_a64_cfg }, > { .compatible = "allwinner,sun50i-h5-sid", .data = &sun50i_a64_cfg }, > { .compatible = "allwinner,sun50i-h6-sid", .data = &sun50i_h6_cfg }, > + { .compatible = "allwinner,sun50i-h616-sid", .data = &sun50i_a64_cfg }, You don't need a new compatible string, then. Just use compatible = "allwinner,sun50i-h616-sid", "allwinner,sun50i-a64-sid"; in the DT, and add that combo to the binding, then you don't need any driver patches at all - with the added benefit of that already working with existing kernels. Though I wonder if that has really only 256 bytes of fuses? Do we have any evidence of that? Cheers, Andre > {/* sentinel */}, > }; > MODULE_DEVICE_TABLE(of, sunxi_sid_of_match); >