* [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example
@ 2023-08-08 6:32 Krzysztof Kozlowski
2023-08-08 6:52 ` Matti Vaittinen
2023-08-11 15:17 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-08 6:32 UTC (permalink / raw)
To: Jonathan Cameron, Lars-Peter Clausen, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matti Vaittinen, linux-iio,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings require vdd-supply but the example DTS was missing one. This
fixes dt_binding_check error:
Documentation/devicetree/bindings/iio/light/rohm,bu27010.example.dtb: light-sensor@38: 'vdd-supply' is a required property
Fixes: ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml b/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
index 8376d64a641a..bed42d5d0d94 100644
--- a/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
+++ b/Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml
@@ -45,5 +45,6 @@ examples:
light-sensor@38 {
compatible = "rohm,bu27010";
reg = <0x38>;
+ vdd-supply = <&vdd>;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example
2023-08-08 6:32 [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example Krzysztof Kozlowski
@ 2023-08-08 6:52 ` Matti Vaittinen
2023-08-11 15:17 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Matti Vaittinen @ 2023-08-08 6:52 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jonathan Cameron, Lars-Peter Clausen,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-iio,
devicetree, linux-kernel
On 8/8/23 09:32, Krzysztof Kozlowski wrote:
> Bindings require vdd-supply but the example DTS was missing one. This
> fixes dt_binding_check error:
>
> Documentation/devicetree/bindings/iio/light/rohm,bu27010.example.dtb: light-sensor@38: 'vdd-supply' is a required property
>
> Fixes: ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Ah. Added supply to required ones when you pointed out it should be -
and obviously didn't fix the example :/
Thanks a lot for fixing it!
Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example
2023-08-08 6:32 [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example Krzysztof Kozlowski
2023-08-08 6:52 ` Matti Vaittinen
@ 2023-08-11 15:17 ` Rob Herring
2023-09-03 11:00 ` Jonathan Cameron
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2023-08-11 15:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Jonathan Cameron, Lars-Peter Clausen, Krzysztof Kozlowski,
Conor Dooley, Matti Vaittinen, linux-iio, devicetree,
linux-kernel
On Tue, Aug 08, 2023 at 08:32:23AM +0200, Krzysztof Kozlowski wrote:
> Bindings require vdd-supply but the example DTS was missing one. This
> fixes dt_binding_check error:
>
> Documentation/devicetree/bindings/iio/light/rohm,bu27010.example.dtb: light-sensor@38: 'vdd-supply' is a required property
>
> Fixes: ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example
2023-08-11 15:17 ` Rob Herring
@ 2023-09-03 11:00 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2023-09-03 11:00 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Lars-Peter Clausen, Krzysztof Kozlowski,
Conor Dooley, Matti Vaittinen, linux-iio, devicetree,
linux-kernel
On Fri, 11 Aug 2023 09:17:55 -0600
Rob Herring <robh@kernel.org> wrote:
> On Tue, Aug 08, 2023 at 08:32:23AM +0200, Krzysztof Kozlowski wrote:
> > Bindings require vdd-supply but the example DTS was missing one. This
> > fixes dt_binding_check error:
> >
> > Documentation/devicetree/bindings/iio/light/rohm,bu27010.example.dtb: light-sensor@38: 'vdd-supply' is a required property
> >
> > Fixes: ae8c47c51e5c ("dt-bindings: iio: ROHM BU27010 RGBC + flickering sensor")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Documentation/devicetree/bindings/iio/light/rohm,bu27010.yaml | 1 +
> > 1 file changed, 1 insertion(+)
>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to the fixes-togreg branch of iio.git.
Note I want to rebase that on rc1 before sending next pull request so it will be a week or two.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-03 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 6:32 [PATCH] dt-bindings: iio: rohm,bu27010: add missing vdd-supply to example Krzysztof Kozlowski
2023-08-08 6:52 ` Matti Vaittinen
2023-08-11 15:17 ` Rob Herring
2023-09-03 11:00 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).