From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A54C0015E for ; Fri, 11 Aug 2023 21:15:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232295AbjHKVPB (ORCPT ); Fri, 11 Aug 2023 17:15:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjHKVPB (ORCPT ); Fri, 11 Aug 2023 17:15:01 -0400 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C1AD171F; Fri, 11 Aug 2023 14:15:00 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 37BLEo4j086332; Fri, 11 Aug 2023 16:14:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1691788490; bh=3FiBFHExBQrDVeeYuHKo+/tmEj7jNIisdfEiRNPw2Lo=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=jh1T2uHU1Sde8pmv7BxksOhE/uEHsEuPga7q3q+6tyCOFjbgGiVSi8pJKehDGQGmg b7TtpWadME3zUQp+TCy0UJLAS0VQphb1dO1973gNdSniv4ZNY/2LDQySdZVNZfnHNE oUW1gMoi5QI+hDaNHovbSFW1F+gO8/prDnPU/bSs= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 37BLEohd088187 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Aug 2023 16:14:50 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Fri, 11 Aug 2023 16:14:50 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Fri, 11 Aug 2023 16:14:50 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 37BLEoCe031975; Fri, 11 Aug 2023 16:14:50 -0500 Date: Fri, 11 Aug 2023 16:14:50 -0500 From: Nishanth Menon To: Andrew Davis CC: Apurva Nandan , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , , Hari Nagalla , Udit Kumar Subject: Re: [PATCH v3 0/5] Add R5F and C7x DSP nodes for J721S2 SoC. Message-ID: <20230811211450.psoe6wjvncwxoqe2@enlarged> References: <20230811202252.3586926-1-a-nandan@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15:31-20230811, Andrew Davis wrote: > On 8/11/23 3:22 PM, Apurva Nandan wrote: > > This series adds the R5F processor nodes and C7x DSP nodes for > > J721S2 SoC. > > > > The first three patches adds the remote proc nodes to the SoC device > > tree and the last two patches reserves the memory for remote proc IPCs > > on J721S2 EVM board. > > > > Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/ > > > > v3: Changelog: > > 1) Disabled c7x in k3-j721s2-main.dtsi and enabled in k3-j721s2-som-p0.dtsi > > which fixes the following dtbs_check for k3-am69-sk.dts > > - dsp@64800000: 'mboxes' is a required property > > - dsp@64800000: 'memory-region' is a required property > > 2) Split into separate patches for C7x and R5F > > Thanks for taking care of these details, series LGTM, > > Reviewed-by: Andrew Davis > > > > > Link to v2: > > https://lore.kernel.org/lkml/20230808201842.292911-1-a-nandan@ti.com/ > > > > v2:Changelog: > > 1) Added status = "disabled"; in soc dtsi files, and removed it from som dts > > 2) Fixed mboxes property in for all cores in som dts > > > > Link to v1: > > https://lore.kernel.org/all/20230529220941.10801-1-hnagalla@ti.com/ > > > > Apurva Nandan (4): > > arm64: dts: ti: k3-j721s2-main: Add MAIN R5F remote processsor nodes > > arm64: dts: ti: k3-j721s2-main: Add C7x remote processsor nodes > > arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for > > R5F > > arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for > > C71x DSPs > > > > Hari Nagalla (1): > > arm64: dts: ti: k3-j721s2-mcu: Add MCU R5F cluster nodes We are still missing arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi which is a TI product. So, lets hold this series off from the immediate merge set at least. > > > > arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 106 +++++++++ > > .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 ++++ > > arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi | 208 ++++++++++++++++++ > > 3 files changed, 354 insertions(+) > > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D