[PATCH 0/3] Various TQMa6UL/MBa6ULx fixes

[PATCH 0/3] Various TQMa6UL/MBa6ULx fixes

[Alexander Stein]

Hi,
while working on tqma6ul device tree I noticed some dtbs_check warnings this
series is about to fix. The first two are specific to MBa6ULx while the last
one is a generic one.

Best regards,
Alexander

Alexander Stein (3):
  ARM: dts: imx6ul: mba6ulx: Fix stmpe811 node warnings
  ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names
  ARM: dts: imx6ul: Fix nand-controller #size-cells

 arch/arm/boot/dts/nxp/imx/imx6ul.dtsi  | 2 +-
 arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 9 ++++-----
 2 files changed, 5 insertions(+), 6 deletions(-)

-- 
2.34.1

[PATCH 1/3] ARM: dts: imx6ul: mba6ulx: Fix stmpe811 node warnings

[Alexander Stein]

interrupt-controller is only valid for gpio subnode, remove it.
Rename touchscreen subnode according to bindings.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
index e14fdee49ab7..632ceadcca41 100644
--- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
@@ -280,10 +280,9 @@ analog_touch: touchscreen@41 {
 		reg = <0x41>;
 		interrupts = <21 IRQ_TYPE_EDGE_FALLING>;
 		interrupt-parent = <&gpio4>;
-		interrupt-controller;
 		status = "disabled";
 
-		stmpe_touchscreen {
+		touchscreen {
 			compatible = "st,stmpe-ts";
 			st,adc-freq = <1>;      /* 3.25 MHz ADC clock speed */
 			st,ave-ctrl = <3>;      /* 8 sample average control */
-- 
2.34.1

Re: [PATCH 1/3] ARM: dts: imx6ul: mba6ulx: Fix stmpe811 node warnings

[Shawn Guo]

On Thu, Aug 10, 2023 at 11:55:39AM +0200, Alexander Stein wrote:
> interrupt-controller is only valid for gpio subnode, remove it.
> Rename touchscreen subnode according to bindings.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Applied, thanks!

[PATCH 2/3] ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names

[Alexander Stein]

Numbers are separated by dashes. Fixes the warnings:
arch/arm/boot/dts/nxp/imx/imx6ull-tqma6ull2-mba6ulx.dtb: gpio-keys:
'button1', 'button2', 'button3' do not match any of the regexes:
'^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
 from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
index 632ceadcca41..5a8b867d7d79 100644
--- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
@@ -35,21 +35,21 @@ gpio_buttons: gpio-keys {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_buttons>;
 
-		button1 {
+		button-1 {
 			label = "s14";
 			linux,code = <KEY_1>;
 			gpios = <&expander_in0 0 GPIO_ACTIVE_LOW>;
 			wakeup-source;
 		};
 
-		button2 {
+		button-2 {
 			label = "s6";
 			linux,code = <KEY_2>;
 			gpios = <&expander_in0 1 GPIO_ACTIVE_LOW>;
 			wakeup-source;
 		};
 
-		button3 {
+		button-3 {
 			label = "s7";
 			linux,code = <KEY_3>;
 			gpios = <&expander_in0 2 GPIO_ACTIVE_LOW>;
-- 
2.34.1

Re: [PATCH 2/3] ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names

[Shawn Guo]

On Thu, Aug 10, 2023 at 11:55:40AM +0200, Alexander Stein wrote:
> Numbers are separated by dashes. Fixes the warnings:
> arch/arm/boot/dts/nxp/imx/imx6ull-tqma6ull2-mba6ulx.dtb: gpio-keys:
> 'button1', 'button2', 'button3' do not match any of the regexes:
> '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
>  from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

It doesn't apply to my imx/dt branch.

Shawn

> ---
>  arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> index 632ceadcca41..5a8b867d7d79 100644
> --- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> @@ -35,21 +35,21 @@ gpio_buttons: gpio-keys {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_buttons>;
>  
> -		button1 {
> +		button-1 {
>  			label = "s14";
>  			linux,code = <KEY_1>;
>  			gpios = <&expander_in0 0 GPIO_ACTIVE_LOW>;
>  			wakeup-source;
>  		};
>  
> -		button2 {
> +		button-2 {
>  			label = "s6";
>  			linux,code = <KEY_2>;
>  			gpios = <&expander_in0 1 GPIO_ACTIVE_LOW>;
>  			wakeup-source;
>  		};
>  
> -		button3 {
> +		button-3 {
>  			label = "s7";
>  			linux,code = <KEY_3>;
>  			gpios = <&expander_in0 2 GPIO_ACTIVE_LOW>;
> -- 
> 2.34.1
> 

Re: [PATCH 2/3] ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names

[Alexander Stein]

Hi Shawn,

Am Samstag, 12. August 2023, 03:44:14 CEST schrieb Shawn Guo:
> On Thu, Aug 10, 2023 at 11:55:40AM +0200, Alexander Stein wrote:
> > Numbers are separated by dashes. Fixes the warnings:
> > arch/arm/boot/dts/nxp/imx/imx6ull-tqma6ull2-mba6ulx.dtb: gpio-keys:
> > 'button1', 'button2', 'button3' do not match any of the regexes:
> > '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+
> > -(button|event|key|switch))$', 'pinctrl-[0-9]+'> 
> >  from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> It doesn't apply to my imx/dt branch.

Oh, thanks for noticing. A dependent patch was missing and has been included 
in v2.

Thanks and best regards,
Alexander

> Shawn
> 
> > ---
> > 
> >  arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi index 632ceadcca41..5a8b867d7d79
> > 100644
> > --- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > @@ -35,21 +35,21 @@ gpio_buttons: gpio-keys {
> > 
> >  		pinctrl-names = "default";
> >  		pinctrl-0 = <&pinctrl_buttons>;
> > 
> > -		button1 {
> > +		button-1 {
> > 
> >  			label = "s14";
> >  			linux,code = <KEY_1>;
> >  			gpios = <&expander_in0 0 GPIO_ACTIVE_LOW>;
> >  			wakeup-source;
> >  		
> >  		};
> > 
> > -		button2 {
> > +		button-2 {
> > 
> >  			label = "s6";
> >  			linux,code = <KEY_2>;
> >  			gpios = <&expander_in0 1 GPIO_ACTIVE_LOW>;
> >  			wakeup-source;
> >  		
> >  		};
> > 
> > -		button3 {
> > +		button-3 {
> > 
> >  			label = "s7";
> >  			linux,code = <KEY_3>;
> >  			gpios = <&expander_in0 2 GPIO_ACTIVE_LOW>;


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/

[PATCH 3/3] ARM: dts: imx6ul: Fix nand-controller #size-cells

[Alexander Stein]

nand-controller.yaml bindings says #size-cells shall be set to 0.
Fixes the dtbs_check warning:
arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul2l-mba6ulx.dtb:
 nand-controller@1806000: #size-cells:0:0: 0 was expected
 from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm/boot/dts/nxp/imx/imx6ul.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
index 0174f3edbd16..3b87d980e9f4 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul.dtsi
@@ -179,7 +179,7 @@ dma_apbh: dma-controller@1804000 {
 		gpmi: nand-controller@1806000 {
 			compatible = "fsl,imx6q-gpmi-nand";
 			#address-cells = <1>;
-			#size-cells = <1>;
+			#size-cells = <0>;
 			reg = <0x01806000 0x2000>, <0x01808000 0x2000>;
 			reg-names = "gpmi-nand", "bch";
 			interrupts = <0 15 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.34.1

Re: [PATCH 3/3] ARM: dts: imx6ul: Fix nand-controller #size-cells

[Shawn Guo]

On Thu, Aug 10, 2023 at 11:55:41AM +0200, Alexander Stein wrote:
> nand-controller.yaml bindings says #size-cells shall be set to 0.
> Fixes the dtbs_check warning:
> arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul2l-mba6ulx.dtb:
>  nand-controller@1806000: #size-cells:0:0: 0 was expected
>  from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Applied, thanks!