From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names
Date: Sat, 12 Aug 2023 09:44:14 +0800 [thread overview]
Message-ID: <20230812014414.GE151430@dragon> (raw)
In-Reply-To: <20230810095541.720489-3-alexander.stein@ew.tq-group.com>
On Thu, Aug 10, 2023 at 11:55:40AM +0200, Alexander Stein wrote:
> Numbers are separated by dashes. Fixes the warnings:
> arch/arm/boot/dts/nxp/imx/imx6ull-tqma6ull2-mba6ulx.dtb: gpio-keys:
> 'button1', 'button2', 'button3' do not match any of the regexes:
> '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-(button|event|key|switch))$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
It doesn't apply to my imx/dt branch.
Shawn
> ---
> arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> index 632ceadcca41..5a8b867d7d79 100644
> --- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> @@ -35,21 +35,21 @@ gpio_buttons: gpio-keys {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_buttons>;
>
> - button1 {
> + button-1 {
> label = "s14";
> linux,code = <KEY_1>;
> gpios = <&expander_in0 0 GPIO_ACTIVE_LOW>;
> wakeup-source;
> };
>
> - button2 {
> + button-2 {
> label = "s6";
> linux,code = <KEY_2>;
> gpios = <&expander_in0 1 GPIO_ACTIVE_LOW>;
> wakeup-source;
> };
>
> - button3 {
> + button-3 {
> label = "s7";
> linux,code = <KEY_3>;
> gpios = <&expander_in0 2 GPIO_ACTIVE_LOW>;
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-08-12 1:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 9:55 [PATCH 0/3] Various TQMa6UL/MBa6ULx fixes Alexander Stein
2023-08-10 9:55 ` [PATCH 1/3] ARM: dts: imx6ul: mba6ulx: Fix stmpe811 node warnings Alexander Stein
2023-08-12 1:43 ` Shawn Guo
2023-08-10 9:55 ` [PATCH 2/3] ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names Alexander Stein
2023-08-12 1:44 ` Shawn Guo [this message]
2023-08-16 7:55 ` Alexander Stein
2023-08-10 9:55 ` [PATCH 3/3] ARM: dts: imx6ul: Fix nand-controller #size-cells Alexander Stein
2023-08-12 1:44 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230812014414.GE151430@dragon \
--to=shawnguo@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).