From: Vladimir Oltean <olteanv@gmail.com>
To: "Arınç ÜNAL" <arinc.unal@arinc9.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Woojung Huh" <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Daniel Golle" <daniel@makrotopia.org>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/4] dt-bindings: net: dsa: microchip,lan937x: add missing ethernet on example
Date: Sun, 13 Aug 2023 14:07:47 +0300 [thread overview]
Message-ID: <20230813110747.rvvsvte2t6pbe5j4@skbuf> (raw)
In-Reply-To: <20230812091708.34665-2-arinc.unal@arinc9.com> <20230812091708.34665-2-arinc.unal@arinc9.com>
On Sat, Aug 12, 2023 at 12:17:05PM +0300, Arınç ÜNAL wrote:
> The port@5 node on the example is missing the ethernet property. Add it.
> Remove the MAC bindings on the example as they cannot be validated.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---
> .../bindings/net/dsa/microchip,lan937x.yaml | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml
> index 8d7e878b84dc..49af4b0d5916 100644
> --- a/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/microchip,lan937x.yaml
> @@ -68,16 +68,6 @@ examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
>
> - macb0 {
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - fixed-link {
> - speed = <1000>;
> - full-duplex;
> - };
> - };
> -
> spi {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -138,6 +128,7 @@ examples:
> phy-mode = "rgmii";
> tx-internal-delay-ps = <2000>;
> rx-internal-delay-ps = <2000>;
> + ethernet = <&macb1>;
macb1 instead of macb0: was it intentional?
>
> fixed-link {
> speed = <1000>;
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-08-13 11:07 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 9:17 [PATCH net-next 0/4] Document internal MDIO bus of DSA switch and support it on MT7530 Arınç ÜNAL
2023-08-12 9:17 ` [PATCH 1/4] dt-bindings: net: dsa: microchip,lan937x: add missing ethernet on example Arınç ÜNAL
2023-08-13 11:07 ` Vladimir Oltean [this message]
2023-08-13 11:23 ` Arınç ÜNAL
2023-08-14 14:54 ` Vladimir Oltean
2023-08-16 16:29 ` Florian Fainelli
2023-08-21 17:36 ` Rob Herring
2023-08-12 9:17 ` [PATCH 2/4] dt-bindings: net: dsa: document internal MDIO bus Arınç ÜNAL
2023-08-12 16:28 ` Arınç ÜNAL
2023-08-12 19:20 ` Arınç ÜNAL
2023-08-13 11:53 ` Vladimir Oltean
2023-08-13 12:59 ` Arınç ÜNAL
2023-08-13 14:58 ` Arınç ÜNAL
2023-08-13 19:02 ` Vladimir Oltean
2023-08-14 10:06 ` Arınç ÜNAL
2023-08-14 10:39 ` Vladimir Oltean
2023-08-13 19:01 ` Vladimir Oltean
2023-08-14 10:06 ` Arınç ÜNAL
2023-08-14 13:09 ` Andrew Lunn
2023-08-27 8:38 ` Arınç ÜNAL
2023-09-09 6:23 ` Arınç ÜNAL
2023-09-13 1:21 ` Andrew Lunn
2023-09-13 12:44 ` Arınç ÜNAL
2023-08-14 14:36 ` Vladimir Oltean
2023-08-27 8:33 ` Arınç ÜNAL
2023-08-27 12:12 ` Vladimir Oltean
2023-09-04 11:33 ` Arınç ÜNAL
2023-09-05 2:42 ` Luiz Angelo Daros de Luca
2023-09-05 11:00 ` Arınç ÜNAL
2023-09-05 11:05 ` Vladimir Oltean
2023-09-05 11:11 ` Vladimir Oltean
2023-09-05 12:13 ` Andrew Lunn
2023-09-09 8:53 ` Arınç ÜNAL
2023-09-09 14:35 ` Arınç ÜNAL
2023-09-09 19:53 ` Arınç ÜNAL
2023-09-09 21:16 ` Andrew Lunn
2023-09-12 18:09 ` Arınç ÜNAL
2023-09-11 22:51 ` Vladimir Oltean
2023-09-12 19:23 ` Arınç ÜNAL
2023-09-12 19:34 ` Vladimir Oltean
2023-09-13 5:52 ` Arınç ÜNAL
2023-09-13 7:42 ` Vladimir Oltean
2023-09-13 10:59 ` Arınç ÜNAL
2023-09-13 11:04 ` Vladimir Oltean
2023-09-13 11:35 ` Arınç ÜNAL
2023-09-13 13:00 ` Vladimir Oltean
2023-09-13 14:36 ` Arınç ÜNAL
2023-09-13 15:59 ` Russell King (Oracle)
2023-09-14 16:12 ` Vladimir Oltean
2023-09-14 18:06 ` Russell King (Oracle)
2023-09-14 18:07 ` Russell King (Oracle)
2023-09-15 12:18 ` Vladimir Oltean
2023-08-14 14:57 ` Vladimir Oltean
2023-08-21 17:44 ` Rob Herring
2023-08-27 8:42 ` Arınç ÜNAL
2023-08-13 11:15 ` Vladimir Oltean
2023-08-13 12:58 ` Arınç ÜNAL
2023-08-12 9:17 ` [PATCH 3/4] dt-bindings: net: dsa: realtek: require compatible property under mdio node Arınç ÜNAL
2023-08-12 16:31 ` Arınç ÜNAL
2023-08-14 14:53 ` Vladimir Oltean
2023-08-14 18:23 ` Linus Walleij
2023-08-16 16:28 ` Florian Fainelli
2023-08-12 9:17 ` [PATCH 4/4] net: dsa: mt7530: register OF node for internal MDIO bus Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230813110747.rvvsvte2t6pbe5j4@skbuf \
--to=olteanv@gmail.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mithat.guner@xeront.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).