[PATCH v2 0/2] Enable Security ID for H616

[PATCH v2 0/2] Enable Security ID for H616

[Martin Botka]

Hello,

This patch series enables Security ID (SID) support for AllWinner H616.

SID support is an requirement for few things:
    - Thermal sensors
    - CPU Binning ID (cpufreq will use this)
    - EPhy

This patch series doesn't add support for the consumers.
Those will come in the future via their own series.

Cheers,
Martin

Signed-off-by: Martin Botka <martin.botka@somainline.org>
---
Changes in v2:
- Drop driver changes
- Use fallback compatible in DT
- Link to v1: https://lore.kernel.org/r/20230811-sid-h616-v1-0-d1dfc9f47b19@somainline.org

---
Martin Botka (2):
      dt-bindings: nvmem: SID: Add binding for H616 SID controller
      arm64: dts: allwinner: h616: Add SID controller node

 .../devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml         | 1 +
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi                     | 7 +++++++
 2 files changed, 8 insertions(+)
---
base-commit: 52a93d39b17dc7eb98b6aa3edb93943248e03b2f
change-id: 20230811-sid-h616-37b773e59571

Best regards,
-- 
Martin Botka <martin.botka@somainline.org>

[PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller

[Martin Botka]

Add binding for the SID controller found in H616 SoC

Signed-off-by: Martin Botka <martin.botka@somainline.org>
---
 Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
index 296001e7f498..2ec0a1b8f803 100644
--- a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
+++ b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
@@ -27,6 +27,7 @@ properties:
           - const: allwinner,sun50i-a64-sid
       - const: allwinner,sun50i-h5-sid
       - const: allwinner,sun50i-h6-sid
+      - const: allwinner,sun50i-h616-sid
 
   reg:
     maxItems: 1

-- 
2.41.0

[PATCH v2 2/2] arm64: dts: allwinner: h616: Add SID controller node

[Martin Botka]

Add node for the H616 SID controller

Signed-off-by: Martin Botka <martin.botka@somainline.org>
---
 arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
index 74aed0d232a9..d549d277d972 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
@@ -133,6 +133,13 @@ ccu: clock@3001000 {
 			#reset-cells = <1>;
 		};
 
+		sid: efuse@3006000 {
+			compatible = "allwinner,sun50i-h616-sid", "allwinner,sun50i-a64-sid";
+			reg = <0x03006000 0x1000>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+		};
+
 		watchdog: watchdog@30090a0 {
 			compatible = "allwinner,sun50i-h616-wdt",
 				     "allwinner,sun6i-a31-wdt";

-- 
2.41.0

Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller

[Krzysztof Kozlowski]

On 14/08/2023 08:38, Martin Botka wrote:
> Add binding for the SID controller found in H616 SoC
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
>  Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> index 296001e7f498..2ec0a1b8f803 100644
> --- a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> @@ -27,6 +27,7 @@ properties:
>            - const: allwinner,sun50i-a64-sid
>        - const: allwinner,sun50i-h5-sid
>        - const: allwinner,sun50i-h6-sid
> +      - const: allwinner,sun50i-h616-sid

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Best regards,
Krzysztof

Re: [PATCH v2 2/2] arm64: dts: allwinner: h616: Add SID controller node

[Krzysztof Kozlowski]

On 14/08/2023 08:38, Martin Botka wrote:
> Add node for the H616 SID controller
> 
> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> index 74aed0d232a9..d549d277d972 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> @@ -133,6 +133,13 @@ ccu: clock@3001000 {
>  			#reset-cells = <1>;
>  		};
>  
> +		sid: efuse@3006000 {
> +			compatible = "allwinner,sun50i-h616-sid", "allwinner,sun50i-a64-sid";

Are you sure? Limited diff context from your patch #1 suggests something
else.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller

[Martin Botka]

On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski 
<krzysztof.kozlowski@linaro.org> wrote:
> On 14/08/2023 08:38, Martin Botka wrote:
>>  Add binding for the SID controller found in H616 SoC
>> 
>>  Signed-off-by: Martin Botka <martin.botka@somainline.org>
>>  ---
>>   
>> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml 
>> | 1 +
>>   1 file changed, 1 insertion(+)
>> 
>>  diff --git 
>> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml 
>> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>>  index 296001e7f498..2ec0a1b8f803 100644
>>  --- 
>> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>>  +++ 
>> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
>>  @@ -27,6 +27,7 @@ properties:
>>             - const: allwinner,sun50i-a64-sid
>>         - const: allwinner,sun50i-h5-sid
>>         - const: allwinner,sun50i-h6-sid
>>  +      - const: allwinner,sun50i-h616-sid
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> 
> Best regards,
> Krzysztof
> 
Yea completely forgot. Sorry for that.

Will send v3 tomorrow with proper binding patch using items with enums

Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller

[Jernej Škrabec]

Dne ponedeljek, 14. avgust 2023 ob 10:21:49 CEST je Martin Botka napisal(a):
> On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski
> 
> <krzysztof.kozlowski@linaro.org> wrote:
> > On 14/08/2023 08:38, Martin Botka wrote:
> >>  Add binding for the SID controller found in H616 SoC
> >>  
> >>  Signed-off-by: Martin Botka <martin.botka@somainline.org>
> >>  ---
> >> 
> >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> 
> >> | 1 +
> >> | 
> >>   1 file changed, 1 insertion(+)
> >>  
> >>  diff --git
> >> 
> >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> 
> >>  index 296001e7f498..2ec0a1b8f803 100644
> >>  ---
> >> 
> >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> 
> >>  +++
> >> 
> >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> >> 
> >>  @@ -27,6 +27,7 @@ properties:
> >>             - const: allwinner,sun50i-a64-sid
> >>         
> >>         - const: allwinner,sun50i-h5-sid
> >>         - const: allwinner,sun50i-h6-sid
> >>  
> >>  +      - const: allwinner,sun50i-h616-sid
> > 
> > It does not look like you tested the DTS against bindings. Please run
> > `make dtbs_check` (see
> > Documentation/devicetree/bindings/writing-schema.rst or
> > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sour
> > ces-with-the-devicetree-schema/ for instructions).
> > 
> > Best regards,
> > Krzysztof
> 
> Yea completely forgot. Sorry for that.
> 
> Will send v3 tomorrow with proper binding patch using items with enums

Don't. You have cca. 1 month time now, since you missed at least window for DT 
changes for 6.6.

Best regards,
Jernej

Re: [PATCH v2 1/2] dt-bindings: nvmem: SID: Add binding for H616 SID controller

[Andre Przywara]

On Mon, 14 Aug 2023 12:28:36 +0200
Jernej Škrabec <jernej.skrabec@gmail.com> wrote:

> Dne ponedeljek, 14. avgust 2023 ob 10:21:49 CEST je Martin Botka napisal(a):
> > On Mon, Aug 14 2023 at 10:08:38 AM +02:00:00, Krzysztof Kozlowski
> > 
> > <krzysztof.kozlowski@linaro.org> wrote:  
> > > On 14/08/2023 08:38, Martin Botka wrote:  
> > >>  Add binding for the SID controller found in H616 SoC
> > >>  
> > >>  Signed-off-by: Martin Botka <martin.botka@somainline.org>
> > >>  ---
> > >> 
> > >> Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> 
> > >> | 1 +
> > >> | 
> > >>   1 file changed, 1 insertion(+)
> > >>  
> > >>  diff --git
> > >> 
> > >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> 
> > >>  index 296001e7f498..2ec0a1b8f803 100644
> > >>  ---
> > >> 
> > >> a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> 
> > >>  +++
> > >> 
> > >> b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> > >> 
> > >>  @@ -27,6 +27,7 @@ properties:
> > >>             - const: allwinner,sun50i-a64-sid
> > >>         
> > >>         - const: allwinner,sun50i-h5-sid
> > >>         - const: allwinner,sun50i-h6-sid
> > >>  
> > >>  +      - const: allwinner,sun50i-h616-sid  
> > > 
> > > It does not look like you tested the DTS against bindings. Please run
> > > `make dtbs_check` (see
> > > Documentation/devicetree/bindings/writing-schema.rst or
> > > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sour
> > > ces-with-the-devicetree-schema/ for instructions).
> > > 
> > > Best regards,
> > > Krzysztof  
> > 
> > Yea completely forgot. Sorry for that.
> > 
> > Will send v3 tomorrow with proper binding patch using items with enums  
> 
> Don't. You have cca. 1 month time now, since you missed at least window for DT 
> changes for 6.6.

Plus we need to figure out if my comment about using a fallback compatible
was actually correct, as asked here:
https://lore.kernel.org/linux-arm-kernel/20230811234212.2236c814@slackpad.lan/

Cheers,
Andre