From: Nishanth Menon <nm@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<afd@ti.com>
Subject: Re: [PATCH v2 0/3] arm64: dts: ti: Introduce AM62P5 SoC and board
Date: Mon, 14 Aug 2023 15:33:58 -0500 [thread overview]
Message-ID: <20230814203358.tsx343ifog5tpldi@quicksand> (raw)
In-Reply-To: <5a1ed797-d29a-e047-ccec-adb1dde6d74f@linaro.org>
On 21:26-20230814, Krzysztof Kozlowski wrote:
> On 12/08/2023 00:49, Nishanth Menon wrote:
Looping in Vinod
[...]
>
> A bit too fast. simple-mfd *is not allowed* on its own.
>
Actually dtbs_check comes up clean, but more I dug at it, looks like we
should probably cleanup.
(everything):
https://gist.github.com/nmenon/5f5f689333c66697969f5d80ad94cfca
(am62p alone):
https://gist.github.com/nmenon/9aaa2067a619b12af338647d19b4cf9b
$ git grep 'compatible = "simple-mfd";' arch/arm64/boot/dts/ti/
arch/arm64/boot/dts/ti/k3-am62-main.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-am62p-main.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-am64-main.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-am65-main.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-j7200-main.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-j721e-main.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi: compatible = "simple-mfd";
arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi: compatible = "simple-mfd";
It is all over our k3 dts folder for dma. Digging further, it looks to
have been explicitly permitted by the bindings:
$ git grep 'compatible = "simple-mfd";' Documentation/devicetree/bindings/
Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml: compatible = "simple-mfd";
Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml: compatible = "simple-mfd";
Documentation/devicetree/bindings/dma/ti/k3-udma.yaml: compatible = "simple-mfd";
Looks like we will have to cleanup the yaml bindings and the dts nodes
in a manner that doesn't break the platforms.
I am not saying that simple-mfd usage is correct, but it was
explicitly permitted by schema in these instances, are you OK that we
clean that in the upcoming merge window as the very first thing we do
and let this series through?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2023-08-14 20:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 18:44 [PATCH v2 0/3] arm64: dts: ti: Introduce AM62P5 SoC and board Vignesh Raghavendra
2023-08-11 18:44 ` [PATCH v2 1/3] dt-bindings: arm: ti: Add bindings for AM62P5 SoCs Vignesh Raghavendra
2023-08-11 18:44 ` [PATCH v2 2/3] arm64: dts: ti: Introduce AM62P5 family of SoCs Vignesh Raghavendra
2023-08-14 19:24 ` Krzysztof Kozlowski
2023-08-11 18:44 ` [PATCH v2 3/3] arm64: dts: ti: Add support for the AM62P5 Starter Kit Vignesh Raghavendra
2023-08-11 18:53 ` Andrew Davis
2023-08-11 22:49 ` [PATCH v2 0/3] arm64: dts: ti: Introduce AM62P5 SoC and board Nishanth Menon
2023-08-14 19:26 ` Krzysztof Kozlowski
2023-08-14 20:33 ` Nishanth Menon [this message]
2023-08-14 20:54 ` Andrew Davis
2023-08-15 6:59 ` Vignesh Raghavendra
2023-08-15 13:56 ` Andrew Davis
2023-08-16 4:00 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814203358.tsx343ifog5tpldi@quicksand \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).