From: Rohan G Thomas <rohan.g.thomas@intel.com>
To: Jose Abreu <joabreu@synopsys.com>
Cc: alexandre.torgue@foss.st.com, conor+dt@kernel.org,
davem@davemloft.net, devicetree@vger.kernel.org,
edumazet@google.com, krzysztof.kozlowski+dt@linaro.org,
kuba@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
pabeni@redhat.com, peppe.cavallaro@st.com, robh+dt@kernel.org,
Rohan G Thomas <rohan.g.thomas@intel.com>
Subject: RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback
Date: Tue, 15 Aug 2023 11:51:45 +0800 [thread overview]
Message-ID: <20230815035145.16990-1-rohan.g.thomas@intel.com> (raw)
In-Reply-To: <20230814181354.8603-1-rohan.g.thomas@intel.com>
From: Rohan G Thomas <rohan.g.thomas@intel.com>
Date: Mon, Aug 14, 2023 at 15:06:37
> > > + bool tx_q_coe_lmt;
> >
> > Please use a flag here instead of "tx_q_coe_lmt". This is the
> > preferrable method now.
> >
> > Thanks,
> > Jose
>
> Thanks Jose for the feedback. If I read that correctly, your suggestion is to
> change " tx_q_coe_lmt" to something more readable, like "has_txcoe_limit".
> Please correct me if I understand it wrongly.
>
> BR,
> Rohan
>
Or, use int instead of bool?
BR,
Rohan
next prev parent reply other threads:[~2023-08-15 3:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 14:06 [PATCH net-next v3 0/2] net: stmmac: Tx coe sw fallback Rohan G Thomas
2023-08-14 14:06 ` [PATCH net-next v3 1/2] dt-bindings: net: snps,dwmac: Tx queues with coe Rohan G Thomas
2023-08-15 14:23 ` Conor Dooley
2023-08-14 14:06 ` [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback Rohan G Thomas
2023-08-14 16:47 ` Jose Abreu
2023-08-14 18:13 ` rohan.g.thomas
2023-08-15 3:51 ` Rohan G Thomas [this message]
2023-08-16 15:45 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815035145.16990-1-rohan.g.thomas@intel.com \
--to=rohan.g.thomas@intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).