From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6688AC0015E
	for <linux-devicetree@archiver.kernel.org>; Tue, 15 Aug 2023 03:54:59 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234007AbjHODxY (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Mon, 14 Aug 2023 23:53:24 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39344 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234641AbjHODwA (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Mon, 14 Aug 2023 23:52:00 -0400
Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 407E2183;
        Mon, 14 Aug 2023 20:51:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
  d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
  t=1692071513; x=1723607513;
  h=from:to:cc:subject:date:message-id:in-reply-to:
   references:mime-version:content-transfer-encoding;
  bh=0U5mVMBc7pOFHVeJVlzVG7Zb1up3kpgr5XH1w5CKdFQ=;
  b=dJkIDYvZh2RWfJfpff76A3EB7lQDox3PLknJmHZlVZN3QworAVkgi0m4
   FNfcN2lQ5Y7YAjQri0OTa7Iu8aBrG6bCa0YoMqcXa/F7z7gOf9UYekceY
   pZUWCK7KgzBTKfzwKhlTKxofXtgVUrPd0ENVpPfDO/jusgfjhKj1gDZZ3
   /yW3l0exBOzC9QVGaR1y9rKzWi1bvPJY7PDmCbpVKi6kg6D+VgPikiywn
   FPvGXMWBbKeO1wNDqt6HzGjoGxHhMxXz6W55xooMH6GXe1bj55zW3JJly
   Aabs/WlZM8dczck+HK8Tn7YHDIXSu264Ued9sX/KQO3ruMOoVr2D5WetK
   A==;
X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="403176407"
X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; 
   d="scan'208";a="403176407"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 20:51:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="847904364"
X-IronPort-AV: E=Sophos;i="6.01,173,1684825200"; 
   d="scan'208";a="847904364"
Received: from pglc00067.png.intel.com ([10.221.207.87])
  by fmsmga002.fm.intel.com with ESMTP; 14 Aug 2023 20:51:48 -0700
From:   Rohan G Thomas <rohan.g.thomas@intel.com>
To:     Jose Abreu <joabreu@synopsys.com>
Cc:     alexandre.torgue@foss.st.com, conor+dt@kernel.org,
        davem@davemloft.net, devicetree@vger.kernel.org,
        edumazet@google.com, krzysztof.kozlowski+dt@linaro.org,
        kuba@kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        mcoquelin.stm32@gmail.com, netdev@vger.kernel.org,
        pabeni@redhat.com, peppe.cavallaro@st.com, robh+dt@kernel.org,
        Rohan G Thomas <rohan.g.thomas@intel.com>
Subject: RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback
Date:   Tue, 15 Aug 2023 11:51:45 +0800
Message-Id: <20230815035145.16990-1-rohan.g.thomas@intel.com>
X-Mailer: git-send-email 2.19.0
In-Reply-To: <20230814181354.8603-1-rohan.g.thomas@intel.com>
References: <20230814181354.8603-1-rohan.g.thomas@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

From: Rohan G Thomas <rohan.g.thomas@intel.com>
Date: Mon, Aug 14, 2023 at 15:06:37
> > > +	bool tx_q_coe_lmt;
> >
> > Please use a flag here instead of "tx_q_coe_lmt". This is the
> > preferrable method now.
> >
> > Thanks,
> > Jose
> 
> Thanks Jose for the feedback. If I read that correctly, your suggestion is to
> change " tx_q_coe_lmt" to something more readable, like "has_txcoe_limit".
> Please correct me if I understand it wrongly.
> 
> BR,
> Rohan
>

Or, use int instead of bool?

BR,
Rohan