From: Robert Marko <robimarko@gmail.com>
To: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: computersforpeace@gmail.com, Robert Marko <robimarko@gmail.com>
Subject: [PATCH v2 3/5] firmware: qcom_scm: disable SDI if required
Date: Tue, 15 Aug 2023 15:59:36 +0200 [thread overview]
Message-ID: <20230815140030.1068590-3-robimarko@gmail.com> (raw)
In-Reply-To: <20230815140030.1068590-1-robimarko@gmail.com>
IPQ5018 has SDI (Secure Debug Image) enabled by TZ by default, and that
means that WDT being asserted or just trying to reboot will hang the board
in the debug mode and only pulling the power and repowering will help.
Some IPQ4019 boards like Google WiFI have it enabled as well.
So, lets use the boolean DT property to disable SDI during SCM probe.
It is important to disable it as soon as possible as we might have a WDT
assertion at any time which would then leave the board in debug mode,
thus disabling it during SCM removal is not enough.
Signed-off-by: Robert Marko <robimarko@gmail.com>
---
drivers/firmware/qcom_scm.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index abb54df663ea..71d886626233 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -1491,6 +1491,12 @@ static int qcom_scm_probe(struct platform_device *pdev)
if (download_mode)
qcom_scm_set_download_mode(true);
+ /*
+ * Disable SDI if indicated by DT.
+ */
+ if (of_property_read_bool(pdev->dev.of_node, "qcom,sdi-disable"))
+ qcom_scm_disable_sdi();
+
return 0;
}
--
2.41.0
next prev parent reply other threads:[~2023-08-15 14:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 13:59 [PATCH v2 1/5] dt-bindings: firmware: qcom,scm: Document SDI disable Robert Marko
2023-08-15 13:59 ` [PATCH v2 2/5] firmware: qcom: scm: Add SDI disable support Robert Marko
2023-08-16 6:15 ` Krzysztof Kozlowski
2023-08-15 13:59 ` Robert Marko [this message]
2023-08-15 13:59 ` [PATCH v2 4/5] dt-bindings: firmware: qcom,scm: document IPQ5018 compatible Robert Marko
2023-08-16 6:10 ` Krzysztof Kozlowski
2023-09-15 12:23 ` Sricharan Ramabadhran
2023-09-15 12:31 ` Krzysztof Kozlowski
2023-08-15 13:59 ` [PATCH v2 5/5] arm64: dts: qcom: ipq5018: indicate that SDI should be disabled Robert Marko
2023-08-16 6:15 ` [PATCH v2 1/5] dt-bindings: firmware: qcom,scm: Document SDI disable Krzysztof Kozlowski
2023-08-21 19:31 ` Rob Herring
2023-08-21 19:35 ` Robert Marko
2023-08-21 19:44 ` Brian Norris
2023-08-21 20:39 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815140030.1068590-3-robimarko@gmail.com \
--to=robimarko@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gurus@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).