[PATCH 0/3] SDM670 CPU frequency scaling: dtschema fixes

[PATCH 0/3] SDM670 CPU frequency scaling: dtschema fixes

[Richard Acayan]

This adds appropriate compatible strings to pass bindings checks.

Patch 1/3 is preserved from a previous series, as it was not applied to
linux-next yet and I wasn't notified that it was applied anywhere else:
https://lore.kernel.org/linux-arm-msm/20230724214209.208699-7-mailingradian@gmail.com/

Richard Acayan (3):
  dt-bindings: interconnect: add SDM670 OSM L3 compatible
  dt-bindings: cpufreq: cpufreq-qcom-hw: add SDM670 compatible
  arm64: dts: qcom: sdm670: add specific cpufreq compatible

 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml  | 1 +
 Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 +
 arch/arm64/boot/dts/qcom/sdm670.dtsi                            | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.41.0

[PATCH 1/3] dt-bindings: interconnect: add SDM670 OSM L3 compatible

[Richard Acayan]

Add the compatible for the OSM L3 interconnect used in the Snapdragon
670.

Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
index 9d0a98d77ae9..21dae0b92819 100644
--- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
+++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
@@ -21,6 +21,7 @@ properties:
           - enum:
               - qcom,sc7180-osm-l3
               - qcom,sc8180x-osm-l3
+              - qcom,sdm670-osm-l3
               - qcom,sdm845-osm-l3
               - qcom,sm6350-osm-l3
               - qcom,sm8150-osm-l3
-- 
2.41.0

[PATCH 2/3] dt-bindings: cpufreq: cpufreq-qcom-hw: add SDM670 compatible

[Richard Acayan]

The bindings for Qualcomm CPU frequency have a compatible for each SoC.
Add the compatible for SDM670.

Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
index a6b3bb8fdf33..764a1589f8a2 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
@@ -23,6 +23,7 @@ properties:
           - enum:
               - qcom,qcm2290-cpufreq-hw
               - qcom,sc7180-cpufreq-hw
+              - qcom,sdm670-cpufreq-hw
               - qcom,sdm845-cpufreq-hw
               - qcom,sm6115-cpufreq-hw
               - qcom,sm6350-cpufreq-hw
-- 
2.41.0

[PATCH 3/3] arm64: dts: qcom: sdm670: add specific cpufreq compatible

[Richard Acayan]

The bindings for the CPU frequency scaling driver require a specific
compatible for the SoC. Add the compatible.

Fixes: 0c665213d126 ("arm64: dts: qcom: sdm670: add cpu frequency scaling")
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
 arch/arm64/boot/dts/qcom/sdm670.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64/boot/dts/qcom/sdm670.dtsi
index 0ac39d3d68ca..77ec0de08c2c 100644
--- a/arch/arm64/boot/dts/qcom/sdm670.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm670.dtsi
@@ -1520,7 +1520,7 @@ osm_l3: interconnect@17d41000 {
 		};
 
 		cpufreq_hw: cpufreq@17d43000 {
-			compatible = "qcom,cpufreq-hw";
+			compatible = "qcom,sdm670-cpufreq-hw", "qcom,cpufreq-hw";
 			reg = <0 0x17d43000 0 0x1400>, <0 0x17d45800 0 0x1400>;
 			reg-names = "freq-domain0", "freq-domain1";
 
-- 
2.41.0

Re: [PATCH 2/3] dt-bindings: cpufreq: cpufreq-qcom-hw: add SDM670 compatible

[Krzysztof Kozlowski]

On 16/08/2023 00:31, Richard Acayan wrote:
> The bindings for Qualcomm CPU frequency have a compatible for each SoC.

Drop this sentence, it is not relevant.

> Add the compatible for SDM670.
> 
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> ---
>  Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 +
>  1 file changed, 1 insertion(+)

You missed to update rest of the file.

Best regards,
Krzysztof

Re: [PATCH 3/3] arm64: dts: qcom: sdm670: add specific cpufreq compatible

[Krzysztof Kozlowski]

On 16/08/2023 00:31, Richard Acayan wrote:
> The bindings for the CPU frequency scaling driver require a specific
> compatible for the SoC. Add the compatible.
> 
> Fixes: 0c665213d126 ("arm64: dts: qcom: sdm670: add cpu frequency scaling")
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>

There was no such compatible in your series, so backporting only this is
not enough.


Best regards,
Krzysztof

Re: [PATCH 1/3] dt-bindings: interconnect: add SDM670 OSM L3 compatible

[Richard Acayan]

On Tue, Aug 15, 2023 at 06:31:10PM -0400, Richard Acayan wrote:
> Add the compatible for the OSM L3 interconnect used in the Snapdragon
> 670.
>
> Signed-off-by: Richard Acayan <mailingradian@gmail.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

The subject line should be "dt-bindings: interconnect: OSM L3: add
SDM670 compatible" to follow the same format as other patches to this
file.

>  Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
> index 9d0a98d77ae9..21dae0b92819 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml
> @@ -21,6 +21,7 @@ properties:
>            - enum:
>                - qcom,sc7180-osm-l3
>                - qcom,sc8180x-osm-l3
> +              - qcom,sdm670-osm-l3
>                - qcom,sdm845-osm-l3
>                - qcom,sm6350-osm-l3
>                - qcom,sm8150-osm-l3
> -- 
> 2.41.0
>