From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 553F3C04A6A for ; Wed, 16 Aug 2023 14:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343718AbjHPOjQ (ORCPT ); Wed, 16 Aug 2023 10:39:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343753AbjHPOiy (ORCPT ); Wed, 16 Aug 2023 10:38:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5F2E2D41; Wed, 16 Aug 2023 07:38:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 96D6863FD9; Wed, 16 Aug 2023 14:38:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42698C433C8; Wed, 16 Aug 2023 14:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692196692; bh=wAA3WePHJSoHVgxkU3KiZytlFD8F7FCW7Hbk/uZSCGo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NVgNgu63cFaxLiCNMANcOgomGY8QLmO2yCAxa2dxkePn/NytnJ+DTy9SWCLuaJfW+ +L8tjYp4N/Fm8dLgNAgPzWDGFG75XFs2EyOG4lUXHIlV2HEDjvdsH+hBrT1vm7K8fq HZ1DRuI15yUS+YZht81PvOGYAEqlPyOHJS3ENImGY4pyn2tuERq95nJimDaokPLow8 x5uza3VFZ4xkpk52basr8ay5Jm6RpO6XyR60P9+vG81EBelMkPoQQSJnuNyIM3YCPh 5WxR+xGZDQbH8A035fcewFXyxwHS7M8jva14J2nauC4v1yPvFDkxGaCSvQ16Uycjzc sxtvpoxnDuMTA== Date: Wed, 16 Aug 2023 15:38:07 +0100 From: Conor Dooley To: Mihai.Sain@microchip.com Cc: claudiu.beznea@tuxon.dev, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Nicolas.Ferre@microchip.com, Cristian.Birsan@microchip.com, alexandre.belloni@bootlin.com, andre.przywara@arm.com, Jerry.Ray@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andrei.Simion@microchip.com Subject: Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board Message-ID: <20230816-asleep-move-ab8746612698@spud> References: <20230804101043.4063-1-mihai.sain@microchip.com> <127fc712-d924-f27f-5449-33385e89d6c3@tuxon.dev> <98d01db3-3eba-0731-0dd9-4310ed293bd6@tuxon.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TC0LRDS6Pz+cbGoi" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --TC0LRDS6Pz+cbGoi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 16, 2023 at 09:05:19AM +0000, Mihai.Sain@microchip.com wrote: > Hi Claudiu, >=20 > ---------------------- >=20 > Hi, Mihai, >=20 > On 8/10/23 09:47, Mihai.Sain@microchip.com wrote: > >> +&i2s0 { > >> + pinctrl-names =3D "default"; > >> + pinctrl-0 =3D <&pinctrl_i2s0_default>; > >> + status =3D "okay"; > > I see no sound bindings on DT. Is there any reason for having this here? > > # i2s0 bus is wired to RPi 40-pin connector. I want to have this node a= nd its pinctrl here. > > # i2c1, flx4-spi, pwm0, uart1 are also wired to Rpi connector, and are = defined here. > > # The same logic we apply also for mikroBUS sockets: i2c, pwm, spi and = uart nodes are defined here. > > >=20 > Can you use it (either with user space tools or other kernel consumers) w= /o additional device tree bindings? > # Yes. We have added in dt-overlay the codec which uses the i2s0 and i2c1= nodes and pinctrls. Can you please fix your mail client so that your replies are properly quoted? I don't understand who is saying what here. --TC0LRDS6Pz+cbGoi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZNzfTgAKCRB4tDGHoIJi 0mskAQDqB7yvGCNZL5HLPqbFd4miuOsz8BFLD9vxbjY5k+x9XAD+NKe0JvyQzcBk MW+H0TBbpXXo7VMYE0ttbiSKddZE1QI= =X1ZD -----END PGP SIGNATURE----- --TC0LRDS6Pz+cbGoi--