Re: [PATCH v2 1/7] dt-bindings: loongarch: Add CPU bindings for LoongArch

[Conor Dooley <conor.dooley@microchip.com>]

[-- Attachment #1: Type: text/plain, Size: 2343 bytes --]

On Wed, Aug 16, 2023 at 02:37:43PM +0800, Binbin Zhou wrote:
> Hi Conor:
> 
> Thanks for the reply.
> 
> On Tue, Aug 15, 2023 at 10:07 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Tue, Aug 15, 2023 at 04:50:46PM +0800, Binbin Zhou wrote:
> > > Add the available CPUs in LoongArch binding with DT schema format using
> > > json-schema.
> > >
> > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > > ---
> > >  .../devicetree/bindings/loongarch/cpus.yaml   | 60 +++++++++++++++++++
> > >  1 file changed, 60 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/loongarch/cpus.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/loongarch/cpus.yaml b/Documentation/devicetree/bindings/loongarch/cpus.yaml
> > > new file mode 100644
> > > index 000000000000..ee3fe09e53dc
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/loongarch/cpus.yaml
> > > @@ -0,0 +1,60 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/loongarch/cpus.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: LoongArch CPUs
> > > +
> > > +maintainers:
> > > +  - Binbin Zhou <zhoubinbin@loongson.cn>
> > > +
> > > +description:
> > > +  This document describes the list of LoongArch CPU cores that support FDT,
> > > +  it describe the layout of CPUs in a system through the "cpus" node.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - loongson,la264
> > > +      - loongson,la364
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  clocks:
> > > +    maxItems: 1
> > > +
> > > +  device_type: true
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +  - clocks
> > > +
> > > +additionalProperties: false
> >
> > How come you didn't add the reference to the common cpu schema?
> 
> Do you mean:
> allOf:
>   - $ref: /schemas/cpu.yaml#

Yes.

> Sorry, the file started out as a copy of mips/arm and then the related
> content, really didn't notice that part.
> I will check again.
> 
> Also, shouldn't "additionalProperties: false" be changed to
> "unevaluatedProperties: false" synchronously?

To actually make use of the properties from there, yeah.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]