Re: [PATCH v2 2/7] dt-bindings: loongarch: Add Loongson SoC boards compatibles

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2755 bytes --]

On Thu, Aug 17, 2023 at 09:44:16AM +0100, Conor Dooley wrote:
> On Thu, Aug 17, 2023 at 02:16:13PM +0800, Binbin Zhou wrote:
> > Hi Conor:
> > 
> > Thanks for your reply.
> > 
> > On Tue, Aug 15, 2023 at 10:13 PM Conor Dooley <conor@kernel.org> wrote:
> > >
> > > On Tue, Aug 15, 2023 at 04:50:47PM +0800, Binbin Zhou wrote:
> > > > Add Loongson SoC boards binding with DT schema format using json-schema.
> > > >
> > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> > > > ---
> > > >  .../devicetree/bindings/loongarch/boards.yaml | 34 +++++++++++++++++++
> > > >  1 file changed, 34 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/loongarch/boards.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/loongarch/boards.yaml b/Documentation/devicetree/bindings/loongarch/boards.yaml
> > > > new file mode 100644
> > > > index 000000000000..5092314b7a52
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/loongarch/boards.yaml
> > > > @@ -0,0 +1,34 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/loongarch/boards.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Loongson SoC-based boards
> > > > +
> > > > +maintainers:
> > > > +  - Binbin Zhou <zhoubinbin@loongson.cn>
> > > > +
> > > > +properties:
> > > > +  $nodename:
> > > > +    const: '/'
> > > > +  compatible:
> > > > +    oneOf:
> > > > +      - description: Loongson-2K0500 processor based boards
> > > > +        items:
> > > > +          - const: loongson,ls2k0500-ref
> > > > +          - const: loongson,ls2k0500
> > > > +
> > > > +      - description: Loongson-2K1000 processor based boards
> > > > +        items:
> > > > +          - const: loongson,ls2k1000-ref
> > > > +          - const: loongson,ls2k1000
> > > > +
> > > > +      - description: Loongson-2K2000 processor based boards
> > > > +        items:
> > > > +          - const: loongson,ls2k2000-ref
> > > > +          - const: loongson,ls2k2000
> > >
> > > Do all of these SoCs just have a single reference/dev board?
> > 
> > Yes, I have development boards for each Soc on hand now, and it has a
> > relatively complete interface. My original idea was to use the
> > development boards as examples to show you the Loongson-2K Soc.
> > I'm sure more boards will be added in the future.
> 
> My reason for asking was that "-ref" is quite generic, but if there is
> only one reference board produced by Loongson that's not a problem.

Whoops, I forgot to add this:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]