From: Patrick Rudolph <patrick.rudolph@9elements.com>
To: Peter Rosin <peda@axentia.se>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: naresh.solanki@9elements.com,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v15 1/4] dt-bindings: i2c: pca954x: Correct interrupt support
Date: Thu, 17 Aug 2023 09:10:50 +0200 [thread overview]
Message-ID: <20230817071056.2125679-2-patrick.rudolph@9elements.com> (raw)
In-Reply-To: <20230817071056.2125679-1-patrick.rudolph@9elements.com>
Only some of the PCA954x compatible ICs have interrupt
capability, but the binding advertises it on all ICs.
Sync the dt-binding with the driver and only advertise it on:
- nxp,pca9542
- nxp,pca9543
- nxp,pca9544
- nxp,pca9545
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../bindings/i2c/i2c-mux-pca954x.yaml | 23 +++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
index 9f1726d0356b..e5c1070903ef 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.yaml
@@ -12,9 +12,6 @@ maintainers:
description:
The binding supports NXP PCA954x and PCA984x I2C mux/switch devices.
-allOf:
- - $ref: /schemas/i2c/i2c-mux.yaml#
-
properties:
compatible:
oneOf:
@@ -63,6 +60,24 @@ required:
- compatible
- reg
+allOf:
+ - $ref: /schemas/i2c/i2c-mux.yaml#
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - nxp,pca9542
+ - nxp,pca9543
+ - nxp,pca9544
+ - nxp,pca9545
+ then:
+ properties:
+ interrupts: false
+ "#interrupt-cells": false
+ interrupt-controller: false
+
unevaluatedProperties: false
examples:
@@ -74,7 +89,7 @@ examples:
#size-cells = <0>;
i2c-mux@74 {
- compatible = "nxp,pca9548";
+ compatible = "nxp,pca9545";
#address-cells = <1>;
#size-cells = <0>;
reg = <0x74>;
--
2.41.0
next prev parent reply other threads:[~2023-08-17 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 7:10 [PATCH v15 0/4] Add support for Maxim MAX735x/MAX736x variants Patrick Rudolph
2023-08-17 7:10 ` Patrick Rudolph [this message]
2023-08-17 16:21 ` [PATCH v15 1/4] dt-bindings: i2c: pca954x: Correct interrupt support Peter Rosin
2023-08-23 21:15 ` Wolfram Sang
2023-08-23 21:21 ` Wolfram Sang
2023-08-17 7:10 ` [PATCH v15 2/4] dt-bindings: i2c: Add Maxim MAX735x/MAX736x variants Patrick Rudolph
2023-08-17 16:22 ` Peter Rosin
2023-08-23 21:15 ` Wolfram Sang
2023-08-17 16:21 ` [PATCH v15 0/4] Add support for " Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817071056.2125679-2-patrick.rudolph@9elements.com \
--to=patrick.rudolph@9elements.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).