From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
pascal Paillet <p.paillet@foss.st.com>,
Linus Walleij <linus.walleij@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator
Date: Fri, 18 Aug 2023 16:37:04 +0100 [thread overview]
Message-ID: <20230818153704.GW986605@google.com> (raw)
In-Reply-To: <fa75415c-89fa-451b-2418-9f2fd6fab93f@linaro.org>
On Fri, 18 Aug 2023, Krzysztof Kozlowski wrote:
> On 17/08/2023 13:52, Lee Jones wrote:
> > On Tue, 25 Jul 2023, Krzysztof Kozlowski wrote:
> >
> >> On 25/07/2023 14:37, Krzysztof Kozlowski wrote:
> >>> Each regulator node, which references common regulator.yaml schema,
> >>> should disallow additional or unevaluated properties. Otherwise
> >>> mistakes in properties will go unnoticed. unevaluatedProperties:false
> >>> requires listing existing properties (present in example and in other
> >>> regulators of this device).
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> ---
> >>> Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 10 ++++++++++
> >>> 1 file changed, 10 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> >>> index 97c61097f9e2..1a1ced489ef7 100644
> >>> --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> >>> +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> >>> @@ -189,6 +189,16 @@ properties:
> >>>
> >>> "^(buck[1-4]|ldo[1-6]|boost|vref_ddr|pwr_sw[1-2])$":
> >>> $ref: ../regulator/regulator.yaml
> >>> + unevaluatedProperties: false
> >>> +
> >>> + properties:
> >>> + interrupts:
> >>> + maxItems: 1
> >>> +
> >>> + st,mask-reset:
> >>> + description: mask reset for this regulator, the regulator configuration
> >>> + is maintained during pmic reset.
> >>> + $ref: /schemas/types.yaml#/definitions/flag
> >>
> >> After further testing I see this patch is wrong. There are already
> >> buck[1-4] entries, so this is duplicating things. I will send v2.
> >
> > Are you still planning on resending this set?
> >
>
> I already did and you took it. Email subject was different, though:
Understood, thanks for the clarification.
> https://lore.kernel.org/all/20230726065633.74924-1-krzysztof.kozlowski@linaro.org/
> Best regards,
> Krzysztof
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-08-18 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 12:37 [PATCH 1/2] dt-bindings: mfd: st,stpmic1: Add missing unevaluatedProperties for each regulator Krzysztof Kozlowski
2023-07-25 12:37 ` [PATCH 2/2] dt-bindings: mfd: stericsson,db8500-prcmu: " Krzysztof Kozlowski
2023-08-07 12:33 ` Linus Walleij
2023-07-25 14:45 ` [PATCH 1/2] dt-bindings: mfd: st,stpmic1: " Krzysztof Kozlowski
2023-08-17 11:52 ` Lee Jones
2023-08-18 9:00 ` Krzysztof Kozlowski
2023-08-18 15:37 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818153704.GW986605@google.com \
--to=lee@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.paillet@foss.st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).