devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: giometti@enneenne.com, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] dt-bindings: pps: pps-gpio: Convert to yaml
Date: Fri, 18 Aug 2023 11:24:32 -0500	[thread overview]
Message-ID: <20230818162432.GA118441-robh@kernel.org> (raw)
In-Reply-To: <20230809110812.2058428-1-festevam@gmail.com>

On Wed, Aug 09, 2023 at 08:08:12AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Convert from pps-gpio.txt to pps-gpio.yaml to allow schema validation.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../devicetree/bindings/pps/pps-gpio.txt      | 30 ------------
>  .../devicetree/bindings/pps/pps-gpio.yaml     | 46 +++++++++++++++++++
>  2 files changed, 46 insertions(+), 30 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/pps/pps-gpio.txt
>  create mode 100644 Documentation/devicetree/bindings/pps/pps-gpio.yaml
> 
> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt b/Documentation/devicetree/bindings/pps/pps-gpio.txt
> deleted file mode 100644
> index 9012a2a02e14..000000000000
> --- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -Device-Tree Bindings for a PPS Signal on GPIO
> -
> -These properties describe a PPS (pulse-per-second) signal connected to
> -a GPIO pin.
> -
> -Required properties:
> -- compatible: should be "pps-gpio"
> -- gpios: one PPS GPIO in the format described by ../gpio/gpio.txt
> -
> -Additional required properties for the PPS ECHO functionality:
> -- echo-gpios: one PPS ECHO GPIO in the format described by ../gpio/gpio.txt
> -- echo-active-ms: duration in ms of the active portion of the echo pulse
> -
> -Optional properties:
> -- assert-falling-edge: when present, assert is indicated by a falling edge
> -                       (instead of by a rising edge)
> -
> -Example:
> -	pps {
> -		pinctrl-names = "default";
> -		pinctrl-0 = <&pinctrl_pps>;
> -
> -		gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> -		assert-falling-edge;
> -
> -		echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
> -		echo-active-ms = <100>;
> -
> -		compatible = "pps-gpio";
> -	};
> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.yaml b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> new file mode 100644
> index 000000000000..801fd2720080
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pps/pps-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PPS Signal via GPIO
> +
> +maintainers:
> +  - Fabio Estevam <festevam@gmail.com>
> +
> +properties:
> +  compatible:
> +    const: pps-gpio
> +
> +  gpios:
> +    description: The GPIO that provides the PPS signal.

maxItems: 1

> +
> +  echo-gpios:
> +    description: The GPIO that provides the PPS ECHO signal.

maxItems: 1

> +
> +  echo-active-ms:
> +    description: Duration in ms of the active portion of the echo pulse.
> +
> +  assert-falling-edge:
> +    description: Indicates a falling edge assert, when present. Rising edge if absent.

type: boolean

> +
> +required:
> +  - compatible
> +  - gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +      #include <dt-bindings/gpio/gpio.h>
> +
> +      pps {
> +          compatible = "pps-gpio";
> +          pinctrl-names = "default";
> +          pinctrl-0 = <&pinctrl_pps>;
> +          gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> +          assert-falling-edge;
> +          echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
> +          echo-active-ms = <100>;
> +      };
> -- 
> 2.34.1
> 

      parent reply	other threads:[~2023-08-18 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 11:08 [PATCH] dt-bindings: pps: pps-gpio: Convert to yaml Fabio Estevam
2023-08-09 12:32 ` Rodolfo Giometti
2023-08-18 16:24 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818162432.GA118441-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=giometti@enneenne.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).