devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Protsenko <semen.protsenko@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: JaeHun Jung <jh0801.jung@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Heiko Stuebner <heiko@sntech.de>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: [PATCH 5/8] phy: exynos5-usbdrd: Add 26MHz ref clk support
Date: Fri, 18 Aug 2023 22:17:28 -0500	[thread overview]
Message-ID: <20230819031731.22618-6-semen.protsenko@linaro.org> (raw)
In-Reply-To: <20230819031731.22618-1-semen.protsenko@linaro.org>

Modern Exynos chips (like Exynos850) might have 26 MHz OSCCLK external
clock, which is also used as a PHY reference clock. For some USB PHY
controllers (e.g USB DRD PHY block on Exynos850) there is no need to set
the refclk frequency at all (and corresponding bits in CLKRSTCTRL[7:5]
are marked RESERVED), so that value won't be set in the driver. But
even in that case, 26 MHz support still has to be added, otherwise
exynos5_rate_to_clk() fails, which leads in turn to probe error.

Add the correct value for 26MHz refclk to make it possible to add
support for new Exynos USB DRD PHY controllers.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
index 1ece4a1a1a6e..41508db87b9b 100644
--- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
+++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
@@ -30,6 +30,7 @@
 #define EXYNOS5_FSEL_19MHZ2		0x3
 #define EXYNOS5_FSEL_20MHZ		0x4
 #define EXYNOS5_FSEL_24MHZ		0x5
+#define EXYNOS5_FSEL_26MHZ		0x82
 #define EXYNOS5_FSEL_50MHZ		0x7
 
 /* Exynos5: USB 3.0 DRD PHY registers */
@@ -244,6 +245,9 @@ static unsigned int exynos5_rate_to_clk(unsigned long rate, u32 *reg)
 	case 24 * MHZ:
 		*reg = EXYNOS5_FSEL_24MHZ;
 		break;
+	case 26 * MHZ:
+		*reg = EXYNOS5_FSEL_26MHZ;
+		break;
 	case 50 * MHZ:
 		*reg = EXYNOS5_FSEL_50MHZ;
 		break;
-- 
2.39.2


  parent reply	other threads:[~2023-08-19  3:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-19  3:17 [PATCH 0/8] arm64: exynos: Enable USB for E850-96 board Sam Protsenko
2023-08-19  3:17 ` [PATCH 1/8] dt-bindings: usb: samsung,exynos-dwc3: Add Exynos850 support Sam Protsenko
2023-08-19  7:09   ` Krzysztof Kozlowski
2023-08-19  3:17 ` [PATCH 2/8] dt-bindings: phy: samsung,usb3-drd-phy: " Sam Protsenko
2023-08-19  7:11   ` Krzysztof Kozlowski
2023-08-22 14:09     ` Vinod Koul
2023-08-19  3:17 ` [PATCH 3/8] usb: dwc3: exynos: Add support for Exynos850 variant Sam Protsenko
2023-08-19  7:11   ` Krzysztof Kozlowski
2023-08-19  3:17 ` [PATCH 4/8] phy: exynos5-usbdrd: Make it possible to pass custom phy ops Sam Protsenko
2023-08-19  7:12   ` Krzysztof Kozlowski
2023-08-19  3:17 ` Sam Protsenko [this message]
2023-08-19  7:41   ` [PATCH 5/8] phy: exynos5-usbdrd: Add 26MHz ref clk support Krzysztof Kozlowski
2023-08-19  3:17 ` [PATCH 6/8] phy: exynos5-usbdrd: Add Exynos850 support Sam Protsenko
2023-08-19  8:32   ` Krzysztof Kozlowski
2023-08-19  3:17 ` [PATCH 7/8] arm64: dts: exynos: Enable USB in Exynos850 Sam Protsenko
2023-08-19  8:33   ` Krzysztof Kozlowski
2023-08-19  3:17 ` [PATCH 8/8] arm64: dts: exynos: Enable USB support on E850-96 board Sam Protsenko
2023-08-19  8:36   ` Krzysztof Kozlowski
2023-08-22 14:29 ` (subset) [PATCH 0/8] arm64: exynos: Enable USB for " Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230819031731.22618-6-semen.protsenko@linaro.org \
    --to=semen.protsenko@linaro.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=jh0801.jung@samsung.com \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mkl@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).