From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E5BEE4993 for ; Mon, 21 Aug 2023 14:06:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235525AbjHUOG2 (ORCPT ); Mon, 21 Aug 2023 10:06:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232224AbjHUOG2 (ORCPT ); Mon, 21 Aug 2023 10:06:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09F4BCE; Mon, 21 Aug 2023 07:06:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9220563520; Mon, 21 Aug 2023 14:06:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64BCCC433C7; Mon, 21 Aug 2023 14:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692626785; bh=jskCnmfcQS5EFi06b4333cYtIRY89QRwP0GiuGw2lz8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OPZBm3I8NJHoZf7lNV4qSpa5xDGS9Hj6d9J+HQ41DwnpKpgECp2/T0IvOCJNncVya KUOCkzttOoxWUVf7H+69kgVBsKZOKqz22xOIyUo7v+iP0131btrysBz0SMywPcyYhE r1LIquZBVqSczHC4FriOFXStKLlwWUx/900G6VzQA/QFZ5AJ+cAqk8rJs5nNpuXjH/ tj3V7Cvm/SvDWo97FwWn3Xcjh5X78b0j+JKRlXkGx1lUIhLdZYMK68JF7e8T4ZvBiR 5QCv5J7Z3bgb6+r7F0T8wA32Q/jw4GdjpCsRAZe18V0ZmeVy9c/BFOAhNVhnSzL53g +nsYCO0dsNUdA== Received: (nullmailer pid 1479558 invoked by uid 1000); Mon, 21 Aug 2023 14:06:22 -0000 Date: Mon, 21 Aug 2023 09:06:22 -0500 From: Rob Herring To: Adam Ford Cc: Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Shengjiu Wang , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ASoC: dt-bindings: fsl_easrc: Add support for imx8mp-easrc Message-ID: <20230821140622.GA1473812-robh@kernel.org> References: <20230820175655.206723-1-aford173@gmail.com> <6089b46d-a580-af52-0cac-84b46fe11e6c@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Aug 20, 2023 at 04:05:16PM -0500, Adam Ford wrote: > On Sun, Aug 20, 2023 at 3:33 PM Krzysztof Kozlowski > wrote: > > > > On 20/08/2023 22:32, Krzysztof Kozlowski wrote: > > > On 20/08/2023 19:56, Adam Ford wrote: > > >> The i.MX8MP appears to have the same easrc support as the Nano, so > > >> add imx8mp as an option with a fallback to imx8mn. > > >> > > >> Signed-off-by: Adam Ford > > >> > > >> diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > >> index bdde68a1059c..2d53b3b10f2c 100644 > > >> --- a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > >> +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml > > >> @@ -14,7 +14,11 @@ properties: > > >> pattern: "^easrc@.*" > > >> > > >> compatible: > > >> - const: fsl,imx8mn-easrc > > >> + oneOf: > > >> + - items: > > >> + - enum: > > >> + - fsl,imx8mp-easrc > > >> + - const: fsl,imx8mn-easrc > > > > > > You need here also const for fsl,imx8mn-easrc, otherwise you do not > > > allow it alone. Test it for fsl,imx8mn-easrc DTS - you will notice warnings. > > > > Actually, I see now Rob's report... you did not have to test DTS even. > > It was enough to test your change and this test was missing :(. Please > > test your changes before sending. > > For what it's worth, I did run 'make dt_binding_check', but I didn't > run it with the extra flags from Rob's e-mail. The tool didn't return > any errors. The error is not related to the '-m' (undocumented compatible) warning. It is as Krzysztof said. Rob