From: Rob Herring <robh@kernel.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm: dts: qcom: Add the rpmhpd header
Date: Mon, 21 Aug 2023 10:14:30 -0500 [thread overview]
Message-ID: <20230821151430.GA1643924-robh@kernel.org> (raw)
In-Reply-To: <1690781104-2290-3-git-send-email-quic_rohiagar@quicinc.com>
On Mon, Jul 31, 2023 at 10:55:02AM +0530, Rohit Agarwal wrote:
> Add the rpmhpd header having the definition of the regulator levels
> for Qualcomm SoCs.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 1 +
> arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> index df3cd9c..8ffb2a0 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi
> @@ -12,6 +12,7 @@
> #include <dt-bindings/interconnect/qcom,sdx55.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/qcom-rpmpd.h>
> +#include <dt-bindings/power/qcom,rpmhpd.h>
If patch 4 isn't applied, aren't you going to get warnings about
redefining the defines since you have them twice?
> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>
> / {
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
> index 1a35830..f990f5d 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
> @@ -11,6 +11,7 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/qcom-rpmpd.h>
> +#include <dt-bindings/power/qcom,rpmhpd.h>
> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> #include <dt-bindings/interconnect/qcom,sdx65.h>
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2023-08-21 15:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 5:25 [PATCH 0/4] Add the rpmhpd header in the Qualcomm SoC Rohit Agarwal
2023-07-31 5:25 ` [PATCH 1/4] dt-bindings: power: qcom,rpmhpd: Add the regulator levels for RPMHPD Rohit Agarwal
2023-07-31 5:25 ` [PATCH 2/4] arm: dts: qcom: Add the rpmhpd header Rohit Agarwal
2023-08-21 15:14 ` Rob Herring [this message]
2023-08-22 6:27 ` Rohit Agarwal
2023-07-31 5:25 ` [PATCH 3/4] arm64: " Rohit Agarwal
2023-08-21 15:11 ` Rob Herring
2023-08-22 6:30 ` Rohit Agarwal
2023-07-31 5:25 ` [PATCH 4/4] dt-bindings: power: qcom,rpmpd: Remove unused SoC specific bindings Rohit Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821151430.GA1643924-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rohiagar@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).