From: Trevor Woerner <twoerner@gmail.com>
To: Robert Nelson <robertcnelson@gmail.com>
Cc: drew@beagleboard.org, "Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 1/4] ARM: dts: am335x-pocketbeagle: update LED information
Date: Tue, 22 Aug 2023 10:37:21 -0400 [thread overview]
Message-ID: <20230822143721.GA8051@localhost> (raw)
In-Reply-To: <CAOCHtYgdxeoOvTcFjwB=iqLD5K4JzeoRF8zeQPzM_1nLh5ReYA@mail.gmail.com>
On Mon 2023-08-21 @ 10:36:34 AM, Robert Nelson wrote:
> On Sun, Aug 20, 2023 at 5:24 AM Trevor Woerner <twoerner@gmail.com> wrote:
> >
> > The "label" property is deprecated. Replace the "label" property with
> > "color" and "description" properties.
> >
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> > ---
> > arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 13 +++++++++----
> > 1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> > index 5dfe4d4bab93..1c11245f6864 100644
> > --- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> > +++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> > @@ -8,6 +8,7 @@
> >
> > #include "am33xx.dtsi"
> > #include "am335x-osd335x-common.dtsi"
> > +#include <dt-bindings/leds/common.h>
> >
> > / {
> > model = "TI AM335x PocketBeagle";
> > @@ -24,28 +25,32 @@ leds {
> > compatible = "gpio-leds";
> >
> > led-usr0 {
> > - label = "beaglebone:green:usr0";
> > + color = <LED_COLOR_ID_BLUE>;
> > + function = LED_FUNCTION_HEARTBEAT;
>
> So some background, while the LED are not Green, and this is not the BeagleBone.
>
> We used these specific labels to keep all user documents going back to
> the original BeagleBone (white) (with 3.8.x kernel), the same so users
> could easily blink an led from user-space even on newer boards.
>
> So it became our un-official abi for new users for the BeagleBoard
> family of devices..
>
> It's even what we do on the BeaglePlay..
>
> https://git.beagleboard.org/beagleboard/BeagleBoard-DeviceTrees/-/blob/v5.10.x-ti-unified/src/arm64/k3-am625-beagleplay.dts#L179-217
Thanks for the background. I've sent a v3 which simply adds the "color" and
"function" properties but leaves the "label" property intact.
next prev parent reply other threads:[~2023-08-22 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 15:10 [PATCH v2 0/4] pocketbeagle device tree updates Trevor Woerner
2023-08-18 15:10 ` [PATCH v2 1/4] ARM: dts: am335x-pocketbeagle: update LED information Trevor Woerner
2023-08-21 15:36 ` Robert Nelson
2023-08-22 14:37 ` Trevor Woerner [this message]
2023-08-18 15:10 ` [PATCH v2 2/4] ARM: dts: am335x-pocketbeagle: remove dependency cycle Trevor Woerner
2023-08-18 15:10 ` [PATCH v2 3/4] ARM: dts: am335x-pocketbeagle: enable pru Trevor Woerner
2023-08-18 15:10 ` [PATCH v2 4/4] ARM: dts: am335x-pocketbeagle: add missing GPIO mux Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822143721.GA8051@localhost \
--to=twoerner@gmail.com \
--cc=bcousson@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drew@beagleboard.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).