devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alexey Brodkin <abrodkin@synopsys.com>, Vineet Gupta <vgupta@kernel.org>
Cc: devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arc: Explicitly include correct DT includes
Date: Wed, 23 Aug 2023 12:00:25 -0500	[thread overview]
Message-ID: <20230823170025.GA2470216-robh@kernel.org> (raw)
In-Reply-To: <20230714173949.4038981-1-robh@kernel.org>

On Fri, Jul 14, 2023 at 11:39:49AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/arc/plat-axs10x/axs10x.c | 1 -
>  1 file changed, 1 deletion(-)

Ping!

> 
> diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> index b821df7b0089..1feb990a56bc 100644
> --- a/arch/arc/plat-axs10x/axs10x.c
> +++ b/arch/arc/plat-axs10x/axs10x.c
> @@ -6,7 +6,6 @@
>   */
>  
>  #include <linux/of_fdt.h>
> -#include <linux/of_platform.h>
>  #include <linux/libfdt.h>
>  
>  #include <asm/asm-offsets.h>
> -- 
> 2.40.1
> 

  reply	other threads:[~2023-08-23 17:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 17:39 [PATCH] arc: Explicitly include correct DT includes Rob Herring
2023-08-23 17:00 ` Rob Herring [this message]
2023-08-23 20:43   ` Alexey Brodkin
2023-08-24  1:04   ` Vineet Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230823170025.GA2470216-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=abrodkin@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-snps-arc@lists.infradead.org \
    --cc=vgupta@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).