From: Neil Armstrong <neil.armstrong@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Om Prakash Singh" <quic_omprsing@quicinc.com>
Subject: [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450"
Date: Thu, 24 Aug 2023 13:33:20 +0200 [thread overview]
Message-ID: <20230824-topic-sm8550-rng-v2-1-dfcafbb16a3e@linaro.org> (raw)
In-Reply-To: <20230824-topic-sm8550-rng-v2-0-dfcafbb16a3e@linaro.org>
This reverts commit b9296bb41275 ("dt-bindings: crypto: qcom,prng: Add SM8450"),
since the RNG HW on the SM8450 SoC is in fact a True Random Number Generator,
a more appropriate compatible should be instead as reported at [1].
[1] https://lore.kernel.org/all/20230818161720.3644424-1-quic_omprsing@quicinc.com/
Suggested-by: Om Prakash Singh <quic_omprsing@quicinc.com>
Suggested-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
.../devicetree/bindings/crypto/qcom,prng.yaml | 24 +++++-----------------
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index 36b0ebd9a44b..bb42f4588b40 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -11,13 +11,9 @@ maintainers:
properties:
compatible:
- oneOf:
- - enum:
- - qcom,prng # 8916 etc.
- - qcom,prng-ee # 8996 and later using EE
- - items:
- - const: qcom,sm8450-prng-ee
- - const: qcom,prng-ee
+ enum:
+ - qcom,prng # 8916 etc.
+ - qcom,prng-ee # 8996 and later using EE
reg:
maxItems: 1
@@ -32,18 +28,8 @@ properties:
required:
- compatible
- reg
-
-allOf:
- - if:
- not:
- properties:
- compatible:
- contains:
- const: qcom,sm8450-prng-ee
- then:
- required:
- - clocks
- - clock-names
+ - clocks
+ - clock-names
additionalProperties: false
--
2.34.1
next prev parent reply other threads:[~2023-08-24 11:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 11:33 [PATCH v2 0/7] arm64: qcom: sm8550: enable RNG Neil Armstrong
2023-08-24 11:33 ` Neil Armstrong [this message]
2023-08-24 11:48 ` [PATCH v2 1/7] Revert "dt-bindings: crypto: qcom,prng: Add SM8450" Konrad Dybcio
2023-08-24 21:29 ` Rob Herring
2023-08-28 6:25 ` Om Prakash Singh
2023-08-28 8:01 ` Neil Armstrong
2023-08-25 11:07 ` Herbert Xu
2023-08-24 11:33 ` [PATCH v2 2/7] Revert "arm64: dts: qcom: sm8450: Add PRNG" Neil Armstrong
2023-08-24 11:48 ` Konrad Dybcio
2023-08-24 11:33 ` [PATCH v2 3/7] dt-bindings: crypto: qcom,prng: document that RNG on SM8450 is a TRNG Neil Armstrong
2023-08-28 4:57 ` Om Prakash Singh
2023-08-24 11:33 ` [PATCH v2 4/7] crypto: qcom-rng - Add support for trng Neil Armstrong
2023-08-28 4:59 ` Om Prakash Singh
2023-09-01 12:56 ` Om Prakash Singh
2023-09-03 17:33 ` Krzysztof Kozlowski
2023-09-04 14:57 ` Om Prakash Singh
2023-08-24 11:33 ` [PATCH v2 5/7] dt-bindings: crypto: qcom,prng: document SM8550 Neil Armstrong
2023-08-28 5:13 ` Om Prakash Singh
2023-08-24 11:33 ` [PATCH v2 6/7] arm64: dts: qcom: sm8550: add TRNG node Neil Armstrong
2023-08-24 11:49 ` Konrad Dybcio
2023-08-24 11:33 ` [PATCH v2 7/7] arm64: dts: qcom: sm8450: " Neil Armstrong
2023-08-24 11:49 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824-topic-sm8550-rng-v2-1-dfcafbb16a3e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_omprsing@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).